Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change TabularCEM interpolator #46

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Conversation

PabloCorcho
Copy link
Collaborator

I am finding that the Akima interpolator yields negative masses more often than I expected. I think I've found a better interpolator (pchip interpolation) that preserved monotonicity, which is exactly what we need.

@PabloCorcho PabloCorcho requested a review from paranoya October 19, 2024 09:29
@PabloCorcho PabloCorcho self-assigned this Oct 19, 2024
@PabloCorcho PabloCorcho merged commit bab22e6 into main Oct 28, 2024
3 checks passed
@PabloCorcho PabloCorcho deleted the feature/tabularCEM_interpolator branch October 28, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant