Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to .NET 9 #635

Open
jackdaniels980 opened this issue Nov 26, 2024 · 5 comments
Open

Add support to .NET 9 #635

jackdaniels980 opened this issue Nov 26, 2024 · 5 comments
Assignees

Comments

@jackdaniels980
Copy link

No description provided.

@pardeike
Copy link
Owner

The low level dependency that Harmony uses just recently updated to NET9 but had one bug left that was just fixed a few days ago. I will keep this Issue open as a TODO for me to get started with the addition.

One problem remains: the automatic tests in Harmony are kind of broken due to the introduction of Harmony Thin. I would feel more confident to have all tests execute correctly before I release NET9

@aaronportier
Copy link

I am using Harmony 2.3.-prerelease.5 as a Transitive package. I am seeing this error since upgrading to dot net 9. Do you believe the below needs this enhancement?

OneTimeSetUp: System.TypeInitializationException : The type initializer for '<Module>' threw an exception.
  ----> HarmonyLib.HarmonyException : Patching exception in method System.Void OpenQA.Selenium.Remote.HttpCommandExecutor::.ctor(System.Uri addressOfRemoteServer, System.TimeSpan timeout, System.Boolean enableKeepAlive)
  ----> System.MemberAccessException : Cannot create an instance of System.Reflection.Emit.LocalBuilder because it is an abstract class. 

@pardeike
Copy link
Owner

pardeike commented Dec 2, 2024

As mentioned earlier, NET9 support isn’t there yet. I have work to do after Harmony’s internal dependency just recently fixed the compatibility. Lots of personal stuff piling up for me right now but I get to it when I can.

@aaronportier
Copy link

aaronportier commented Dec 2, 2024 via email

@pardeike
Copy link
Owner

pardeike commented Dec 2, 2024

Yes, it’s something that came up with net 9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants