Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoiding testing on some repositories #1

Open
glemaitre opened this issue Feb 17, 2018 · 4 comments
Open

Avoiding testing on some repositories #1

glemaitre opened this issue Feb 17, 2018 · 4 comments

Comments

@glemaitre
Copy link
Contributor

I think that there is some repositories which does not need to be tested but I would like to be sure about it:

  • Insect 1/2/3 -> they don't have a travis. I assume that they should be difficult to test online. @kegl and @mehdidc should know about that.
  • california_rainfall/_test: The _test repo seems to be the same than the original repo but which is tested. @jorisvandenbossche should we move the testing upstream?
  • solar_wind: I think this is in dev. so we should allow failure there.
  • supernovae: @aboucaud could you check the failure ?
@aboucaud
Copy link

For supernovae, the build relies on downloading the data via python download_data.py.

Shall I add the data/*_mini.pkl to the repo or should you rather update your code to download the data ?

@glemaitre
Copy link
Contributor Author

Our test should be agnostic of what to do. Travis from supernovae should actually call python download_data.py if it is required by the test.

@aboucaud
Copy link

aboucaud commented Feb 19, 2018

it does.. https://github.com/ramp-kits/supernovae/blob/master/.travis.yml#L17

but the failure error says it could not find the files.. or maybe its just a server issue.

@jorisvandenbossche
Copy link
Member

but the failure error says it could not find the files.. or maybe its just a server issue.

@aboucaud that is because the testing data still need to be downloaded, so you need to adapt the download_data.py script a bit to download the appropriate data based on whether we are in testing mode or not (currently it is hardcoded that no data are downloaded in testing mode (https://github.com/ramp-kits/supernovae/blob/master/download_data.py#L40), but the testing data are not included in the repo, in contrast to the mars craters repo from where you probably copied that)

california_rainfall/_test: The _test repo seems to be the same than the original repo but which is tested. @jorisvandenbossche should we move the testing upstream?

Yes, I think ideally the california_rainfall and california_rainfall_test are folded into one repo, and the california_rainfall one can include/use the test data similar to how other repo's do that (eg mars craters)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants