Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict between batch transactions and mandatory headers from on-demand transactions #2415

Closed
svyatonik opened this issue May 15, 2023 · 1 comment
Assignees

Comments

@svyatonik
Copy link
Contributor

So right now when we need to deliver messages, we craft batch transaction which includes the proof of relay chain header, parachain header and proof of messages. If at the same time on-demand relay wants to submit mandatory header, one of transactions may fail (it'll be invalidated before including into the block). We need to coordinate submissions between two relay tasks.

This isn't super critical, because mandatory headers are rare on production chains, but it is still an issue.

Also this (needs investigating) may be a reason of the following error I've seen couple of times:

[BridgeHubRococo_to_BridgeHubWococo_MessageLane_00000001] 2023-05-15 07:28:28 +00 ERROR bridge Error asking for source headers at BridgeHubRococo::ReceivingConfirmationsDelivery: Custom("Failed to optimize Wococo GRANDPA jutification for header HeaderId(45, 0x8c616b5441956c6f249c51c90537f1aebfd695661c2b87c69d8c68fda503b64c): Error::InvalidAuthoritySignature"). Retrying in 0.478781692
@svyatonik svyatonik self-assigned this May 15, 2023
@EmmanuellNorbertTulbure EmmanuellNorbertTulbure transferred this issue from paritytech/parity-bridges-common Aug 25, 2023
@the-right-joyce the-right-joyce transferred this issue from paritytech/polkadot-sdk Aug 25, 2023
@EmmanuellNorbertTulbure EmmanuellNorbertTulbure added this to the Some Day Maybe milestone Sep 1, 2023
@svyatonik
Copy link
Contributor Author

superseded by #3002

@svyatonik svyatonik closed this as not planned Won't fix, can't repro, duplicate, stale May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants