From 156ec52b1387431b3027724f49c4bb2f7c864b52 Mon Sep 17 00:00:00 2001 From: Dmitry Markin Date: Fri, 27 Dec 2024 12:57:04 +0000 Subject: [PATCH] Indicate the hackish nature of the approach in the comment --- substrate/client/service/src/builder.rs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/substrate/client/service/src/builder.rs b/substrate/client/service/src/builder.rs index 2398f21eaca8..9c5de347c611 100644 --- a/substrate/client/service/src/builder.rs +++ b/substrate/client/service/src/builder.rs @@ -1153,6 +1153,10 @@ where // sync protocol is initiated fast enough // (see https://github.com/paritytech/polkadot-sdk/issues/6573#issuecomment-2563091343). // + // The solution is far from ideal, because in the client code the nework starter is + // activated once all the tasks are spawned, not once they finished the initialization, + // so the race can still happen. + // // This hack is needed at least until protocol peer sets are made independed. // See the discussion in https://github.com/paritytech/polkadot-sdk/issues/7006. let (network_start_tx, network_start_rx) = oneshot::channel();