Skip to content

Commit

Permalink
[stable2412] Backport #7158: Reject litep2p inbound requests from ban…
Browse files Browse the repository at this point in the history
…ned peers (#7182)

Backport #7158 into `stable2412` from lexnv.

See the
[documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md)
on how to use this bot.

<!--
  # To be used by other automation, do not modify:
  original-pr-number: #${pull_number}
-->

Co-authored-by: Alexandru Vasile <[email protected]>
  • Loading branch information
1 parent e8c3710 commit 8c6dd56
Show file tree
Hide file tree
Showing 2 changed files with 31 additions and 6 deletions.
12 changes: 12 additions & 0 deletions prdoc/pr_7158.prdoc
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
title: Reject litep2p inbound requests from banned peers

doc:
- audience: Node Dev
description: |
This PR rejects inbound requests from banned peers (reputation is below the banned threshold).
This mirrors the request-response implementation from the libp2p side.
While at it, have registered a new inbound failure metric to have visibility into this.

crates:
- name: sc-network
bump: patch
25 changes: 19 additions & 6 deletions substrate/client/network/src/litep2p/shim/request_response/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -273,6 +273,13 @@ impl RequestResponseProtocol {
request_id: RequestId,
request: Vec<u8>,
) {
log::trace!(
target: LOG_TARGET,
"{}: request received from {peer:?} ({fallback:?} {request_id:?}), request size {:?}",
self.protocol,
request.len(),
);

let Some(inbound_queue) = &self.inbound_queue else {
log::trace!(
target: LOG_TARGET,
Expand All @@ -284,12 +291,18 @@ impl RequestResponseProtocol {
return;
};

log::trace!(
target: LOG_TARGET,
"{}: request received from {peer:?} ({fallback:?} {request_id:?}), request size {:?}",
self.protocol,
request.len(),
);
if self.peerstore_handle.is_banned(&peer.into()) {
log::trace!(
target: LOG_TARGET,
"{}: rejecting inbound request from banned {peer:?} ({request_id:?})",
self.protocol,
);

self.handle.reject_request(request_id);
self.metrics.register_inbound_request_failure("banned-peer");
return;
}

let (tx, rx) = oneshot::channel();

match inbound_queue.try_send(IncomingRequest {
Expand Down

0 comments on commit 8c6dd56

Please sign in to comment.