From 95c7e4f033895afff223b9dfaaed6d04033b0d61 Mon Sep 17 00:00:00 2001 From: Sebastian Kunert Date: Fri, 5 Jul 2024 20:08:15 +0200 Subject: [PATCH] Stabilize elastic-scaling pov-recovery test (#4958) Timing issues in container startup have made this test flaky. We now wait for 20 and then register the parachain. This makes sure that the parachain node has the ability to see all relay chain notifications it needs. --- cumulus/zombienet/tests/0002-pov_recovery.zndsl | 4 +++- .../zombienet/tests/0009-elastic_pov_recovery.toml | 2 +- .../zombienet/tests/0009-elastic_pov_recovery.zndsl | 13 +++++++++---- 3 files changed, 13 insertions(+), 6 deletions(-) diff --git a/cumulus/zombienet/tests/0002-pov_recovery.zndsl b/cumulus/zombienet/tests/0002-pov_recovery.zndsl index b05285c87bff..dc7095ced252 100644 --- a/cumulus/zombienet/tests/0002-pov_recovery.zndsl +++ b/cumulus/zombienet/tests/0002-pov_recovery.zndsl @@ -2,7 +2,9 @@ Description: PoV recovery test Network: ./0002-pov_recovery.toml Creds: config -# wait 20 blocks and register parachain +# Wait 20 blocks and register parachain. This part is important for pov-recovery. +# We need to make sure that the recovering node is able to see all relay-chain +# notifications containing the candidates to recover. validator-3: reports block height is at least 20 within 250 seconds validator-0: js-script ./register-para.js with "2000" within 240 seconds validator-0: parachain 2000 is registered within 300 seconds diff --git a/cumulus/zombienet/tests/0009-elastic_pov_recovery.toml b/cumulus/zombienet/tests/0009-elastic_pov_recovery.toml index 9b296e8a8b36..b695f8aa9376 100644 --- a/cumulus/zombienet/tests/0009-elastic_pov_recovery.toml +++ b/cumulus/zombienet/tests/0009-elastic_pov_recovery.toml @@ -30,7 +30,7 @@ command = "polkadot" [[parachains]] id = 2100 chain = "elastic-scaling" -add_to_genesis = true +add_to_genesis = false # Slot based authoring with 3 cores and 2s slot duration [[parachains.collators]] diff --git a/cumulus/zombienet/tests/0009-elastic_pov_recovery.zndsl b/cumulus/zombienet/tests/0009-elastic_pov_recovery.zndsl index 3a805078112c..5cca6120ff3a 100644 --- a/cumulus/zombienet/tests/0009-elastic_pov_recovery.zndsl +++ b/cumulus/zombienet/tests/0009-elastic_pov_recovery.zndsl @@ -5,12 +5,17 @@ Creds: config alice: is up collator-elastic: is up -# wait 20 blocks and register parachain +# configure relay chain +alice: js-script ./assign-core.js with "2100,0" return is 0 within 200 seconds +alice: js-script ./assign-core.js with "2100,1" return is 0 within 200 seconds + +# Wait 20 blocks and register parachain. This part is important for pov-recovery. +# We need to make sure that the recovering node is able to see all relay-chain +# notifications containing the candidates to recover. alice: reports block height is at least 20 within 250 seconds +alice: js-script ./register-para.js with "2100" within 240 seconds +alice: parachain 2100 is registered within 300 seconds -# configure relay chain -alice: js-script ./assign-core.js with "2100,0" return is 0 within 600 seconds -alice: js-script ./assign-core.js with "2100,1" return is 0 within 600 seconds # check block production collator-elastic: reports block height is at least 40 within 225 seconds