Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pallets should not return max_block as weight in on_initialize #4573

Closed
1 task
bkchr opened this issue May 24, 2024 · 2 comments
Closed
1 task

Pallets should not return max_block as weight in on_initialize #4573

bkchr opened this issue May 24, 2024 · 2 comments
Labels
I2-bug The node fails to follow expected behavior. I4-refactor Code needs refactoring.

Comments

@bkchr
Copy link
Member

bkchr commented May 24, 2024

With the changes to CheckWeight that also take the transaction size into account, we have discovered this bug. The underlying problem is the usage of max_block as return in on_initialize. We should check all the pallets and fix this problematic pattern.

Pallets to fix (non exhaustive list):

  • pallet-session
@bkchr bkchr added I2-bug The node fails to follow expected behavior. I4-refactor Code needs refactoring. labels May 24, 2024
@xlc
Copy link
Contributor

xlc commented May 25, 2024

we keep rediscovering the same bug #184

@bkchr
Copy link
Member Author

bkchr commented May 25, 2024

Looks like I should have used the search 🙈

@bkchr bkchr closed this as completed May 25, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in Runtime / FRAME May 25, 2024
@bkchr bkchr mentioned this issue May 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I2-bug The node fails to follow expected behavior. I4-refactor Code needs refactoring.
Projects
Runtime / FRAME
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xlc @bkchr