Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

networking::TransactionPool should accept Arc. #5978

Closed
Tracked by #5472
michalkucharczyk opened this issue Oct 8, 2024 · 4 comments · Fixed by #7042
Closed
Tracked by #5472

networking::TransactionPool should accept Arc. #5978

michalkucharczyk opened this issue Oct 8, 2024 · 4 comments · Fixed by #7042
Assignees
@michalkucharczyk @dharjeezy
Labels
T0-node This PR/Issue is related to the topic “node”.

Comments

@michalkucharczyk
Copy link
Contributor 

          We should not do this here. Please create a follow up. The `TransactionPool` trait from networking should also just take an `Arc`. No need to clone the pure tx data for sending/encoding it.

Originally posted by @bkchr in #4639 (comment)
@michalkucharczyk michalkucharczyk mentioned this issue Oct 8, 2024
Open
@michalkucharczyk michalkucharczyk self-assigned this Oct 8, 2024
@michalkucharczyk michalkucharczyk mentioned this issue Oct 8, 2024
Merged
@dharjeezy
Copy link
Contributor

Hello @michalkucharczyk

should all functions defined in the pub trait TransactionPool<H: ExHashT, B: BlockT>: Send + Sync take an Arc of transaction?

@bkchr
Copy link
Member

bkchr commented Dec 28, 2024

Yes.

@dharjeezy dharjeezy mentioned this issue Jan 4, 2025
Merged
@michalkucharczyk
Copy link
Contributor Author

For the record: #7042 (comment)

@bkchr
Copy link
Member

bkchr commented Jan 6, 2025

Yeah, apparently I did not had checked the trait properly :P

@michalkucharczyk michalkucharczyk moved this from Todo to In Progress in fork-aware-txpool Jan 7, 2025
@michalkucharczyk michalkucharczyk added the T0-node This PR/Issue is related to the topic “node”. label Jan 8, 2025
github-merge-queue bot pushed a commit that referenced this issue Jan 27, 2025
@dharjeezy @michalkucharczyk
Arc definition in TransactionPool (#7042)
b2004ed 
closes #5978

---------

Co-authored-by: command-bot <>
Co-authored-by: Michal Kucharczyk <[email protected]>
@github-project-automation github-project-automation bot moved this from In Progress to Done in fork-aware-txpool Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michalkucharczyk michalkucharczyk

@dharjeezy dharjeezy

Labels
T0-node This PR/Issue is related to the topic “node”.
Projects
fork-aware-txpool
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Arc definition in TransactionPool dharjeezy/polkadot-sdk
3 participants
@michalkucharczyk @bkchr @dharjeezy