Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up for: Use the umbrella crate for the parachain template #5993

Open
4 tasks
serban300 opened this issue Oct 9, 2024 · 4 comments
Open
4 tasks

Follow up for: Use the umbrella crate for the parachain template #5993

serban300 opened this issue Oct 9, 2024 · 4 comments
Assignees
Labels
T17-Templates This PR/Issue is related to templates

Comments

@serban300
Copy link
Contributor

serban300 commented Oct 9, 2024

Follow up for: #5991

Also related to #4782

Still need to replace the following dependencies with polkadot-sdk umbrella dependencies:

  • parachain-template-node - sc-tracing

Getting an error for the #[polkadot_sdk::sc_tracing::logging::prefix_logs_with("Parachain")]:

error: Could not find `sc-tracing` in `dependencies` or `dev-dependencies` in `/media/serban/data/workplace/sources/polkadot-sdk/templates/parachain/node/Cargo.toml`!
   --> templates/parachain/node/src/service.rs:235:1
    |
235 | #[polkadot_sdk::sc_tracing::logging::prefix_logs_with("Parachain")]
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: this error originates in the attribute macro `polkadot_sdk::sc_tracing::logging::prefix_logs_with` (in Nightly builds, run with -Z macro-backtrace for more info)
  • parachain-template-runtime - cumulus-pallet-parachain-system

Similar error with the one above when using a macro from cumulus-pallet-parachain-system

  • parachain-template-runtime - substrate-wasm-builder -> the metadata-hash feature can't be enabled through the umbrella crate

  • parachain-template-node - prometheus-endpoint -> not part of the umbrella crate

@serban300 serban300 added the T17-Templates This PR/Issue is related to templates label Oct 9, 2024
github-merge-queue bot pushed a commit that referenced this issue Oct 14, 2024
Use the umbrella crate for the parachain template

This covers almost all the dependencies. There are just a few exceptions
for which I created a separate issue:
#5993

Also related to: #4782
@seemantaggarwal seemantaggarwal self-assigned this Feb 4, 2025
@seemantaggarwal
Copy link
Contributor

I will take this

@seemantaggarwal
Copy link
Contributor

So I tried simply removing sc-tracing from polkadot-sdk/templates/parachain/node/Cargo.toml and ran cargo build --all-features
and it works, looks like we do not need that anymore atleast

@seemantaggarwal
Copy link
Contributor

As my task is limited to the parachain scope, I will leave that here, I am not marking it done here, but atleast the error above is solved, ig?

@seemantaggarwal
Copy link
Contributor

For referent to @kianenigma and @serban300 #7464

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T17-Templates This PR/Issue is related to templates
Projects
None yet
Development

No branches or pull requests

2 participants