Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fatxpool: ready_at_light optimization #6056

Open
Tracked by #5472
michalkucharczyk opened this issue Oct 14, 2024 · 0 comments
Open
Tracked by #5472

fatxpool: ready_at_light optimization #6056

michalkucharczyk opened this issue Oct 14, 2024 · 0 comments
Assignees
Labels
T0-node This PR/Issue is related to the topic “node”.

Comments

@michalkucharczyk
Copy link
Contributor

I still think that the following should be faster:

let mut to_process = Vec::new();
while at.number() > last_finalized.number() {
    if self.view_exists(at.hash()) { break }
    to_process.push(at.hash());
   at = at.parent();
}

No need to get a tree route down to the finalized block.

Originally posted by @bkchr in #4639 (comment)

@michalkucharczyk michalkucharczyk self-assigned this Oct 15, 2024
@michalkucharczyk michalkucharczyk added the T0-node This PR/Issue is related to the topic “node”. label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T0-node This PR/Issue is related to the topic “node”.
Projects
None yet
Development

No branches or pull requests

2 participants