Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExceedsStackLimit was meant to be used before running XCMs but it's being used in FrameTransactionalProcessor in instructions #6199

Open
franciscoaguirre opened this issue Oct 23, 2024 · 1 comment
Labels
T6-XCM This PR/Issue is related to XCM.

Comments

@franciscoaguirre
Copy link
Contributor

This error had no index and was not part of the spec because it was meant to be used only before XCMs were executed, so only locally.
It's being used in the FrameTransactionalProcessor which is called on a lot of instructions.
This means we either need to include it in the spec or change the error to another one that is/will be in the spec.

@franciscoaguirre franciscoaguirre added the T6-XCM This PR/Issue is related to XCM. label Oct 23, 2024
@ggwpez
Copy link
Member

ggwpez commented Oct 23, 2024

We also match on this variant here:

xcm::latest::Error::ExceedsStackLimit => ProcessMessageError::StackLimitReached,

The MQ pallet needs to know that it was a StackExceedsError - or rather: a transient error that may fix itself spontaneously through a user-retry but is not related to weight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T6-XCM This PR/Issue is related to XCM.
Projects
None yet
Development

No branches or pull requests

2 participants