Refactor pallets to V2 bench syntax #6202

ggwpez · 2024-10-23T17:01:14Z

We should move all remaining pallets to the V2 benchmarking syntax. It seems to be stable and feature complete.

👉 If you want to work on this: Please check that there is not already a merge request for the pallet that you want to work on. Please pick only one or a small set of pallets - not all at once. This keeps review times low.

Full pallet list:

Then the Polkadot and Cumulus pallets:

The text was updated successfully, but these errors were encountered:

aurexav · 2024-10-28T05:20:17Z

Some updates:

babe, fast-unstake Migrate some pallets to benchmark v2 #6311
child-bounties Migrate pallet-child-bounties benchmark to v2 #6310
claims Refactor pallet claims #6318
elections-phragmen Migrate pallet-elections-phragmen benchmark to v2 and improve doc #6314
election-provider-multi-phase Migrate pallet-election-provider-multi-phase benchmark to v2 and improve doc #6316
election-provider-support-benchmarking Migrate pallet-election-provider-support-benchmarking benchmark to v2 #6315
glutton Migrate pallet-glutton benchmark to v2 #6296
im-online Migrate pallet-im-online benchmark to v2 #6295
inclusion Migrate inclusion benchmark to v2 #6368
multisig, proxy Use frame umbrella crate in pallet-proxy and pallet-multisig #5995
nis Migrate pallet-nis benchmark to v2 #6293
nft-fractionalization migrate pallet-nft-fractionalization to benchmarking v2 syntax #6301
nomination-pool migrate pallet-nomination-pool-benchmarking to benchmarking syntax v2 #6302
preimage Migrate pallet-preimage to benchmark v2 #6277
offences migrate pallet-offences-benchmarking to benchmark v2 syntax #6300
recovery migrate pallet-recovery to benchmark V2 syntax #6299
remark migrate pallet-remarks to v2 bench syntax #6291
scheduler Migrate pallet-scheduler benchmark to v2 #6292
session migrate pallet-session-benchmarking to bench V2 syntax #6294
society Refactor pallet society #6367
timestamp Migrate pallet-timestamp benchmark to v2 #6258
transaction-storage, indices Migrate pallet-transaction-storage and pallet-indices to benchmark v2 #6290
utility Migrate pallet-utility to benchmark v2 #6276
vesting Migrate pallet-vesting benchmark to v2 #6254

Part of: - #6202.

Part of: - #6202 --------- Co-authored-by: Dónal Murray <[email protected]>

Part of: - paritytech#6202.

Part of: - paritytech#6202 --------- Co-authored-by: Dónal Murray <[email protected]>

Part of: - paritytech#6202.

Part of: - paritytech#6202 --------- Co-authored-by: Dónal Murray <[email protected]>

programskillforverification · 2024-10-30T13:19:51Z

Pick up:

transaction-storage, indices Migrate pallet-transaction-storage and pallet-indices to benchmark v2 #6290
babe, child-bounties, fast-unstake Migrate some pallets to benchmark v2 #6311
democracy

Part of: - #6202. --------- Co-authored-by: Dónal Murray <[email protected]>

clangenb · 2024-10-30T13:55:51Z

Pickup:

pallet-remark, done: migrate pallet-remarks to v2 bench syntax #6291
~~pallet-scheduler~~

aurexav · 2024-10-30T13:59:57Z

Pickup:

pallet-remark, pallet-scheduler

Hi, I'm working scheduler currently. :)

clangenb · 2024-10-30T14:00:24Z

Thanks for the quick response 🚀

clangenb · 2024-10-30T14:23:36Z

Pickup:

pallet-sessions, done: migrate pallet-session-benchmarking to bench V2 syntax #6294
pallet-recovery, done: migrate pallet-recovery to benchmark V2 syntax #6299
pallet-offences, done: migrate pallet-offences-benchmarking to benchmark v2 syntax #6300

aurexav · 2024-10-30T14:50:41Z

Pick up:

transaction-storage, indices

babe, child-bounties, democracy

fast-unstake, glutton

Well... I recommend handling them individually and providing updates here, rather than claiming them all at once.

… syntax (#6576) [polkadot-runtime-parachains] migrate paras module to benchmarking v2 syntax Part of: * #6202 --------- Co-authored-by: Bastian Köcher <[email protected]>

…ch#6509) # Description Migrates pallet-democracy benchmarks to benchmark v2 syntax This is Part of paritytech#6202 --------- Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: command-bot <> Co-authored-by: Dmitry Markin <[email protected]> Co-authored-by: Alexandru Vasile <[email protected]>

Part of: - paritytech#6202. --------- Signed-off-by: Xavier Lau <[email protected]> Co-authored-by: Giuseppe Re <[email protected]> Co-authored-by: Guillaume Thiolliere <[email protected]>

# Description Migrated pallet-xcm-benchmarks to benchmaking syntax V2 This is part of paritytech#6202 --------- Co-authored-by: Giuseppe Re <[email protected]>

…6617) # Description Migrated pallet-state-trie-migration benchmarking to the new benchmarking syntax v2. This is part of paritytech#6202 Co-authored-by: Shawn Tabrizi <[email protected]> Co-authored-by: Giuseppe Re <[email protected]>

Part of: - paritytech#6202. --------- Co-authored-by: Giuseppe Re <[email protected]> Co-authored-by: command-bot <>

Migrates pallet-session-benchmarking to bench V2 syntax. Part of: * paritytech#6202 --------- Co-authored-by: Shawn Tabrizi <[email protected]> Co-authored-by: Giuseppe Re <[email protected]>

…ch#6300) Migrates pallet-offences-benchmarking to benchmark v2 syntax. Part of: * paritytech#6202 --------- Co-authored-by: Giuseppe Re <[email protected]>

Migrates pallet-xcm benchmarks to benchmark v2 syntax * Part of #6202

Migrates pallet-xcm benchmarks to benchmark v2 syntax * Part of paritytech#6202

…to benchmarking to bench v2 syntax (#6577) [polkadot-runtime-parachains] migrate disputes and disputes/slashing to benchmarking to bench v2 syntax Part of: * #6202 --------- Co-authored-by: Giuseppe Re <[email protected]> Co-authored-by: Bastian Köcher <[email protected]>

…paritytech#6290) Part of: paritytech#6202 --------- Co-authored-by: Giuseppe Re <[email protected]> Co-authored-by: GitHub Action <[email protected]>

…ytech#6301) Migrates pallet-nft-fractionalization to benchmarking v2 syntax. Part of: * paritytech#6202 --------- Co-authored-by: Giuseppe Re <[email protected]> Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Bastian Köcher <[email protected]>

Part of: - paritytech#6202. --------- Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Giuseppe Re <[email protected]>

- [x] Removing `without_storage_info` and adding bounds on the stored types for pallet `society` - issue paritytech#6289 - [x] Migrating to benchmarking V2 - paritytech#6202 --------- Co-authored-by: Guillaume Thiolliere <[email protected]> Co-authored-by: Muharem <[email protected]>

…paritytech#6302) Migrates pallet-nomination-pool-benchmarking to benchmarking syntax v2. Part of: * paritytech#6202 --------- Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Guillaume Thiolliere <[email protected]> Co-authored-by: Giuseppe Re <[email protected]>

Part of paritytech#6202 --------- Co-authored-by: Guillaume Thiolliere <[email protected]> Co-authored-by: Giuseppe Re <[email protected]>

…ch#6509) # Description Migrates pallet-democracy benchmarks to benchmark v2 syntax This is Part of paritytech#6202 --------- Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: command-bot <> Co-authored-by: Dmitry Markin <[email protected]> Co-authored-by: Alexandru Vasile <[email protected]>

Part of: - paritytech#6202. --------- Signed-off-by: Xavier Lau <[email protected]> Co-authored-by: Giuseppe Re <[email protected]> Co-authored-by: Guillaume Thiolliere <[email protected]>

# Description Migrated pallet-xcm-benchmarks to benchmaking syntax V2 This is part of paritytech#6202 --------- Co-authored-by: Giuseppe Re <[email protected]>

…6617) # Description Migrated pallet-state-trie-migration benchmarking to the new benchmarking syntax v2. This is part of paritytech#6202 Co-authored-by: Shawn Tabrizi <[email protected]> Co-authored-by: Giuseppe Re <[email protected]>

Part of: - paritytech#6202. --------- Co-authored-by: Giuseppe Re <[email protected]> Co-authored-by: command-bot <>

Migrates pallet-session-benchmarking to bench V2 syntax. Part of: * paritytech#6202 --------- Co-authored-by: Shawn Tabrizi <[email protected]> Co-authored-by: Giuseppe Re <[email protected]>

…ch#6300) Migrates pallet-offences-benchmarking to benchmark v2 syntax. Part of: * paritytech#6202 --------- Co-authored-by: Giuseppe Re <[email protected]>

…itytech#6613) # Description Migrated polkadot-runtime-common auctions benchmarking to the new benchmarking syntax v2. This is part of paritytech#6202 --------- Co-authored-by: Giuseppe Re <[email protected]> Co-authored-by: Bastian Köcher <[email protected]>

… syntax (paritytech#6576) [polkadot-runtime-parachains] migrate paras module to benchmarking v2 syntax Part of: * paritytech#6202 --------- Co-authored-by: Bastian Köcher <[email protected]>

Migrates pallet-xcm benchmarks to benchmark v2 syntax * Part of paritytech#6202

…to benchmarking to bench v2 syntax (paritytech#6577) [polkadot-runtime-parachains] migrate disputes and disputes/slashing to benchmarking to bench v2 syntax Part of: * paritytech#6202 --------- Co-authored-by: Giuseppe Re <[email protected]> Co-authored-by: Bastian Köcher <[email protected]>

ggwpez added this to Runtime / FRAME Oct 23, 2024

github-project-automation bot moved this to Backlog in Runtime / FRAME Oct 23, 2024

ggwpez changed the title ~~Migrate all pallets to benchmarking V2 syntax~~ Refactor pallets to V2 bench syntax Oct 23, 2024

ggwpez mentioned this issue Oct 23, 2024

undetected unused variables in frame benchmarking V1 #6078

Open

This was referenced Oct 28, 2024

Migrate pallet-vesting benchmark to v2 #6254

Merged

Migrate pallet-timestamp benchmark to v2 #6258

Merged

github-merge-queue bot pushed a commit that referenced this issue Oct 29, 2024

Migrate pallet-vesting benchmark to v2 (#6254)

1497635

Part of: - #6202.

github-merge-queue bot pushed a commit that referenced this issue Oct 29, 2024

Migrate pallet-timestamp benchmark to v2 (#6258)

80cd5fd

Part of: - #6202 --------- Co-authored-by: Dónal Murray <[email protected]>

This was referenced Oct 29, 2024

Migrate pallet-utility to benchmark v2 #6276

Merged

Migrate pallet-preimage to benchmark v2 #6277

Merged

mordamax pushed a commit to paritytech-stg/polkadot-sdk that referenced this issue Oct 29, 2024

Migrate pallet-vesting benchmark to v2 (paritytech#6254)

1819d89

Part of: - paritytech#6202.

mordamax pushed a commit to paritytech-stg/polkadot-sdk that referenced this issue Oct 29, 2024

Migrate pallet-timestamp benchmark to v2 (paritytech#6258)

dee9777

Part of: - paritytech#6202 --------- Co-authored-by: Dónal Murray <[email protected]>

mordamax pushed a commit to paritytech-stg/polkadot-sdk that referenced this issue Oct 29, 2024

Migrate pallet-vesting benchmark to v2 (paritytech#6254)

65ee481

Part of: - paritytech#6202.

mordamax pushed a commit to paritytech-stg/polkadot-sdk that referenced this issue Oct 29, 2024

Migrate pallet-timestamp benchmark to v2 (paritytech#6258)

b41419a

Part of: - paritytech#6202 --------- Co-authored-by: Dónal Murray <[email protected]>

github-merge-queue bot pushed a commit that referenced this issue Oct 30, 2024

Migrate pallet-utility to benchmark v2 (#6276)

06debd0

Part of: - #6202. --------- Co-authored-by: Dónal Murray <[email protected]>

programskillforverification mentioned this issue Oct 30, 2024

Migrate pallet-transaction-storage and pallet-indices to benchmark v2 #6290

Merged

clangenb mentioned this issue Oct 30, 2024

migrate pallet-remarks to v2 bench syntax #6291

Merged

This was referenced Oct 30, 2024

Migrate pallet-scheduler benchmark to v2 #6292

Merged

Migrate pallet-nis benchmark to v2 #6293

Open

Krayt78 pushed a commit to Krayt78/polkadot-sdk that referenced this issue Dec 18, 2024

Migrate pallet-preimage to benchmark v2 (paritytech#6277)

ccbe090

Part of: - paritytech#6202. --------- Co-authored-by: Giuseppe Re <[email protected]> Co-authored-by: command-bot <>

github-merge-queue bot pushed a commit that referenced this issue Dec 18, 2024

Migrate pallet-xcm benchmarks to benchmark v2 syntax (#6501)

6dd4a71

Migrates pallet-xcm benchmarks to benchmark v2 syntax * Part of #6202

mordamax pushed a commit to paritytech-stg/polkadot-sdk that referenced this issue Dec 18, 2024

Migrate pallet-xcm benchmarks to benchmark v2 syntax (paritytech#6501)

72bd8ee

Migrates pallet-xcm benchmarks to benchmark v2 syntax * Part of paritytech#6202

mordamax pushed a commit to paritytech-stg/polkadot-sdk that referenced this issue Dec 18, 2024

Migrate pallet-xcm benchmarks to benchmark v2 syntax (paritytech#6501)

f3f66eb

Migrates pallet-xcm benchmarks to benchmark v2 syntax * Part of paritytech#6202

re-gius mentioned this issue Jan 2, 2025

[tracking] Migrate pallets to umbrella crate #6504

Open

91 tasks

dudo50 pushed a commit to paraspell-research/polkadot-sdk that referenced this issue Jan 4, 2025

Migrate pallet-preimage to benchmark v2 (paritytech#6277)

c7ecc8d

Part of: - paritytech#6202. --------- Co-authored-by: Giuseppe Re <[email protected]> Co-authored-by: command-bot <>

dudo50 pushed a commit to paraspell-research/polkadot-sdk that referenced this issue Jan 4, 2025

Migrate pallet-xcm benchmarks to benchmark v2 syntax (paritytech#6501)

fbc9b04

Migrates pallet-xcm benchmarks to benchmark v2 syntax * Part of paritytech#6202

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor pallets to V2 bench syntax #6202

Refactor pallets to V2 bench syntax #6202

ggwpez commented Oct 23, 2024 •

edited by re-gius

Loading

aurexav commented Oct 28, 2024 •

edited

Loading

programskillforverification commented Oct 30, 2024 •

edited

Loading

clangenb commented Oct 30, 2024 •

edited

Loading

aurexav commented Oct 30, 2024

clangenb commented Oct 30, 2024

clangenb commented Oct 30, 2024 •

edited

Loading

aurexav commented Oct 30, 2024

Refactor pallets to V2 bench syntax #6202

Refactor pallets to V2 bench syntax #6202

Comments

ggwpez commented Oct 23, 2024 • edited by re-gius Loading

aurexav commented Oct 28, 2024 • edited Loading

programskillforverification commented Oct 30, 2024 • edited Loading

clangenb commented Oct 30, 2024 • edited Loading

aurexav commented Oct 30, 2024

clangenb commented Oct 30, 2024

clangenb commented Oct 30, 2024 • edited Loading

aurexav commented Oct 30, 2024

ggwpez commented Oct 23, 2024 •

edited by re-gius

Loading

aurexav commented Oct 28, 2024 •

edited

Loading

programskillforverification commented Oct 30, 2024 •

edited

Loading

clangenb commented Oct 30, 2024 •

edited

Loading

clangenb commented Oct 30, 2024 •

edited

Loading