-
Notifications
You must be signed in to change notification settings - Fork 747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tracking] adopt BlockNumberProvider
for the pallets migrating to AH
#6297
Comments
Love to take on some tasks once the #3970 is merged as a standard to follow. |
@AurevoirXavier it is merged now |
is anyone working |
pallet nis make use of |
is anyone working on |
Make pallet-recovery supports `BlockNumberProvider`. Part of #6297. --- Polkadot address: 156HGo9setPcU2qhFMVWLkcmtCEGySLwNqa3DaEiYSWtte4Y --------- Co-authored-by: Guillaume Thiolliere <[email protected]> Co-authored-by: GitHub Action <[email protected]>
Some of the pallets migrating from the Relay Chain to the Asset Hub require a more deterministic clock than what a parachain can provide. To address this, the decision was made to adapt these pallets to use a configurable block number provider, which can be set to the Relay Chain’s block number provider for greater determinism. (For more details, see the discussions at #3268). This approach will also simplify the migration of pallets' state from the Relay Chain to the Asset Hub since, in most cases, block numbers won’t require mapping.
Task:
Adapt
BlockNumberProvider
for the pallets migrating to the Asset Hub:BlockNumberProvider
configuration parameter and use itscurrent_block_number
function as the time reference instead ofSystem::<T>::block_number()
.on_initialize(n)
are compatible with theBlockNumberProvider
and can handle cases when the hook isn’t called on every tick (e.g., adapt conditions that rely on exact matches likecompilation_time == BlockNumberProvider::current_block_number()
).BlockNumberProvider::BlockNumber
when migrated to BlockNumberProvider).BountyUpdatePeriod
, and storage fields. Documentation should clarify for users that block numbers refer to those fromConfig::BlockNumberProvider
, which may come from either the local parachain or the Relay Chain.Reference PR: #3970
Pallet list:
(when you start to work on a pallet, pul your name next to it or leave a comment)
BlockNumberProvider
#6446The text was updated successfully, but these errors were encountered: