Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove message from frame-omni-bencher CLI #7019

Closed
0xLucca opened this issue Dec 30, 2024 · 2 comments · Fixed by #7020
Closed

Remove message from frame-omni-bencher CLI #7019

0xLucca opened this issue Dec 30, 2024 · 2 comments · Fixed by #7020
Labels
I10-unconfirmed Issue might be valid, but it's not yet known.

Comments

@0xLucca
Copy link
Contributor

0xLucca commented Dec 30, 2024

The frame-omni-bencher CLI currently displays a warning message about the tool not being battle tested, despite being included in the stable release polkadot-stable2412.

Current warning message:

2024-12-30T11:50:05.289526Z  WARN frame_omni_bencher: The FRAME omni-bencher is not yet battle tested - double check the results.    
Freestanding benchmark runner for any Polkadot runtime.

Usage: frame-omni-bencher <COMMAND>

Commands:
  v1    Compatibility syntax with the old benchmark runner
  help  Print this message or the help of the given subcommand(s)

Options:
  -h, --help     Print help (see more with '--help')
  -V, --version  Print version
@github-actions github-actions bot added the I10-unconfirmed Issue might be valid, but it's not yet known. label Dec 30, 2024
@0xLucca 0xLucca mentioned this issue Dec 30, 2024
Merged
@bkchr
Copy link
Member

bkchr commented Dec 30, 2024

CC @ggwpez

github-merge-queue bot pushed a commit that referenced this issue Jan 2, 2025
@0xLucca @ggwpez
Remove warning log from frame-omni-bencher CLI (#7020)
bdd1193 
# Description

This PR removes the outdated warning message from the
`frame-omni-bencher` CLI that states the tool is "not yet battle
tested". Fixes #7019

## Integration

No integration steps are required.

## Review Notes

The functionality of the tool remains unchanged. Removes the warning
message from the CLI output.

---------

Co-authored-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: command-bot <>
@paritytech paritytech deleted a comment from 1Sam2024 Jan 3, 2025
@ggwpez
Copy link
Member

ggwpez commented Jan 3, 2025

^ FYI to anyone who clicked it. This was a phishing comment.

dudo50 pushed a commit to paraspell-research/polkadot-sdk that referenced this issue Jan 4, 2025
@0xLucca @ggwpez @dudo50
Remove warning log from frame-omni-bencher CLI (paritytech#7020)
c3a851c 
# Description

This PR removes the outdated warning message from the
`frame-omni-bencher` CLI that states the tool is "not yet battle
tested". Fixes paritytech#7019

## Integration

No integration steps are required.

## Review Notes

The functionality of the tool remains unchanged. Removes the warning
message from the CLI output.

---------

Co-authored-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: command-bot <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I10-unconfirmed Issue might be valid, but it's not yet known.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove warning log from frame-omni-bencher CLI 0xLucca/polkadot-sdk
3 participants
@bkchr @ggwpez @0xLucca