Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fungible and fungibles adapters should allow account death like burns and mints #7039

Open
franciscoaguirre opened this issue Jan 3, 2025 · 1 comment
Labels
T6-XCM This PR/Issue is related to XCM.

Comments

@franciscoaguirre
Copy link
Contributor

The fungible and fungibles adapters set the preservation of the burn operation to Expendable: here and here.
This allows accounts to transfer all their funds (and getting reaped because of it) out of their account.
However, this only works if they're using the WithdrawAsset and DepositAsset instructions, which correspond to burn_from and mint_into.
If TransferAsset is used, as is the case with limited_reserve_assets_transfer, then the transfer function will be called with Preserve.

This distinction is arbitrary and we should change the way TransferAsset is handled to also allow transferring all the funds of an account. It results in confusing errors for users.
If needed, we could add a Hint for changing the default of ALL operations from Expendable to Preserve.

@franciscoaguirre franciscoaguirre added the T6-XCM This PR/Issue is related to XCM. label Jan 3, 2025
@antonkhvorov
Copy link

Very much needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T6-XCM This PR/Issue is related to XCM.
Projects
Status: No status
Development

No branches or pull requests

2 participants