Need to rewrite defensive! macro to be compatible with umbrella crate

[Krayt78]

As seen during pallet migrations in here : #6504

The current implementation of the defensive! macro is dependent on having frame_support as seen here : https://paritytech.github.io/polkadot-sdk/master/src/frame_support/traits/misc.rs.html#67-95

We need to change this dependency to be compatible with umbrella crate

[gui1117]

Isn't it possible to just replace frame_support with $crate in the macro?

[Krayt78]

Isn't it possible to just replace frame_support with $crate in the macro?

should do the trick yeah

[Krayt78]

The PR for this is in here #7069

[seemantaggarwal]

Hey, I already made the changes as part of my commit here: https://github.com/paritytech/polkadot-sdk/pull/7048/commits I will merge mine soon, you can discard this issue, or update with my commit

[Krayt78]

Hey, I already made the changes as part of my commit here: https://github.com/paritytech/polkadot-sdk/pull/7048/commits I will merge mine soon, you can discard this issue, or update with my commit

Wouldnt it be better to have a seperate PR for this ? just in case we need to revert it and it would be faster to merge

[re-gius]

I'm merging #7069 since it's already ready to merge and could unblock other PRs + easy to revert

[re-gius]

closed by #7069