From 962a5ba73f436bbccd73ebae1a5120d35b49ecff Mon Sep 17 00:00:00 2001 From: alvicsam Date: Thu, 27 Jun 2024 12:09:23 +0200 Subject: [PATCH 01/52] [WIP][ci] Test oldkernel runners --- .github/workflows/tests-linux-stable.yml | 31 +++++++++++++++++++ .../workflows/{ => tmp}/check-features.yml | 0 .github/workflows/{ => tmp}/check-labels.yml | 0 .../workflows/{ => tmp}/check-licenses.yml | 0 .github/workflows/{ => tmp}/check-links.yml | 0 .github/workflows/{ => tmp}/check-prdoc.yml | 0 .../{ => tmp}/check-runtime-migration.yml | 0 .github/workflows/{ => tmp}/check-semver.yml | 0 .github/workflows/{ => tmp}/checks-quick.yml | 0 .../workflows/{ => tmp}/command-bench-all.yml | 0 .../{ => tmp}/command-bench-overhead.yml | 0 .github/workflows/{ => tmp}/command-bench.yml | 0 .github/workflows/{ => tmp}/command-fmt.yml | 0 .../workflows/{ => tmp}/command-inform.yml | 0 .../workflows/{ => tmp}/command-update-ui.yml | 0 .../{ => tmp}/gitspiegel-trigger.yml | 0 .../{ => tmp}/issues-auto-add-parachain.yml | 0 .../workflows/{ => tmp}/issues-auto-label.yml | 0 .../{ => tmp}/misc-notify-burnin-label.yml | 0 .../{ => tmp}/misc-review-bot-merge-queue.yml | 0 .../{ => tmp}/misc-sync-templates.yml | 0 .../{ => tmp}/publish-check-crates.yml | 0 .../{ => tmp}/publish-claim-crates.yml | 0 .../publish-subsystem-benchmarks.yml | 0 .../{ => tmp}/release-10_rc-automation.yml | 0 .../release-30_publish_release_draft.yml | 0 .../{ => tmp}/release-50_publish-docker.yml | 0 .../{ => tmp}/release-99_notif-published.yml | 0 .../{ => tmp}/release-check-runtimes.yml | 0 .../{ => tmp}/release-clobber-stable.yml | 0 .../workflows/{ => tmp}/release-srtool.yml | 0 .github/workflows/{ => tmp}/review-bot.yml | 0 .../workflows/{ => tmp}/review-trigger.yml | 0 .github/workflows/{ => tmp}/tests.yml | 0 34 files changed, 31 insertions(+) rename .github/workflows/{ => tmp}/check-features.yml (100%) rename .github/workflows/{ => tmp}/check-labels.yml (100%) rename .github/workflows/{ => tmp}/check-licenses.yml (100%) rename .github/workflows/{ => tmp}/check-links.yml (100%) rename .github/workflows/{ => tmp}/check-prdoc.yml (100%) rename .github/workflows/{ => tmp}/check-runtime-migration.yml (100%) rename .github/workflows/{ => tmp}/check-semver.yml (100%) rename .github/workflows/{ => tmp}/checks-quick.yml (100%) rename .github/workflows/{ => tmp}/command-bench-all.yml (100%) rename .github/workflows/{ => tmp}/command-bench-overhead.yml (100%) rename .github/workflows/{ => tmp}/command-bench.yml (100%) rename .github/workflows/{ => tmp}/command-fmt.yml (100%) rename .github/workflows/{ => tmp}/command-inform.yml (100%) rename .github/workflows/{ => tmp}/command-update-ui.yml (100%) rename .github/workflows/{ => tmp}/gitspiegel-trigger.yml (100%) rename .github/workflows/{ => tmp}/issues-auto-add-parachain.yml (100%) rename .github/workflows/{ => tmp}/issues-auto-label.yml (100%) rename .github/workflows/{ => tmp}/misc-notify-burnin-label.yml (100%) rename .github/workflows/{ => tmp}/misc-review-bot-merge-queue.yml (100%) rename .github/workflows/{ => tmp}/misc-sync-templates.yml (100%) rename .github/workflows/{ => tmp}/publish-check-crates.yml (100%) rename .github/workflows/{ => tmp}/publish-claim-crates.yml (100%) rename .github/workflows/{ => tmp}/publish-subsystem-benchmarks.yml (100%) rename .github/workflows/{ => tmp}/release-10_rc-automation.yml (100%) rename .github/workflows/{ => tmp}/release-30_publish_release_draft.yml (100%) rename .github/workflows/{ => tmp}/release-50_publish-docker.yml (100%) rename .github/workflows/{ => tmp}/release-99_notif-published.yml (100%) rename .github/workflows/{ => tmp}/release-check-runtimes.yml (100%) rename .github/workflows/{ => tmp}/release-clobber-stable.yml (100%) rename .github/workflows/{ => tmp}/release-srtool.yml (100%) rename .github/workflows/{ => tmp}/review-bot.yml (100%) rename .github/workflows/{ => tmp}/review-trigger.yml (100%) rename .github/workflows/{ => tmp}/tests.yml (100%) diff --git a/.github/workflows/tests-linux-stable.yml b/.github/workflows/tests-linux-stable.yml index 55addf11de06..411c1be55267 100644 --- a/.github/workflows/tests-linux-stable.yml +++ b/.github/workflows/tests-linux-stable.yml @@ -71,3 +71,34 @@ jobs: uses: actions/checkout@v4 - name: script run: time forklift cargo nextest run --workspace --features runtime-benchmarks benchmark --locked --cargo-profile testnet + + test-linux-stable-oldkernel: + needs: [set-image, changes] + if: ${{ needs.changes.outputs.rust }} + runs-on: oldlinux + timeout-minutes: 30 + strategy: + fail-fast: false + matrix: + partition: [1/3, 2/3, 3/3] + container: + image: ${{ needs.set-image.outputs.IMAGE }} + env: + RUST_TOOLCHAIN: stable + # Enable debug assertions since we are running optimized builds for testing + # but still want to have debug assertions. + RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings" + steps: + - name: Checkout + uses: actions/checkout@v4 + - name: script + run: | + # Fixes "detected dubious ownership" error in the ci + git config --global --add safe.directory '*' + time forklift cargo nextest run \ + --workspace \ + --locked \ + --release \ + --no-fail-fast \ + --features try-runtime,experimental,riscv,ci-only-tests \ + --partition count:${{ matrix.partition }} diff --git a/.github/workflows/check-features.yml b/.github/workflows/tmp/check-features.yml similarity index 100% rename from .github/workflows/check-features.yml rename to .github/workflows/tmp/check-features.yml diff --git a/.github/workflows/check-labels.yml b/.github/workflows/tmp/check-labels.yml similarity index 100% rename from .github/workflows/check-labels.yml rename to .github/workflows/tmp/check-labels.yml diff --git a/.github/workflows/check-licenses.yml b/.github/workflows/tmp/check-licenses.yml similarity index 100% rename from .github/workflows/check-licenses.yml rename to .github/workflows/tmp/check-licenses.yml diff --git a/.github/workflows/check-links.yml b/.github/workflows/tmp/check-links.yml similarity index 100% rename from .github/workflows/check-links.yml rename to .github/workflows/tmp/check-links.yml diff --git a/.github/workflows/check-prdoc.yml b/.github/workflows/tmp/check-prdoc.yml similarity index 100% rename from .github/workflows/check-prdoc.yml rename to .github/workflows/tmp/check-prdoc.yml diff --git a/.github/workflows/check-runtime-migration.yml b/.github/workflows/tmp/check-runtime-migration.yml similarity index 100% rename from .github/workflows/check-runtime-migration.yml rename to .github/workflows/tmp/check-runtime-migration.yml diff --git a/.github/workflows/check-semver.yml b/.github/workflows/tmp/check-semver.yml similarity index 100% rename from .github/workflows/check-semver.yml rename to .github/workflows/tmp/check-semver.yml diff --git a/.github/workflows/checks-quick.yml b/.github/workflows/tmp/checks-quick.yml similarity index 100% rename from .github/workflows/checks-quick.yml rename to .github/workflows/tmp/checks-quick.yml diff --git a/.github/workflows/command-bench-all.yml b/.github/workflows/tmp/command-bench-all.yml similarity index 100% rename from .github/workflows/command-bench-all.yml rename to .github/workflows/tmp/command-bench-all.yml diff --git a/.github/workflows/command-bench-overhead.yml b/.github/workflows/tmp/command-bench-overhead.yml similarity index 100% rename from .github/workflows/command-bench-overhead.yml rename to .github/workflows/tmp/command-bench-overhead.yml diff --git a/.github/workflows/command-bench.yml b/.github/workflows/tmp/command-bench.yml similarity index 100% rename from .github/workflows/command-bench.yml rename to .github/workflows/tmp/command-bench.yml diff --git a/.github/workflows/command-fmt.yml b/.github/workflows/tmp/command-fmt.yml similarity index 100% rename from .github/workflows/command-fmt.yml rename to .github/workflows/tmp/command-fmt.yml diff --git a/.github/workflows/command-inform.yml b/.github/workflows/tmp/command-inform.yml similarity index 100% rename from .github/workflows/command-inform.yml rename to .github/workflows/tmp/command-inform.yml diff --git a/.github/workflows/command-update-ui.yml b/.github/workflows/tmp/command-update-ui.yml similarity index 100% rename from .github/workflows/command-update-ui.yml rename to .github/workflows/tmp/command-update-ui.yml diff --git a/.github/workflows/gitspiegel-trigger.yml b/.github/workflows/tmp/gitspiegel-trigger.yml similarity index 100% rename from .github/workflows/gitspiegel-trigger.yml rename to .github/workflows/tmp/gitspiegel-trigger.yml diff --git a/.github/workflows/issues-auto-add-parachain.yml b/.github/workflows/tmp/issues-auto-add-parachain.yml similarity index 100% rename from .github/workflows/issues-auto-add-parachain.yml rename to .github/workflows/tmp/issues-auto-add-parachain.yml diff --git a/.github/workflows/issues-auto-label.yml b/.github/workflows/tmp/issues-auto-label.yml similarity index 100% rename from .github/workflows/issues-auto-label.yml rename to .github/workflows/tmp/issues-auto-label.yml diff --git a/.github/workflows/misc-notify-burnin-label.yml b/.github/workflows/tmp/misc-notify-burnin-label.yml similarity index 100% rename from .github/workflows/misc-notify-burnin-label.yml rename to .github/workflows/tmp/misc-notify-burnin-label.yml diff --git a/.github/workflows/misc-review-bot-merge-queue.yml b/.github/workflows/tmp/misc-review-bot-merge-queue.yml similarity index 100% rename from .github/workflows/misc-review-bot-merge-queue.yml rename to .github/workflows/tmp/misc-review-bot-merge-queue.yml diff --git a/.github/workflows/misc-sync-templates.yml b/.github/workflows/tmp/misc-sync-templates.yml similarity index 100% rename from .github/workflows/misc-sync-templates.yml rename to .github/workflows/tmp/misc-sync-templates.yml diff --git a/.github/workflows/publish-check-crates.yml b/.github/workflows/tmp/publish-check-crates.yml similarity index 100% rename from .github/workflows/publish-check-crates.yml rename to .github/workflows/tmp/publish-check-crates.yml diff --git a/.github/workflows/publish-claim-crates.yml b/.github/workflows/tmp/publish-claim-crates.yml similarity index 100% rename from .github/workflows/publish-claim-crates.yml rename to .github/workflows/tmp/publish-claim-crates.yml diff --git a/.github/workflows/publish-subsystem-benchmarks.yml b/.github/workflows/tmp/publish-subsystem-benchmarks.yml similarity index 100% rename from .github/workflows/publish-subsystem-benchmarks.yml rename to .github/workflows/tmp/publish-subsystem-benchmarks.yml diff --git a/.github/workflows/release-10_rc-automation.yml b/.github/workflows/tmp/release-10_rc-automation.yml similarity index 100% rename from .github/workflows/release-10_rc-automation.yml rename to .github/workflows/tmp/release-10_rc-automation.yml diff --git a/.github/workflows/release-30_publish_release_draft.yml b/.github/workflows/tmp/release-30_publish_release_draft.yml similarity index 100% rename from .github/workflows/release-30_publish_release_draft.yml rename to .github/workflows/tmp/release-30_publish_release_draft.yml diff --git a/.github/workflows/release-50_publish-docker.yml b/.github/workflows/tmp/release-50_publish-docker.yml similarity index 100% rename from .github/workflows/release-50_publish-docker.yml rename to .github/workflows/tmp/release-50_publish-docker.yml diff --git a/.github/workflows/release-99_notif-published.yml b/.github/workflows/tmp/release-99_notif-published.yml similarity index 100% rename from .github/workflows/release-99_notif-published.yml rename to .github/workflows/tmp/release-99_notif-published.yml diff --git a/.github/workflows/release-check-runtimes.yml b/.github/workflows/tmp/release-check-runtimes.yml similarity index 100% rename from .github/workflows/release-check-runtimes.yml rename to .github/workflows/tmp/release-check-runtimes.yml diff --git a/.github/workflows/release-clobber-stable.yml b/.github/workflows/tmp/release-clobber-stable.yml similarity index 100% rename from .github/workflows/release-clobber-stable.yml rename to .github/workflows/tmp/release-clobber-stable.yml diff --git a/.github/workflows/release-srtool.yml b/.github/workflows/tmp/release-srtool.yml similarity index 100% rename from .github/workflows/release-srtool.yml rename to .github/workflows/tmp/release-srtool.yml diff --git a/.github/workflows/review-bot.yml b/.github/workflows/tmp/review-bot.yml similarity index 100% rename from .github/workflows/review-bot.yml rename to .github/workflows/tmp/review-bot.yml diff --git a/.github/workflows/review-trigger.yml b/.github/workflows/tmp/review-trigger.yml similarity index 100% rename from .github/workflows/review-trigger.yml rename to .github/workflows/tmp/review-trigger.yml diff --git a/.github/workflows/tests.yml b/.github/workflows/tmp/tests.yml similarity index 100% rename from .github/workflows/tests.yml rename to .github/workflows/tmp/tests.yml From db8327731fca591a3ad66023741561b1654a25a3 Mon Sep 17 00:00:00 2001 From: alvicsam Date: Thu, 27 Jun 2024 12:10:29 +0200 Subject: [PATCH 02/52] run only on one partition --- .github/workflows/tests-linux-stable.yml | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/.github/workflows/tests-linux-stable.yml b/.github/workflows/tests-linux-stable.yml index 411c1be55267..809b5e88ce7c 100644 --- a/.github/workflows/tests-linux-stable.yml +++ b/.github/workflows/tests-linux-stable.yml @@ -77,10 +77,10 @@ jobs: if: ${{ needs.changes.outputs.rust }} runs-on: oldlinux timeout-minutes: 30 - strategy: - fail-fast: false - matrix: - partition: [1/3, 2/3, 3/3] + # strategy: + # fail-fast: false + # matrix: + # partition: [1/3, 2/3, 3/3] container: image: ${{ needs.set-image.outputs.IMAGE }} env: @@ -101,4 +101,5 @@ jobs: --release \ --no-fail-fast \ --features try-runtime,experimental,riscv,ci-only-tests \ - --partition count:${{ matrix.partition }} + --partition count:1/3 + # --partition count:${{ matrix.partition }} From 533c396e7f0a36590938f80c190029f9242a0f18 Mon Sep 17 00:00:00 2001 From: alvicsam Date: Thu, 27 Jun 2024 15:28:32 +0200 Subject: [PATCH 03/52] run all tests --- .github/workflows/tests-linux-stable.yml | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/.github/workflows/tests-linux-stable.yml b/.github/workflows/tests-linux-stable.yml index 809b5e88ce7c..411c1be55267 100644 --- a/.github/workflows/tests-linux-stable.yml +++ b/.github/workflows/tests-linux-stable.yml @@ -77,10 +77,10 @@ jobs: if: ${{ needs.changes.outputs.rust }} runs-on: oldlinux timeout-minutes: 30 - # strategy: - # fail-fast: false - # matrix: - # partition: [1/3, 2/3, 3/3] + strategy: + fail-fast: false + matrix: + partition: [1/3, 2/3, 3/3] container: image: ${{ needs.set-image.outputs.IMAGE }} env: @@ -101,5 +101,4 @@ jobs: --release \ --no-fail-fast \ --features try-runtime,experimental,riscv,ci-only-tests \ - --partition count:1/3 - # --partition count:${{ matrix.partition }} + --partition count:${{ matrix.partition }} From 6b75c7c52723450c5396762b59d7fd2e8c31ecd5 Mon Sep 17 00:00:00 2001 From: alvicsam Date: Thu, 27 Jun 2024 15:58:01 +0200 Subject: [PATCH 04/52] fix merge conflict --- .github/workflows/check-semver.yml | 58 ++++++++++++++++++++++++++++++ 1 file changed, 58 insertions(+) create mode 100644 .github/workflows/check-semver.yml diff --git a/.github/workflows/check-semver.yml b/.github/workflows/check-semver.yml new file mode 100644 index 000000000000..47f9e5061b4a --- /dev/null +++ b/.github/workflows/check-semver.yml @@ -0,0 +1,58 @@ +name: Check semver + +on: + pull_request: + types: [opened, synchronize, reopened, ready_for_review] + paths: + - prdoc/*.prdoc +env: + TOOLCHAIN: nightly-2024-03-01 + +jobs: + check-semver: + runs-on: ubuntu-latest + container: + image: docker.io/paritytech/ci-unified:bullseye-1.77.0-2024-04-10-v20240408 + steps: + - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 + + - name: Rust Cache + uses: Swatinem/rust-cache@23bce251a8cd2ffc3c1075eaa2367cf899916d84 # v2.7.3 + with: + cache-on-failure: true + + - name: install parity-publish + run: cargo install parity-publish@0.6.0 + + - name: Rust compilation prerequisites + run: | + rustup default $TOOLCHAIN + rustup target add wasm32-unknown-unknown --toolchain $TOOLCHAIN + rustup component add rust-src --toolchain $TOOLCHAIN + + - name: extra git setup + run: | + git config --global --add safe.directory '*' + git fetch --no-tags --no-recurse-submodules --depth=1 origin master + git branch old origin/master + + - name: check semver + run: | + export CARGO_TARGET_DIR=target + export RUSTFLAGS='-A warnings -A missing_docs' + export SKIP_WASM_BUILD=1 + if ! parity-publish --color always prdoc --since old --validate prdoc/pr_$PR.prdoc -v --toolchain $TOOLCHAIN; then + cat < Date: Thu, 27 Jun 2024 17:00:43 +0200 Subject: [PATCH 05/52] add opt --- .github/workflows/tests-linux-stable.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/tests-linux-stable.yml b/.github/workflows/tests-linux-stable.yml index 411c1be55267..c22ab4f43ec5 100644 --- a/.github/workflows/tests-linux-stable.yml +++ b/.github/workflows/tests-linux-stable.yml @@ -83,6 +83,7 @@ jobs: partition: [1/3, 2/3, 3/3] container: image: ${{ needs.set-image.outputs.IMAGE }} + options: --privileged env: RUST_TOOLCHAIN: stable # Enable debug assertions since we are running optimized builds for testing From e4f5b5ab88764cef1865c1ab487bb489dab04af1 Mon Sep 17 00:00:00 2001 From: alvicsam Date: Mon, 1 Jul 2024 11:09:54 +0200 Subject: [PATCH 06/52] disable forklift, add test-linux-stable --- .github/workflows/tests-linux-stable.yml | 44 ++++++++++++++++++++++-- 1 file changed, 42 insertions(+), 2 deletions(-) diff --git a/.github/workflows/tests-linux-stable.yml b/.github/workflows/tests-linux-stable.yml index c22ab4f43ec5..7925fd4bc25a 100644 --- a/.github/workflows/tests-linux-stable.yml +++ b/.github/workflows/tests-linux-stable.yml @@ -72,17 +72,19 @@ jobs: - name: script run: time forklift cargo nextest run --workspace --features runtime-benchmarks benchmark --locked --cargo-profile testnet + #todo: enable forklift test-linux-stable-oldkernel: needs: [set-image, changes] if: ${{ needs.changes.outputs.rust }} runs-on: oldlinux - timeout-minutes: 30 + timeout-minutes: 60 strategy: fail-fast: false matrix: partition: [1/3, 2/3, 3/3] container: image: ${{ needs.set-image.outputs.IMAGE }} + # needed for tests that use unshare syscall options: --privileged env: RUST_TOOLCHAIN: stable @@ -96,10 +98,48 @@ jobs: run: | # Fixes "detected dubious ownership" error in the ci git config --global --add safe.directory '*' - time forklift cargo nextest run \ + time cargo nextest run \ + --workspace \ + --locked \ + --release \ + --no-fail-fast \ + --features try-runtime,experimental,riscv,ci-only-tests \ + --partition count:${{ matrix.partition }} + # run runtime-api tests with `enable-staging-api` feature on the 1st node + if [ ${{ matrix.partition }} == "1/3" ]; then time cargo nextest run -p sp-api-test --features enable-staging-api; fi + + #todo: enable forklift + test-linux-stable: + needs: [set-image, changes] + if: ${{ needs.changes.outputs.rust }} + runs-on: arc-runners-polkadot-sdk-beefy + timeout-minutes: 60 + strategy: + fail-fast: false + matrix: + partition: [1/3, 2/3, 3/3] + container: + image: ${{ needs.set-image.outputs.IMAGE }} + # needed for tests that use unshare syscall + # options: --privileged + env: + RUST_TOOLCHAIN: stable + # Enable debug assertions since we are running optimized builds for testing + # but still want to have debug assertions. + RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings" + steps: + - name: Checkout + uses: actions/checkout@v4 + - name: script + run: | + # Fixes "detected dubious ownership" error in the ci + git config --global --add safe.directory '*' + time cargo nextest run \ --workspace \ --locked \ --release \ --no-fail-fast \ --features try-runtime,experimental,riscv,ci-only-tests \ --partition count:${{ matrix.partition }} + # run runtime-api tests with `enable-staging-api` feature on the 1st node + if [ ${{ matrix.partition }} == "1/3" ]; then time cargo nextest run -p sp-api-test --features enable-staging-api; fi From c86804b62e94864c73f2eec7a304ad5107decf46 Mon Sep 17 00:00:00 2001 From: alvicsam Date: Mon, 1 Jul 2024 11:55:23 +0200 Subject: [PATCH 07/52] compare jobs with and without forklift --- .github/workflows/tests-linux-stable.yml | 76 +++++++++++++++++++++++- 1 file changed, 73 insertions(+), 3 deletions(-) diff --git a/.github/workflows/tests-linux-stable.yml b/.github/workflows/tests-linux-stable.yml index 7925fd4bc25a..6bf9bf4e9500 100644 --- a/.github/workflows/tests-linux-stable.yml +++ b/.github/workflows/tests-linux-stable.yml @@ -106,7 +106,7 @@ jobs: --features try-runtime,experimental,riscv,ci-only-tests \ --partition count:${{ matrix.partition }} # run runtime-api tests with `enable-staging-api` feature on the 1st node - if [ ${{ matrix.partition }} == "1/3" ]; then time cargo nextest run -p sp-api-test --features enable-staging-api; fi + if [ "${{ matrix.partition }}" == "1/3" ]; then time cargo nextest run -p sp-api-test --features enable-staging-api; fi #todo: enable forklift test-linux-stable: @@ -121,7 +121,7 @@ jobs: container: image: ${{ needs.set-image.outputs.IMAGE }} # needed for tests that use unshare syscall - # options: --privileged + options: --privileged env: RUST_TOOLCHAIN: stable # Enable debug assertions since we are running optimized builds for testing @@ -142,4 +142,74 @@ jobs: --features try-runtime,experimental,riscv,ci-only-tests \ --partition count:${{ matrix.partition }} # run runtime-api tests with `enable-staging-api` feature on the 1st node - if [ ${{ matrix.partition }} == "1/3" ]; then time cargo nextest run -p sp-api-test --features enable-staging-api; fi + if [ "${{ matrix.partition }}" == "1/3" ]; then time cargo nextest run -p sp-api-test --features enable-staging-api; fi + + test-linux-stable-oldkernel-fl: + needs: [set-image, changes] + if: ${{ needs.changes.outputs.rust }} + runs-on: oldlinux + timeout-minutes: 60 + strategy: + fail-fast: false + matrix: + partition: [1/3, 2/3, 3/3] + container: + image: ${{ needs.set-image.outputs.IMAGE }} + # needed for tests that use unshare syscall + options: --privileged + env: + RUST_TOOLCHAIN: stable + # Enable debug assertions since we are running optimized builds for testing + # but still want to have debug assertions. + RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings" + steps: + - name: Checkout + uses: actions/checkout@v4 + - name: script + run: | + # Fixes "detected dubious ownership" error in the ci + git config --global --add safe.directory '*' + time forklift cargo nextest run \ + --workspace \ + --locked \ + --release \ + --no-fail-fast \ + --features try-runtime,experimental,riscv,ci-only-tests \ + --partition count:${{ matrix.partition }} + # run runtime-api tests with `enable-staging-api` feature on the 1st node + if [ "${{ matrix.partition }}" == "1/3" ]; then time forklift cargo nextest run -p sp-api-test --features enable-staging-api; fi + + test-linux-stable-fl: + needs: [set-image, changes] + if: ${{ needs.changes.outputs.rust }} + runs-on: arc-runners-polkadot-sdk-beefy + timeout-minutes: 60 + strategy: + fail-fast: false + matrix: + partition: [1/3, 2/3, 3/3] + container: + image: ${{ needs.set-image.outputs.IMAGE }} + # needed for tests that use unshare syscall + options: --privileged + env: + RUST_TOOLCHAIN: stable + # Enable debug assertions since we are running optimized builds for testing + # but still want to have debug assertions. + RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings" + steps: + - name: Checkout + uses: actions/checkout@v4 + - name: script + run: | + # Fixes "detected dubious ownership" error in the ci + git config --global --add safe.directory '*' + time forklift cargo nextest run \ + --workspace \ + --locked \ + --release \ + --no-fail-fast \ + --features try-runtime,experimental,riscv,ci-only-tests \ + --partition count:${{ matrix.partition }} + # run runtime-api tests with `enable-staging-api` feature on the 1st node + if [ "${{ matrix.partition }}" == "1/3" ]; then time forklift cargo nextest run -p sp-api-test --features enable-staging-api; fi From 98afd5afe97b27df80d3ab2a0373b355e4d3b7be Mon Sep 17 00:00:00 2001 From: alvicsam Date: Mon, 1 Jul 2024 12:24:43 +0200 Subject: [PATCH 08/52] disable privileged for k8s runners --- .github/workflows/tests-linux-stable.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/tests-linux-stable.yml b/.github/workflows/tests-linux-stable.yml index 6bf9bf4e9500..5d338ff5e5a2 100644 --- a/.github/workflows/tests-linux-stable.yml +++ b/.github/workflows/tests-linux-stable.yml @@ -121,7 +121,7 @@ jobs: container: image: ${{ needs.set-image.outputs.IMAGE }} # needed for tests that use unshare syscall - options: --privileged + # options: --privileged env: RUST_TOOLCHAIN: stable # Enable debug assertions since we are running optimized builds for testing @@ -191,7 +191,7 @@ jobs: container: image: ${{ needs.set-image.outputs.IMAGE }} # needed for tests that use unshare syscall - options: --privileged + # options: --privileged env: RUST_TOOLCHAIN: stable # Enable debug assertions since we are running optimized builds for testing From 59a615ffe075b255061b8e1be73e2e49f0dc28c5 Mon Sep 17 00:00:00 2001 From: alvicsam Date: Mon, 1 Jul 2024 13:34:25 +0200 Subject: [PATCH 09/52] try seccomp --- .github/workflows/tests-linux-stable.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/tests-linux-stable.yml b/.github/workflows/tests-linux-stable.yml index 5d338ff5e5a2..b7be057c62f8 100644 --- a/.github/workflows/tests-linux-stable.yml +++ b/.github/workflows/tests-linux-stable.yml @@ -85,7 +85,7 @@ jobs: container: image: ${{ needs.set-image.outputs.IMAGE }} # needed for tests that use unshare syscall - options: --privileged + options: --security-opt seccomp=unconfined env: RUST_TOOLCHAIN: stable # Enable debug assertions since we are running optimized builds for testing @@ -121,7 +121,7 @@ jobs: container: image: ${{ needs.set-image.outputs.IMAGE }} # needed for tests that use unshare syscall - # options: --privileged + options: --security-opt seccomp=unconfined env: RUST_TOOLCHAIN: stable # Enable debug assertions since we are running optimized builds for testing @@ -156,7 +156,7 @@ jobs: container: image: ${{ needs.set-image.outputs.IMAGE }} # needed for tests that use unshare syscall - options: --privileged + options: --security-opt seccomp=unconfined env: RUST_TOOLCHAIN: stable # Enable debug assertions since we are running optimized builds for testing @@ -191,7 +191,7 @@ jobs: container: image: ${{ needs.set-image.outputs.IMAGE }} # needed for tests that use unshare syscall - # options: --privileged + options: --security-opt seccomp=unconfined env: RUST_TOOLCHAIN: stable # Enable debug assertions since we are running optimized builds for testing From 88ff0cf06449e32409cc47e294cd5d67eb6b7b32 Mon Sep 17 00:00:00 2001 From: alvicsam Date: Mon, 1 Jul 2024 17:39:08 +0200 Subject: [PATCH 10/52] try ubuntu runners --- .github/workflows/tests-linux-stable.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tests-linux-stable.yml b/.github/workflows/tests-linux-stable.yml index b7be057c62f8..90e2d3fcaf9b 100644 --- a/.github/workflows/tests-linux-stable.yml +++ b/.github/workflows/tests-linux-stable.yml @@ -112,7 +112,7 @@ jobs: test-linux-stable: needs: [set-image, changes] if: ${{ needs.changes.outputs.rust }} - runs-on: arc-runners-polkadot-sdk-beefy + runs-on: arc-runners-polkadot-sdk-beefy-ubuntu timeout-minutes: 60 strategy: fail-fast: false From cb03bf1731699fd0379dab7e47b5591d0676e121 Mon Sep 17 00:00:00 2001 From: alvicsam Date: Mon, 1 Jul 2024 19:46:43 +0200 Subject: [PATCH 11/52] upd prdoc --- .github/workflows/{tmp => }/check-prdoc.yml | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename .github/workflows/{tmp => }/check-prdoc.yml (100%) diff --git a/.github/workflows/tmp/check-prdoc.yml b/.github/workflows/check-prdoc.yml similarity index 100% rename from .github/workflows/tmp/check-prdoc.yml rename to .github/workflows/check-prdoc.yml From cef34c653e7e242cec3dd4c78b28430f08b05bc8 Mon Sep 17 00:00:00 2001 From: alvicsam Date: Tue, 2 Jul 2024 10:15:47 +0200 Subject: [PATCH 12/52] run fl on ubuntu runners --- .github/workflows/tests-linux-stable.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tests-linux-stable.yml b/.github/workflows/tests-linux-stable.yml index 90e2d3fcaf9b..ecfa5fd5ea0d 100644 --- a/.github/workflows/tests-linux-stable.yml +++ b/.github/workflows/tests-linux-stable.yml @@ -182,7 +182,7 @@ jobs: test-linux-stable-fl: needs: [set-image, changes] if: ${{ needs.changes.outputs.rust }} - runs-on: arc-runners-polkadot-sdk-beefy + runs-on: arc-runners-polkadot-sdk-beefy-ubuntu timeout-minutes: 60 strategy: fail-fast: false From a53a62b373ab11cd989efd75a97bc72d7e47358d Mon Sep 17 00:00:00 2001 From: alvicsam Date: Tue, 2 Jul 2024 14:37:34 +0200 Subject: [PATCH 13/52] run only all_security_features_work --- .github/workflows/tests-linux-stable.yml | 265 ++++++++++++----------- 1 file changed, 141 insertions(+), 124 deletions(-) diff --git a/.github/workflows/tests-linux-stable.yml b/.github/workflows/tests-linux-stable.yml index ecfa5fd5ea0d..7aa2405216cb 100644 --- a/.github/workflows/tests-linux-stable.yml +++ b/.github/workflows/tests-linux-stable.yml @@ -72,144 +72,161 @@ jobs: - name: script run: time forklift cargo nextest run --workspace --features runtime-benchmarks benchmark --locked --cargo-profile testnet - #todo: enable forklift - test-linux-stable-oldkernel: - needs: [set-image, changes] - if: ${{ needs.changes.outputs.rust }} - runs-on: oldlinux - timeout-minutes: 60 - strategy: - fail-fast: false - matrix: - partition: [1/3, 2/3, 3/3] - container: - image: ${{ needs.set-image.outputs.IMAGE }} - # needed for tests that use unshare syscall - options: --security-opt seccomp=unconfined - env: - RUST_TOOLCHAIN: stable - # Enable debug assertions since we are running optimized builds for testing - # but still want to have debug assertions. - RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings" - steps: - - name: Checkout - uses: actions/checkout@v4 - - name: script - run: | - # Fixes "detected dubious ownership" error in the ci - git config --global --add safe.directory '*' - time cargo nextest run \ - --workspace \ - --locked \ - --release \ - --no-fail-fast \ - --features try-runtime,experimental,riscv,ci-only-tests \ - --partition count:${{ matrix.partition }} - # run runtime-api tests with `enable-staging-api` feature on the 1st node - if [ "${{ matrix.partition }}" == "1/3" ]; then time cargo nextest run -p sp-api-test --features enable-staging-api; fi + # #todo: enable forklift + # test-linux-stable-oldkernel: + # needs: [set-image, changes] + # if: ${{ needs.changes.outputs.rust }} + # runs-on: oldlinux + # timeout-minutes: 60 + # strategy: + # fail-fast: false + # matrix: + # partition: [1/3, 2/3, 3/3] + # container: + # image: ${{ needs.set-image.outputs.IMAGE }} + # # needed for tests that use unshare syscall + # options: --security-opt seccomp=unconfined + # env: + # RUST_TOOLCHAIN: stable + # # Enable debug assertions since we are running optimized builds for testing + # # but still want to have debug assertions. + # RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings" + # steps: + # - name: Checkout + # uses: actions/checkout@v4 + # - name: script + # run: | + # # Fixes "detected dubious ownership" error in the ci + # git config --global --add safe.directory '*' + # time cargo nextest run \ + # --workspace \ + # --locked \ + # --release \ + # --no-fail-fast \ + # --features try-runtime,experimental,riscv,ci-only-tests \ + # --partition count:${{ matrix.partition }} + # # run runtime-api tests with `enable-staging-api` feature on the 1st node + # if [ "${{ matrix.partition }}" == "1/3" ]; then time cargo nextest run -p sp-api-test --features enable-staging-api; fi - #todo: enable forklift - test-linux-stable: - needs: [set-image, changes] - if: ${{ needs.changes.outputs.rust }} - runs-on: arc-runners-polkadot-sdk-beefy-ubuntu - timeout-minutes: 60 - strategy: - fail-fast: false - matrix: - partition: [1/3, 2/3, 3/3] - container: - image: ${{ needs.set-image.outputs.IMAGE }} - # needed for tests that use unshare syscall - options: --security-opt seccomp=unconfined - env: - RUST_TOOLCHAIN: stable - # Enable debug assertions since we are running optimized builds for testing - # but still want to have debug assertions. - RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings" - steps: - - name: Checkout - uses: actions/checkout@v4 - - name: script - run: | - # Fixes "detected dubious ownership" error in the ci - git config --global --add safe.directory '*' - time cargo nextest run \ - --workspace \ - --locked \ - --release \ - --no-fail-fast \ - --features try-runtime,experimental,riscv,ci-only-tests \ - --partition count:${{ matrix.partition }} - # run runtime-api tests with `enable-staging-api` feature on the 1st node - if [ "${{ matrix.partition }}" == "1/3" ]; then time cargo nextest run -p sp-api-test --features enable-staging-api; fi + # #todo: enable forklift + # test-linux-stable: + # needs: [set-image, changes] + # if: ${{ needs.changes.outputs.rust }} + # runs-on: arc-runners-polkadot-sdk-beefy-ubuntu + # timeout-minutes: 60 + # strategy: + # fail-fast: false + # matrix: + # partition: [1/3, 2/3, 3/3] + # container: + # image: ${{ needs.set-image.outputs.IMAGE }} + # # needed for tests that use unshare syscall + # options: --security-opt seccomp=unconfined + # env: + # RUST_TOOLCHAIN: stable + # # Enable debug assertions since we are running optimized builds for testing + # # but still want to have debug assertions. + # RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings" + # steps: + # - name: Checkout + # uses: actions/checkout@v4 + # - name: script + # run: | + # # Fixes "detected dubious ownership" error in the ci + # git config --global --add safe.directory '*' + # time cargo nextest run \ + # --workspace \ + # --locked \ + # --release \ + # --no-fail-fast \ + # --features try-runtime,experimental,riscv,ci-only-tests \ + # --partition count:${{ matrix.partition }} + # # run runtime-api tests with `enable-staging-api` feature on the 1st node + # if [ "${{ matrix.partition }}" == "1/3" ]; then time cargo nextest run -p sp-api-test --features enable-staging-api; fi - test-linux-stable-oldkernel-fl: - needs: [set-image, changes] - if: ${{ needs.changes.outputs.rust }} - runs-on: oldlinux - timeout-minutes: 60 - strategy: - fail-fast: false - matrix: - partition: [1/3, 2/3, 3/3] - container: - image: ${{ needs.set-image.outputs.IMAGE }} - # needed for tests that use unshare syscall - options: --security-opt seccomp=unconfined - env: - RUST_TOOLCHAIN: stable - # Enable debug assertions since we are running optimized builds for testing - # but still want to have debug assertions. - RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings" - steps: - - name: Checkout - uses: actions/checkout@v4 - - name: script - run: | - # Fixes "detected dubious ownership" error in the ci - git config --global --add safe.directory '*' - time forklift cargo nextest run \ - --workspace \ - --locked \ - --release \ - --no-fail-fast \ - --features try-runtime,experimental,riscv,ci-only-tests \ - --partition count:${{ matrix.partition }} - # run runtime-api tests with `enable-staging-api` feature on the 1st node - if [ "${{ matrix.partition }}" == "1/3" ]; then time forklift cargo nextest run -p sp-api-test --features enable-staging-api; fi + # test-linux-stable-oldkernel-fl: + # needs: [set-image, changes] + # if: ${{ needs.changes.outputs.rust }} + # runs-on: oldlinux + # timeout-minutes: 60 + # strategy: + # fail-fast: false + # matrix: + # partition: [1/3, 2/3, 3/3] + # container: + # image: ${{ needs.set-image.outputs.IMAGE }} + # # needed for tests that use unshare syscall + # options: --security-opt seccomp=unconfined + # env: + # RUST_TOOLCHAIN: stable + # # Enable debug assertions since we are running optimized builds for testing + # # but still want to have debug assertions. + # RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings" + # steps: + # - name: Checkout + # uses: actions/checkout@v4 + # - name: script + # run: | + # # Fixes "detected dubious ownership" error in the ci + # git config --global --add safe.directory '*' + # time forklift cargo nextest run \ + # --workspace \ + # --locked \ + # --release \ + # --no-fail-fast \ + # --features try-runtime,experimental,riscv,ci-only-tests \ + # --partition count:${{ matrix.partition }} + # # run runtime-api tests with `enable-staging-api` feature on the 1st node + # if [ "${{ matrix.partition }}" == "1/3" ]; then time forklift cargo nextest run -p sp-api-test --features enable-staging-api; fi - test-linux-stable-fl: + # test-linux-stable-fl: + # needs: [set-image, changes] + # if: ${{ needs.changes.outputs.rust }} + # runs-on: arc-runners-polkadot-sdk-beefy-ubuntu + # timeout-minutes: 60 + # strategy: + # fail-fast: false + # matrix: + # partition: [1/3, 2/3, 3/3] + # container: + # image: ${{ needs.set-image.outputs.IMAGE }} + # # needed for tests that use unshare syscall + # options: --security-opt seccomp=unconfined + # env: + # RUST_TOOLCHAIN: stable + # # Enable debug assertions since we are running optimized builds for testing + # # but still want to have debug assertions. + # RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings" + # steps: + # - name: Checkout + # uses: actions/checkout@v4 + # - name: script + # run: | + # # Fixes "detected dubious ownership" error in the ci + # git config --global --add safe.directory '*' + # time forklift cargo nextest run \ + # --workspace \ + # --locked \ + # --release \ + # --no-fail-fast \ + # --features try-runtime,experimental,riscv,ci-only-tests \ + # --partition count:${{ matrix.partition }} + # # run runtime-api tests with `enable-staging-api` feature on the 1st node + # if [ "${{ matrix.partition }}" == "1/3" ]; then time forklift cargo nextest run -p sp-api-test --features enable-staging-api; fi + + test-landlock: needs: [set-image, changes] if: ${{ needs.changes.outputs.rust }} runs-on: arc-runners-polkadot-sdk-beefy-ubuntu timeout-minutes: 60 - strategy: - fail-fast: false - matrix: - partition: [1/3, 2/3, 3/3] container: image: ${{ needs.set-image.outputs.IMAGE }} - # needed for tests that use unshare syscall - options: --security-opt seccomp=unconfined env: RUST_TOOLCHAIN: stable - # Enable debug assertions since we are running optimized builds for testing - # but still want to have debug assertions. RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings" steps: - name: Checkout uses: actions/checkout@v4 - name: script run: | - # Fixes "detected dubious ownership" error in the ci - git config --global --add safe.directory '*' - time forklift cargo nextest run \ - --workspace \ - --locked \ - --release \ - --no-fail-fast \ - --features try-runtime,experimental,riscv,ci-only-tests \ - --partition count:${{ matrix.partition }} - # run runtime-api tests with `enable-staging-api` feature on the 1st node - if [ "${{ matrix.partition }}" == "1/3" ]; then time forklift cargo nextest run -p sp-api-test --features enable-staging-api; fi + SKIP_WASM_BUILD=1 time cargo nextest run -p polkadot-node-core-pvf all_security_features_work From 779fe65794dfe8edf0ff17f9f4831bda49291aa0 Mon Sep 17 00:00:00 2001 From: alvicsam Date: Tue, 2 Jul 2024 14:50:28 +0200 Subject: [PATCH 14/52] run all tests --- .github/workflows/tests-linux-stable.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tests-linux-stable.yml b/.github/workflows/tests-linux-stable.yml index 7aa2405216cb..095b8d7abfe4 100644 --- a/.github/workflows/tests-linux-stable.yml +++ b/.github/workflows/tests-linux-stable.yml @@ -229,4 +229,4 @@ jobs: uses: actions/checkout@v4 - name: script run: | - SKIP_WASM_BUILD=1 time cargo nextest run -p polkadot-node-core-pvf all_security_features_work + SKIP_WASM_BUILD=1 time cargo nextest run -p polkadot-node-core-pvf From 373b03c1875bd18db112bc21342f8630c518a4b5 Mon Sep 17 00:00:00 2001 From: alvicsam Date: Tue, 2 Jul 2024 14:54:03 +0200 Subject: [PATCH 15/52] test feature --- .github/workflows/tests-linux-stable.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tests-linux-stable.yml b/.github/workflows/tests-linux-stable.yml index 095b8d7abfe4..65efb5c00175 100644 --- a/.github/workflows/tests-linux-stable.yml +++ b/.github/workflows/tests-linux-stable.yml @@ -229,4 +229,4 @@ jobs: uses: actions/checkout@v4 - name: script run: | - SKIP_WASM_BUILD=1 time cargo nextest run -p polkadot-node-core-pvf + SKIP_WASM_BUILD=1 time cargo nextest run -p polkadot-node-core-pvf --features ci-only-tests all_security_features_work From dfdf9cbb67146969293eb365880cece84fc863fe Mon Sep 17 00:00:00 2001 From: alvicsam Date: Wed, 3 Jul 2024 09:46:13 +0200 Subject: [PATCH 16/52] test landlock --- .github/workflows/tests-linux-stable.yml | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/workflows/tests-linux-stable.yml b/.github/workflows/tests-linux-stable.yml index 65efb5c00175..da26f5a0ba89 100644 --- a/.github/workflows/tests-linux-stable.yml +++ b/.github/workflows/tests-linux-stable.yml @@ -204,13 +204,13 @@ jobs: # run: | # # Fixes "detected dubious ownership" error in the ci # git config --global --add safe.directory '*' - # time forklift cargo nextest run \ - # --workspace \ - # --locked \ - # --release \ - # --no-fail-fast \ - # --features try-runtime,experimental,riscv,ci-only-tests \ - # --partition count:${{ matrix.partition }} + # time forklift cargo nextest run \ + # --workspace \ + # --locked \ + # --release \ + # --no-fail-fast \ + # --features try-runtime,experimental,riscv,ci-only-tests \ + # --partition count:${{ matrix.partition }} # # run runtime-api tests with `enable-staging-api` feature on the 1st node # if [ "${{ matrix.partition }}" == "1/3" ]; then time forklift cargo nextest run -p sp-api-test --features enable-staging-api; fi @@ -229,4 +229,4 @@ jobs: uses: actions/checkout@v4 - name: script run: | - SKIP_WASM_BUILD=1 time cargo nextest run -p polkadot-node-core-pvf --features ci-only-tests all_security_features_work + time cargo test -p polkadot-node-core-pvf all_security_features_work --features=ci-only-tests From 6f6c07c3785bbec5c41aa60f0839aff7afb30af9 Mon Sep 17 00:00:00 2001 From: alvicsam Date: Wed, 3 Jul 2024 10:03:26 +0200 Subject: [PATCH 17/52] add seccomp --- .github/workflows/tests-linux-stable.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/tests-linux-stable.yml b/.github/workflows/tests-linux-stable.yml index da26f5a0ba89..91c3ae6b2601 100644 --- a/.github/workflows/tests-linux-stable.yml +++ b/.github/workflows/tests-linux-stable.yml @@ -221,6 +221,7 @@ jobs: timeout-minutes: 60 container: image: ${{ needs.set-image.outputs.IMAGE }} + options: --security-opt seccomp=unconfined env: RUST_TOOLCHAIN: stable RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings" @@ -229,4 +230,4 @@ jobs: uses: actions/checkout@v4 - name: script run: | - time cargo test -p polkadot-node-core-pvf all_security_features_work --features=ci-only-tests + SKIP_WASM_BUILD="1" cargo test -p polkadot-node-core-pvf all_security_features_work --features=ci-only-tests From 940576d4f671e45fa8d6569c99f463c27b04accb Mon Sep 17 00:00:00 2001 From: alvicsam Date: Wed, 3 Jul 2024 10:16:16 +0200 Subject: [PATCH 18/52] try gh runner --- .github/workflows/tests-linux-stable.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/tests-linux-stable.yml b/.github/workflows/tests-linux-stable.yml index 91c3ae6b2601..45ec1c65b705 100644 --- a/.github/workflows/tests-linux-stable.yml +++ b/.github/workflows/tests-linux-stable.yml @@ -217,7 +217,8 @@ jobs: test-landlock: needs: [set-image, changes] if: ${{ needs.changes.outputs.rust }} - runs-on: arc-runners-polkadot-sdk-beefy-ubuntu + # runs-on: arc-runners-polkadot-sdk-beefy-ubuntu + runs-on: ubuntu-latest timeout-minutes: 60 container: image: ${{ needs.set-image.outputs.IMAGE }} From 97efeeb0bfd4e501463149f770d8e548f34eba43 Mon Sep 17 00:00:00 2001 From: alvicsam Date: Fri, 5 Jul 2024 14:53:41 +0200 Subject: [PATCH 19/52] run tests --- .github/workflows/tests-linux-stable.yml | 276 +++++++++++------------ 1 file changed, 138 insertions(+), 138 deletions(-) diff --git a/.github/workflows/tests-linux-stable.yml b/.github/workflows/tests-linux-stable.yml index 45ec1c65b705..f7904d7be990 100644 --- a/.github/workflows/tests-linux-stable.yml +++ b/.github/workflows/tests-linux-stable.yml @@ -72,147 +72,147 @@ jobs: - name: script run: time forklift cargo nextest run --workspace --features runtime-benchmarks benchmark --locked --cargo-profile testnet - # #todo: enable forklift - # test-linux-stable-oldkernel: - # needs: [set-image, changes] - # if: ${{ needs.changes.outputs.rust }} - # runs-on: oldlinux - # timeout-minutes: 60 - # strategy: - # fail-fast: false - # matrix: - # partition: [1/3, 2/3, 3/3] - # container: - # image: ${{ needs.set-image.outputs.IMAGE }} - # # needed for tests that use unshare syscall - # options: --security-opt seccomp=unconfined - # env: - # RUST_TOOLCHAIN: stable - # # Enable debug assertions since we are running optimized builds for testing - # # but still want to have debug assertions. - # RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings" - # steps: - # - name: Checkout - # uses: actions/checkout@v4 - # - name: script - # run: | - # # Fixes "detected dubious ownership" error in the ci - # git config --global --add safe.directory '*' - # time cargo nextest run \ - # --workspace \ - # --locked \ - # --release \ - # --no-fail-fast \ - # --features try-runtime,experimental,riscv,ci-only-tests \ - # --partition count:${{ matrix.partition }} - # # run runtime-api tests with `enable-staging-api` feature on the 1st node - # if [ "${{ matrix.partition }}" == "1/3" ]; then time cargo nextest run -p sp-api-test --features enable-staging-api; fi + #todo: enable forklift + test-linux-stable-oldkernel: + needs: [set-image, changes] + if: ${{ needs.changes.outputs.rust }} + runs-on: oldlinux + timeout-minutes: 60 + strategy: + fail-fast: false + matrix: + partition: [1/3, 2/3, 3/3] + container: + image: ${{ needs.set-image.outputs.IMAGE }} + # needed for tests that use unshare syscall + options: --security-opt seccomp=unconfined + env: + RUST_TOOLCHAIN: stable + # Enable debug assertions since we are running optimized builds for testing + # but still want to have debug assertions. + RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings" + steps: + - name: Checkout + uses: actions/checkout@v4 + - name: script + run: | + # Fixes "detected dubious ownership" error in the ci + git config --global --add safe.directory '*' + time cargo nextest run \ + --workspace \ + --locked \ + --release \ + --no-fail-fast \ + --features try-runtime,experimental,riscv,ci-only-tests \ + --partition count:${{ matrix.partition }} + # run runtime-api tests with `enable-staging-api` feature on the 1st node + if [ "${{ matrix.partition }}" == "1/3" ]; then time cargo nextest run -p sp-api-test --features enable-staging-api; fi - # #todo: enable forklift - # test-linux-stable: - # needs: [set-image, changes] - # if: ${{ needs.changes.outputs.rust }} - # runs-on: arc-runners-polkadot-sdk-beefy-ubuntu - # timeout-minutes: 60 - # strategy: - # fail-fast: false - # matrix: - # partition: [1/3, 2/3, 3/3] - # container: - # image: ${{ needs.set-image.outputs.IMAGE }} - # # needed for tests that use unshare syscall - # options: --security-opt seccomp=unconfined - # env: - # RUST_TOOLCHAIN: stable - # # Enable debug assertions since we are running optimized builds for testing - # # but still want to have debug assertions. - # RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings" - # steps: - # - name: Checkout - # uses: actions/checkout@v4 - # - name: script - # run: | - # # Fixes "detected dubious ownership" error in the ci - # git config --global --add safe.directory '*' - # time cargo nextest run \ - # --workspace \ - # --locked \ - # --release \ - # --no-fail-fast \ - # --features try-runtime,experimental,riscv,ci-only-tests \ - # --partition count:${{ matrix.partition }} - # # run runtime-api tests with `enable-staging-api` feature on the 1st node - # if [ "${{ matrix.partition }}" == "1/3" ]; then time cargo nextest run -p sp-api-test --features enable-staging-api; fi + #todo: enable forklift + test-linux-stable: + needs: [set-image, changes] + if: ${{ needs.changes.outputs.rust }} + runs-on: arc-runners-polkadot-sdk-beefy-ubuntu + timeout-minutes: 60 + strategy: + fail-fast: false + matrix: + partition: [1/3, 2/3, 3/3] + container: + image: ${{ needs.set-image.outputs.IMAGE }} + # needed for tests that use unshare syscall + options: --security-opt seccomp=unconfined + env: + RUST_TOOLCHAIN: stable + # Enable debug assertions since we are running optimized builds for testing + # but still want to have debug assertions. + RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings" + steps: + - name: Checkout + uses: actions/checkout@v4 + - name: script + run: | + # Fixes "detected dubious ownership" error in the ci + git config --global --add safe.directory '*' + time cargo nextest run \ + --workspace \ + --locked \ + --release \ + --no-fail-fast \ + --features try-runtime,experimental,riscv,ci-only-tests \ + --partition count:${{ matrix.partition }} + # run runtime-api tests with `enable-staging-api` feature on the 1st node + if [ "${{ matrix.partition }}" == "1/3" ]; then time cargo nextest run -p sp-api-test --features enable-staging-api; fi - # test-linux-stable-oldkernel-fl: - # needs: [set-image, changes] - # if: ${{ needs.changes.outputs.rust }} - # runs-on: oldlinux - # timeout-minutes: 60 - # strategy: - # fail-fast: false - # matrix: - # partition: [1/3, 2/3, 3/3] - # container: - # image: ${{ needs.set-image.outputs.IMAGE }} - # # needed for tests that use unshare syscall - # options: --security-opt seccomp=unconfined - # env: - # RUST_TOOLCHAIN: stable - # # Enable debug assertions since we are running optimized builds for testing - # # but still want to have debug assertions. - # RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings" - # steps: - # - name: Checkout - # uses: actions/checkout@v4 - # - name: script - # run: | - # # Fixes "detected dubious ownership" error in the ci - # git config --global --add safe.directory '*' - # time forklift cargo nextest run \ - # --workspace \ - # --locked \ - # --release \ - # --no-fail-fast \ - # --features try-runtime,experimental,riscv,ci-only-tests \ - # --partition count:${{ matrix.partition }} - # # run runtime-api tests with `enable-staging-api` feature on the 1st node - # if [ "${{ matrix.partition }}" == "1/3" ]; then time forklift cargo nextest run -p sp-api-test --features enable-staging-api; fi + test-linux-stable-oldkernel-fl: + needs: [set-image, changes] + if: ${{ needs.changes.outputs.rust }} + runs-on: oldlinux + timeout-minutes: 60 + strategy: + fail-fast: false + matrix: + partition: [1/3, 2/3, 3/3] + container: + image: ${{ needs.set-image.outputs.IMAGE }} + # needed for tests that use unshare syscall + options: --security-opt seccomp=unconfined + env: + RUST_TOOLCHAIN: stable + # Enable debug assertions since we are running optimized builds for testing + # but still want to have debug assertions. + RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings" + steps: + - name: Checkout + uses: actions/checkout@v4 + - name: script + run: | + # Fixes "detected dubious ownership" error in the ci + git config --global --add safe.directory '*' + time forklift cargo nextest run \ + --workspace \ + --locked \ + --release \ + --no-fail-fast \ + --features try-runtime,experimental,riscv,ci-only-tests \ + --partition count:${{ matrix.partition }} + # run runtime-api tests with `enable-staging-api` feature on the 1st node + if [ "${{ matrix.partition }}" == "1/3" ]; then time forklift cargo nextest run -p sp-api-test --features enable-staging-api; fi - # test-linux-stable-fl: - # needs: [set-image, changes] - # if: ${{ needs.changes.outputs.rust }} - # runs-on: arc-runners-polkadot-sdk-beefy-ubuntu - # timeout-minutes: 60 - # strategy: - # fail-fast: false - # matrix: - # partition: [1/3, 2/3, 3/3] - # container: - # image: ${{ needs.set-image.outputs.IMAGE }} - # # needed for tests that use unshare syscall - # options: --security-opt seccomp=unconfined - # env: - # RUST_TOOLCHAIN: stable - # # Enable debug assertions since we are running optimized builds for testing - # # but still want to have debug assertions. - # RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings" - # steps: - # - name: Checkout - # uses: actions/checkout@v4 - # - name: script - # run: | - # # Fixes "detected dubious ownership" error in the ci - # git config --global --add safe.directory '*' - # time forklift cargo nextest run \ - # --workspace \ - # --locked \ - # --release \ - # --no-fail-fast \ - # --features try-runtime,experimental,riscv,ci-only-tests \ - # --partition count:${{ matrix.partition }} - # # run runtime-api tests with `enable-staging-api` feature on the 1st node - # if [ "${{ matrix.partition }}" == "1/3" ]; then time forklift cargo nextest run -p sp-api-test --features enable-staging-api; fi + test-linux-stable-fl: + needs: [set-image, changes] + if: ${{ needs.changes.outputs.rust }} + runs-on: arc-runners-polkadot-sdk-beefy-ubuntu + timeout-minutes: 60 + strategy: + fail-fast: false + matrix: + partition: [1/3, 2/3, 3/3] + container: + image: ${{ needs.set-image.outputs.IMAGE }} + # needed for tests that use unshare syscall + options: --security-opt seccomp=unconfined + env: + RUST_TOOLCHAIN: stable + # Enable debug assertions since we are running optimized builds for testing + # but still want to have debug assertions. + RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings" + steps: + - name: Checkout + uses: actions/checkout@v4 + - name: script + run: | + # Fixes "detected dubious ownership" error in the ci + git config --global --add safe.directory '*' + time forklift cargo nextest run \ + --workspace \ + --locked \ + --release \ + --no-fail-fast \ + --features try-runtime,experimental,riscv,ci-only-tests \ + --partition count:${{ matrix.partition }} + # run runtime-api tests with `enable-staging-api` feature on the 1st node + if [ "${{ matrix.partition }}" == "1/3" ]; then time forklift cargo nextest run -p sp-api-test --features enable-staging-api; fi test-landlock: needs: [set-image, changes] From 67a70fb67280ffcf899ea35c56486e02b17a1332 Mon Sep 17 00:00:00 2001 From: alvicsam Date: Fri, 5 Jul 2024 16:06:06 +0200 Subject: [PATCH 20/52] run on gitlab --- .../{tmp => }/gitspiegel-trigger.yml | 0 .github/workflows/tests-linux-stable.yml | 36 +++++++++---------- 2 files changed, 18 insertions(+), 18 deletions(-) rename .github/workflows/{tmp => }/gitspiegel-trigger.yml (100%) diff --git a/.github/workflows/tmp/gitspiegel-trigger.yml b/.github/workflows/gitspiegel-trigger.yml similarity index 100% rename from .github/workflows/tmp/gitspiegel-trigger.yml rename to .github/workflows/gitspiegel-trigger.yml diff --git a/.github/workflows/tests-linux-stable.yml b/.github/workflows/tests-linux-stable.yml index f7904d7be990..7f008f214023 100644 --- a/.github/workflows/tests-linux-stable.yml +++ b/.github/workflows/tests-linux-stable.yml @@ -214,21 +214,21 @@ jobs: # run runtime-api tests with `enable-staging-api` feature on the 1st node if [ "${{ matrix.partition }}" == "1/3" ]; then time forklift cargo nextest run -p sp-api-test --features enable-staging-api; fi - test-landlock: - needs: [set-image, changes] - if: ${{ needs.changes.outputs.rust }} - # runs-on: arc-runners-polkadot-sdk-beefy-ubuntu - runs-on: ubuntu-latest - timeout-minutes: 60 - container: - image: ${{ needs.set-image.outputs.IMAGE }} - options: --security-opt seccomp=unconfined - env: - RUST_TOOLCHAIN: stable - RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings" - steps: - - name: Checkout - uses: actions/checkout@v4 - - name: script - run: | - SKIP_WASM_BUILD="1" cargo test -p polkadot-node-core-pvf all_security_features_work --features=ci-only-tests + # test-landlock: + # needs: [set-image, changes] + # if: ${{ needs.changes.outputs.rust }} + # # runs-on: arc-runners-polkadot-sdk-beefy-ubuntu + # runs-on: ubuntu-latest + # timeout-minutes: 60 + # container: + # image: ${{ needs.set-image.outputs.IMAGE }} + # options: --security-opt seccomp=unconfined + # env: + # RUST_TOOLCHAIN: stable + # RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings" + # steps: + # - name: Checkout + # uses: actions/checkout@v4 + # - name: script + # run: | + # SKIP_WASM_BUILD="1" cargo test -p polkadot-node-core-pvf all_security_features_work --features=ci-only-tests From e96083314a3a17d4a47564478267821524eb16c4 Mon Sep 17 00:00:00 2001 From: alvicsam Date: Mon, 8 Jul 2024 16:38:35 +0200 Subject: [PATCH 21/52] test ensure_check_metadata_works_on_real_extrinsics --- .github/workflows/tests-linux-stable.yml | 364 +++++++++++++---------- 1 file changed, 204 insertions(+), 160 deletions(-) diff --git a/.github/workflows/tests-linux-stable.yml b/.github/workflows/tests-linux-stable.yml index 7f008f214023..d01450201e3f 100644 --- a/.github/workflows/tests-linux-stable.yml +++ b/.github/workflows/tests-linux-stable.yml @@ -33,130 +33,217 @@ jobs: - id: set_image run: cat .github/env >> $GITHUB_OUTPUT - test-linux-stable-int: - needs: [set-image, changes] - if: ${{ needs.changes.outputs.rust }} - runs-on: arc-runners-polkadot-sdk-beefy - timeout-minutes: 60 - container: - image: ${{ needs.set-image.outputs.IMAGE }} - env: - RUSTFLAGS: "-C debug-assertions -D warnings" - RUST_BACKTRACE: 1 - WASM_BUILD_NO_COLOR: 1 - WASM_BUILD_RUSTFLAGS: "-C debug-assertions -D warnings" - # Ensure we run the UI tests. - RUN_UI_TESTS: 1 - steps: - - name: Checkout - uses: actions/checkout@v4 - - name: script - run: WASM_BUILD_NO_COLOR=1 time forklift cargo test -p staging-node-cli --release --locked -- --ignored + # test-linux-stable-int: + # needs: [set-image, changes] + # if: ${{ needs.changes.outputs.rust }} + # runs-on: arc-runners-polkadot-sdk-beefy + # timeout-minutes: 60 + # container: + # image: ${{ needs.set-image.outputs.IMAGE }} + # env: + # RUSTFLAGS: "-C debug-assertions -D warnings" + # RUST_BACKTRACE: 1 + # WASM_BUILD_NO_COLOR: 1 + # WASM_BUILD_RUSTFLAGS: "-C debug-assertions -D warnings" + # # Ensure we run the UI tests. + # RUN_UI_TESTS: 1 + # steps: + # - name: Checkout + # uses: actions/checkout@v4 + # - name: script + # run: WASM_BUILD_NO_COLOR=1 time forklift cargo test -p staging-node-cli --release --locked -- --ignored - # https://github.com/paritytech/ci_cd/issues/864 - test-linux-stable-runtime-benchmarks: - needs: [set-image, changes] - if: ${{ needs.changes.outputs.rust }} - runs-on: arc-runners-polkadot-sdk-beefy - timeout-minutes: 60 - container: - image: ${{ needs.set-image.outputs.IMAGE }} - env: - RUST_TOOLCHAIN: stable - # Enable debug assertions since we are running optimized builds for testing - # but still want to have debug assertions. - RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings" - steps: - - name: Checkout - uses: actions/checkout@v4 - - name: script - run: time forklift cargo nextest run --workspace --features runtime-benchmarks benchmark --locked --cargo-profile testnet + # # https://github.com/paritytech/ci_cd/issues/864 + # test-linux-stable-runtime-benchmarks: + # needs: [set-image, changes] + # if: ${{ needs.changes.outputs.rust }} + # runs-on: arc-runners-polkadot-sdk-beefy + # timeout-minutes: 60 + # container: + # image: ${{ needs.set-image.outputs.IMAGE }} + # env: + # RUST_TOOLCHAIN: stable + # # Enable debug assertions since we are running optimized builds for testing + # # but still want to have debug assertions. + # RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings" + # steps: + # - name: Checkout + # uses: actions/checkout@v4 + # - name: script + # run: time forklift cargo nextest run --workspace --features runtime-benchmarks benchmark --locked --cargo-profile testnet - #todo: enable forklift - test-linux-stable-oldkernel: - needs: [set-image, changes] - if: ${{ needs.changes.outputs.rust }} - runs-on: oldlinux - timeout-minutes: 60 - strategy: - fail-fast: false - matrix: - partition: [1/3, 2/3, 3/3] - container: - image: ${{ needs.set-image.outputs.IMAGE }} - # needed for tests that use unshare syscall - options: --security-opt seccomp=unconfined - env: - RUST_TOOLCHAIN: stable - # Enable debug assertions since we are running optimized builds for testing - # but still want to have debug assertions. - RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings" - steps: - - name: Checkout - uses: actions/checkout@v4 - - name: script - run: | - # Fixes "detected dubious ownership" error in the ci - git config --global --add safe.directory '*' - time cargo nextest run \ - --workspace \ - --locked \ - --release \ - --no-fail-fast \ - --features try-runtime,experimental,riscv,ci-only-tests \ - --partition count:${{ matrix.partition }} - # run runtime-api tests with `enable-staging-api` feature on the 1st node - if [ "${{ matrix.partition }}" == "1/3" ]; then time cargo nextest run -p sp-api-test --features enable-staging-api; fi + # #todo: enable forklift + # test-linux-stable-oldkernel: + # needs: [set-image, changes] + # if: ${{ needs.changes.outputs.rust }} + # runs-on: oldlinux + # timeout-minutes: 60 + # strategy: + # fail-fast: false + # matrix: + # partition: [1/3, 2/3, 3/3] + # container: + # image: ${{ needs.set-image.outputs.IMAGE }} + # # needed for tests that use unshare syscall + # options: --security-opt seccomp=unconfined + # env: + # RUST_TOOLCHAIN: stable + # # Enable debug assertions since we are running optimized builds for testing + # # but still want to have debug assertions. + # RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings" + # steps: + # - name: Checkout + # uses: actions/checkout@v4 + # - name: script + # run: | + # # Fixes "detected dubious ownership" error in the ci + # git config --global --add safe.directory '*' + # time cargo nextest run \ + # --workspace \ + # --locked \ + # --release \ + # --no-fail-fast \ + # --features try-runtime,experimental,riscv,ci-only-tests \ + # --partition count:${{ matrix.partition }} + # # run runtime-api tests with `enable-staging-api` feature on the 1st node + # if [ "${{ matrix.partition }}" == "1/3" ]; then time cargo nextest run -p sp-api-test --features enable-staging-api; fi - #todo: enable forklift - test-linux-stable: - needs: [set-image, changes] - if: ${{ needs.changes.outputs.rust }} - runs-on: arc-runners-polkadot-sdk-beefy-ubuntu - timeout-minutes: 60 - strategy: - fail-fast: false - matrix: - partition: [1/3, 2/3, 3/3] - container: - image: ${{ needs.set-image.outputs.IMAGE }} - # needed for tests that use unshare syscall - options: --security-opt seccomp=unconfined - env: - RUST_TOOLCHAIN: stable - # Enable debug assertions since we are running optimized builds for testing - # but still want to have debug assertions. - RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings" - steps: - - name: Checkout - uses: actions/checkout@v4 - - name: script - run: | - # Fixes "detected dubious ownership" error in the ci - git config --global --add safe.directory '*' - time cargo nextest run \ - --workspace \ - --locked \ - --release \ - --no-fail-fast \ - --features try-runtime,experimental,riscv,ci-only-tests \ - --partition count:${{ matrix.partition }} - # run runtime-api tests with `enable-staging-api` feature on the 1st node - if [ "${{ matrix.partition }}" == "1/3" ]; then time cargo nextest run -p sp-api-test --features enable-staging-api; fi + # #todo: enable forklift + # test-linux-stable: + # needs: [set-image, changes] + # if: ${{ needs.changes.outputs.rust }} + # runs-on: arc-runners-polkadot-sdk-beefy-ubuntu + # timeout-minutes: 60 + # strategy: + # fail-fast: false + # matrix: + # partition: [1/3, 2/3, 3/3] + # container: + # image: ${{ needs.set-image.outputs.IMAGE }} + # # needed for tests that use unshare syscall + # options: --security-opt seccomp=unconfined + # env: + # RUST_TOOLCHAIN: stable + # # Enable debug assertions since we are running optimized builds for testing + # # but still want to have debug assertions. + # RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings" + # steps: + # - name: Checkout + # uses: actions/checkout@v4 + # - name: script + # run: | + # # Fixes "detected dubious ownership" error in the ci + # git config --global --add safe.directory '*' + # time cargo nextest run \ + # --workspace \ + # --locked \ + # --release \ + # --no-fail-fast \ + # --features try-runtime,experimental,riscv,ci-only-tests \ + # --partition count:${{ matrix.partition }} + # # run runtime-api tests with `enable-staging-api` feature on the 1st node + # if [ "${{ matrix.partition }}" == "1/3" ]; then time cargo nextest run -p sp-api-test --features enable-staging-api; fi + + # test-linux-stable-oldkernel-fl: + # needs: [set-image, changes] + # if: ${{ needs.changes.outputs.rust }} + # runs-on: oldlinux + # timeout-minutes: 60 + # strategy: + # fail-fast: false + # matrix: + # partition: [1/3, 2/3, 3/3] + # container: + # image: ${{ needs.set-image.outputs.IMAGE }} + # # needed for tests that use unshare syscall + # options: --security-opt seccomp=unconfined + # env: + # RUST_TOOLCHAIN: stable + # # Enable debug assertions since we are running optimized builds for testing + # # but still want to have debug assertions. + # RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings" + # steps: + # - name: Checkout + # uses: actions/checkout@v4 + # - name: script + # run: | + # # Fixes "detected dubious ownership" error in the ci + # git config --global --add safe.directory '*' + # time forklift cargo nextest run \ + # --workspace \ + # --locked \ + # --release \ + # --no-fail-fast \ + # --features try-runtime,experimental,riscv,ci-only-tests \ + # --partition count:${{ matrix.partition }} + # # run runtime-api tests with `enable-staging-api` feature on the 1st node + # if [ "${{ matrix.partition }}" == "1/3" ]; then time forklift cargo nextest run -p sp-api-test --features enable-staging-api; fi + + # test-linux-stable-fl: + # needs: [set-image, changes] + # if: ${{ needs.changes.outputs.rust }} + # runs-on: arc-runners-polkadot-sdk-beefy-ubuntu + # timeout-minutes: 60 + # strategy: + # fail-fast: false + # matrix: + # partition: [1/3, 2/3, 3/3] + # container: + # image: ${{ needs.set-image.outputs.IMAGE }} + # # needed for tests that use unshare syscall + # options: --security-opt seccomp=unconfined + # env: + # RUST_TOOLCHAIN: stable + # # Enable debug assertions since we are running optimized builds for testing + # # but still want to have debug assertions. + # RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings" + # steps: + # - name: Checkout + # uses: actions/checkout@v4 + # - name: script + # run: | + # # Fixes "detected dubious ownership" error in the ci + # git config --global --add safe.directory '*' + # time forklift cargo nextest run \ + # --workspace \ + # --locked \ + # --release \ + # --no-fail-fast \ + # --features try-runtime,experimental,riscv,ci-only-tests \ + # --partition count:${{ matrix.partition }} + # # run runtime-api tests with `enable-staging-api` feature on the 1st node + # if [ "${{ matrix.partition }}" == "1/3" ]; then time forklift cargo nextest run -p sp-api-test --features enable-staging-api; fi - test-linux-stable-oldkernel-fl: + # test-landlock: + # needs: [set-image, changes] + # if: ${{ needs.changes.outputs.rust }} + # # runs-on: arc-runners-polkadot-sdk-beefy-ubuntu + # runs-on: ubuntu-latest + # timeout-minutes: 60 + # container: + # image: ${{ needs.set-image.outputs.IMAGE }} + # options: --security-opt seccomp=unconfined + # env: + # RUST_TOOLCHAIN: stable + # RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings" + # steps: + # - name: Checkout + # uses: actions/checkout@v4 + # - name: script + # run: | + # SKIP_WASM_BUILD="1" cargo test -p polkadot-node-core-pvf all_security_features_work --features=ci-only-tests + + single-test: needs: [set-image, changes] if: ${{ needs.changes.outputs.rust }} - runs-on: oldlinux + runs-on: arc-runners-polkadot-sdk-beefy timeout-minutes: 60 strategy: fail-fast: false matrix: - partition: [1/3, 2/3, 3/3] + partition: [1, 2, 3, 4, 5] container: image: ${{ needs.set-image.outputs.IMAGE }} - # needed for tests that use unshare syscall - options: --security-opt seccomp=unconfined env: RUST_TOOLCHAIN: stable # Enable debug assertions since we are running optimized builds for testing @@ -166,32 +253,19 @@ jobs: - name: Checkout uses: actions/checkout@v4 - name: script - run: | - # Fixes "detected dubious ownership" error in the ci - git config --global --add safe.directory '*' - time forklift cargo nextest run \ - --workspace \ - --locked \ - --release \ - --no-fail-fast \ - --features try-runtime,experimental,riscv,ci-only-tests \ - --partition count:${{ matrix.partition }} - # run runtime-api tests with `enable-staging-api` feature on the 1st node - if [ "${{ matrix.partition }}" == "1/3" ]; then time forklift cargo nextest run -p sp-api-test --features enable-staging-api; fi + run: cargo test -p frame-metadata-hash-extension ensure_check_metadata_works_on_real_extrinsics - test-linux-stable-fl: + single-test-fl: needs: [set-image, changes] if: ${{ needs.changes.outputs.rust }} - runs-on: arc-runners-polkadot-sdk-beefy-ubuntu + runs-on: arc-runners-polkadot-sdk-beefy timeout-minutes: 60 strategy: fail-fast: false matrix: - partition: [1/3, 2/3, 3/3] + partition: [1, 2, 3, 4, 5] container: image: ${{ needs.set-image.outputs.IMAGE }} - # needed for tests that use unshare syscall - options: --security-opt seccomp=unconfined env: RUST_TOOLCHAIN: stable # Enable debug assertions since we are running optimized builds for testing @@ -201,34 +275,4 @@ jobs: - name: Checkout uses: actions/checkout@v4 - name: script - run: | - # Fixes "detected dubious ownership" error in the ci - git config --global --add safe.directory '*' - time forklift cargo nextest run \ - --workspace \ - --locked \ - --release \ - --no-fail-fast \ - --features try-runtime,experimental,riscv,ci-only-tests \ - --partition count:${{ matrix.partition }} - # run runtime-api tests with `enable-staging-api` feature on the 1st node - if [ "${{ matrix.partition }}" == "1/3" ]; then time forklift cargo nextest run -p sp-api-test --features enable-staging-api; fi - - # test-landlock: - # needs: [set-image, changes] - # if: ${{ needs.changes.outputs.rust }} - # # runs-on: arc-runners-polkadot-sdk-beefy-ubuntu - # runs-on: ubuntu-latest - # timeout-minutes: 60 - # container: - # image: ${{ needs.set-image.outputs.IMAGE }} - # options: --security-opt seccomp=unconfined - # env: - # RUST_TOOLCHAIN: stable - # RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings" - # steps: - # - name: Checkout - # uses: actions/checkout@v4 - # - name: script - # run: | - # SKIP_WASM_BUILD="1" cargo test -p polkadot-node-core-pvf all_security_features_work --features=ci-only-tests + run: forklift cargo test -p frame-metadata-hash-extension ensure_check_metadata_works_on_real_extrinsics From 8c4b868f033bc46aa2496ca804fb5d943840bae0 Mon Sep 17 00:00:00 2001 From: alvicsam Date: Mon, 8 Jul 2024 17:13:48 +0200 Subject: [PATCH 22/52] run test on gl --- .gitlab/pipeline/test.yml | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/.gitlab/pipeline/test.yml b/.gitlab/pipeline/test.yml index d171a8a19426..a7e46f545c9b 100644 --- a/.gitlab/pipeline/test.yml +++ b/.gitlab/pipeline/test.yml @@ -111,6 +111,21 @@ test-linux-stable-codecov: fi # +single-test-fl: + stage: test + extends: + - .docker-env + - .common-refs + - .run-immediately + # - .pipeline-stopper-artifacts + variables: + RUST_TOOLCHAIN: stable + # Enable debug assertions since we are running optimized builds for testing + # but still want to have debug assertions. + RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings" + parallel: 5 + script: + - cargo test -p frame-metadata-hash-extension ensure_check_metadata_works_on_real_extrinsics test-linux-stable: stage: test From 2151b10aec02585c61e9577b459f828f81bdebcb Mon Sep 17 00:00:00 2001 From: alvicsam Date: Mon, 8 Jul 2024 17:20:54 +0200 Subject: [PATCH 23/52] trace log --- .forklift/config-gitlab.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.forklift/config-gitlab.toml b/.forklift/config-gitlab.toml index ab3b2729a46d..cda1028718fc 100644 --- a/.forklift/config-gitlab.toml +++ b/.forklift/config-gitlab.toml @@ -7,7 +7,7 @@ compressionLevel = 3 [general] jobNameVariable = "CI_JOB_NAME" jobsBlackList = [] -logLevel = "warn" +logLevel = "trace" threadsCount = 6 [cache] From ee50c6b0cda4774ae94d1308a1f6556f8f89134d Mon Sep 17 00:00:00 2001 From: alvicsam Date: Tue, 9 Jul 2024 15:50:39 +0200 Subject: [PATCH 24/52] run upd fl --- .github/workflows/tests-linux-stable.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/tests-linux-stable.yml b/.github/workflows/tests-linux-stable.yml index d01450201e3f..bf337f6e648f 100644 --- a/.github/workflows/tests-linux-stable.yml +++ b/.github/workflows/tests-linux-stable.yml @@ -274,5 +274,8 @@ jobs: steps: - name: Checkout uses: actions/checkout@v4 + - name: update forklift + run: curl -o .forklift/forklift -L https://github.com/paritytech/forklift/releases/download/0.13.1-alpha/forklift_0.13.1-alpha_linux_amd64 + - run: chmod +x .forklift/forklift && .forklift/forklift version - name: script - run: forklift cargo test -p frame-metadata-hash-extension ensure_check_metadata_works_on_real_extrinsics + run: time ./.forklift/forklift cargo test -p frame-metadata-hash-extension ensure_check_metadata_works_on_real_extrinsics From 680cf6a7021d67b30a81ed7689f1d07108de30be Mon Sep 17 00:00:00 2001 From: alvicsam Date: Tue, 9 Jul 2024 16:25:36 +0200 Subject: [PATCH 25/52] run test-linux-stabe --- .github/workflows/tests-linux-stable.yml | 142 ++++++++++++----------- 1 file changed, 74 insertions(+), 68 deletions(-) diff --git a/.github/workflows/tests-linux-stable.yml b/.github/workflows/tests-linux-stable.yml index bf337f6e648f..3e5eb3dfa504 100644 --- a/.github/workflows/tests-linux-stable.yml +++ b/.github/workflows/tests-linux-stable.yml @@ -144,75 +144,81 @@ jobs: # # run runtime-api tests with `enable-staging-api` feature on the 1st node # if [ "${{ matrix.partition }}" == "1/3" ]; then time cargo nextest run -p sp-api-test --features enable-staging-api; fi - # test-linux-stable-oldkernel-fl: - # needs: [set-image, changes] - # if: ${{ needs.changes.outputs.rust }} - # runs-on: oldlinux - # timeout-minutes: 60 - # strategy: - # fail-fast: false - # matrix: - # partition: [1/3, 2/3, 3/3] - # container: - # image: ${{ needs.set-image.outputs.IMAGE }} - # # needed for tests that use unshare syscall - # options: --security-opt seccomp=unconfined - # env: - # RUST_TOOLCHAIN: stable - # # Enable debug assertions since we are running optimized builds for testing - # # but still want to have debug assertions. - # RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings" - # steps: - # - name: Checkout - # uses: actions/checkout@v4 - # - name: script - # run: | - # # Fixes "detected dubious ownership" error in the ci - # git config --global --add safe.directory '*' - # time forklift cargo nextest run \ - # --workspace \ - # --locked \ - # --release \ - # --no-fail-fast \ - # --features try-runtime,experimental,riscv,ci-only-tests \ - # --partition count:${{ matrix.partition }} - # # run runtime-api tests with `enable-staging-api` feature on the 1st node - # if [ "${{ matrix.partition }}" == "1/3" ]; then time forklift cargo nextest run -p sp-api-test --features enable-staging-api; fi + test-linux-stable-oldkernel-fl: + needs: [set-image, changes] + if: ${{ needs.changes.outputs.rust }} + runs-on: oldlinux + timeout-minutes: 60 + strategy: + fail-fast: false + matrix: + partition: [1/3, 2/3, 3/3] + container: + image: ${{ needs.set-image.outputs.IMAGE }} + # needed for tests that use unshare syscall + options: --security-opt seccomp=unconfined + env: + RUST_TOOLCHAIN: stable + # Enable debug assertions since we are running optimized builds for testing + # but still want to have debug assertions. + RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings" + steps: + - name: Checkout + uses: actions/checkout@v4 + - name: update forklift + run: curl -o .forklift/forklift -L https://github.com/paritytech/forklift/releases/download/0.13.1-alpha/forklift_0.13.1-alpha_linux_amd64 + - run: chmod +x .forklift/forklift && .forklift/forklift version + - name: script + run: | + # Fixes "detected dubious ownership" error in the ci + git config --global --add safe.directory '*' + .forklift/forklift cargo nextest run \ + --workspace \ + --locked \ + --release \ + --no-fail-fast \ + --features try-runtime,experimental,riscv,ci-only-tests \ + --partition count:${{ matrix.partition }} + # run runtime-api tests with `enable-staging-api` feature on the 1st node + if [ "${{ matrix.partition }}" == "1/3" ]; then time forklift cargo nextest run -p sp-api-test --features enable-staging-api; fi - # test-linux-stable-fl: - # needs: [set-image, changes] - # if: ${{ needs.changes.outputs.rust }} - # runs-on: arc-runners-polkadot-sdk-beefy-ubuntu - # timeout-minutes: 60 - # strategy: - # fail-fast: false - # matrix: - # partition: [1/3, 2/3, 3/3] - # container: - # image: ${{ needs.set-image.outputs.IMAGE }} - # # needed for tests that use unshare syscall - # options: --security-opt seccomp=unconfined - # env: - # RUST_TOOLCHAIN: stable - # # Enable debug assertions since we are running optimized builds for testing - # # but still want to have debug assertions. - # RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings" - # steps: - # - name: Checkout - # uses: actions/checkout@v4 - # - name: script - # run: | - # # Fixes "detected dubious ownership" error in the ci - # git config --global --add safe.directory '*' - # time forklift cargo nextest run \ - # --workspace \ - # --locked \ - # --release \ - # --no-fail-fast \ - # --features try-runtime,experimental,riscv,ci-only-tests \ - # --partition count:${{ matrix.partition }} - # # run runtime-api tests with `enable-staging-api` feature on the 1st node - # if [ "${{ matrix.partition }}" == "1/3" ]; then time forklift cargo nextest run -p sp-api-test --features enable-staging-api; fi + test-linux-stable-fl: + needs: [set-image, changes] + if: ${{ needs.changes.outputs.rust }} + runs-on: arc-runners-polkadot-sdk-beefy-ubuntu + timeout-minutes: 60 + strategy: + fail-fast: false + matrix: + partition: [1/3, 2/3, 3/3] + container: + image: ${{ needs.set-image.outputs.IMAGE }} + # needed for tests that use unshare syscall + options: --security-opt seccomp=unconfined + env: + RUST_TOOLCHAIN: stable + # Enable debug assertions since we are running optimized builds for testing + # but still want to have debug assertions. + RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings" + steps: + - name: Checkout + uses: actions/checkout@v4 + - name: update forklift + run: curl -o .forklift/forklift -L https://github.com/paritytech/forklift/releases/download/0.13.1-alpha/forklift_0.13.1-alpha_linux_amd64 + - run: chmod +x .forklift/forklift && .forklift/forklift version + - name: script + run: | + # Fixes "detected dubious ownership" error in the ci + git config --global --add safe.directory '*' + .forklift/forklift cargo nextest run \ + --workspace \ + --locked \ + --release \ + --no-fail-fast \ + --features try-runtime,experimental,riscv,ci-only-tests \ + --partition count:${{ matrix.partition }} + # run runtime-api tests with `enable-staging-api` feature on the 1st node + if [ "${{ matrix.partition }}" == "1/3" ]; then time forklift cargo nextest run -p sp-api-test --features enable-staging-api; fi # test-landlock: # needs: [set-image, changes] From 4ab7cdc4eb7153ae0199874d8d295485e54c5d43 Mon Sep 17 00:00:00 2001 From: alvicsam Date: Mon, 15 Jul 2024 14:10:00 +0200 Subject: [PATCH 26/52] put workflows back --- .../workflows/{tmp => }/check-features.yml | 0 .github/workflows/{tmp => }/check-labels.yml | 0 .../workflows/{tmp => }/check-licenses.yml | 0 .github/workflows/{tmp => }/check-links.yml | 0 .../{tmp => }/check-runtime-migration.yml | 0 .github/workflows/{tmp => }/checks-quick.yml | 0 .../workflows/{tmp => }/command-bench-all.yml | 0 .../{tmp => }/command-bench-overhead.yml | 0 .github/workflows/{tmp => }/command-bench.yml | 0 .github/workflows/{tmp => }/command-fmt.yml | 0 .../workflows/{tmp => }/command-inform.yml | 0 .../workflows/{tmp => }/command-update-ui.yml | 0 .../{tmp => }/issues-auto-add-parachain.yml | 0 .../workflows/{tmp => }/issues-auto-label.yml | 0 .../{tmp => }/misc-notify-burnin-label.yml | 0 .../{tmp => }/misc-review-bot-merge-queue.yml | 0 .../{tmp => }/misc-sync-templates.yml | 0 .../{tmp => }/publish-check-crates.yml | 0 .../{tmp => }/publish-claim-crates.yml | 0 .../publish-subsystem-benchmarks.yml | 0 .../{tmp => }/release-10_rc-automation.yml | 0 .../release-30_publish_release_draft.yml | 0 .../{tmp => }/release-50_publish-docker.yml | 0 .../{tmp => }/release-99_notif-published.yml | 0 .../{tmp => }/release-check-runtimes.yml | 0 .../{tmp => }/release-clobber-stable.yml | 0 .../workflows/{tmp => }/release-srtool.yml | 0 .github/workflows/{tmp => }/review-bot.yml | 0 .../workflows/{tmp => }/review-trigger.yml | 0 .github/workflows/{tmp => }/tests.yml | 0 .github/workflows/tmp/check-semver.yml | 58 ------------------- 31 files changed, 58 deletions(-) rename .github/workflows/{tmp => }/check-features.yml (100%) rename .github/workflows/{tmp => }/check-labels.yml (100%) rename .github/workflows/{tmp => }/check-licenses.yml (100%) rename .github/workflows/{tmp => }/check-links.yml (100%) rename .github/workflows/{tmp => }/check-runtime-migration.yml (100%) rename .github/workflows/{tmp => }/checks-quick.yml (100%) rename .github/workflows/{tmp => }/command-bench-all.yml (100%) rename .github/workflows/{tmp => }/command-bench-overhead.yml (100%) rename .github/workflows/{tmp => }/command-bench.yml (100%) rename .github/workflows/{tmp => }/command-fmt.yml (100%) rename .github/workflows/{tmp => }/command-inform.yml (100%) rename .github/workflows/{tmp => }/command-update-ui.yml (100%) rename .github/workflows/{tmp => }/issues-auto-add-parachain.yml (100%) rename .github/workflows/{tmp => }/issues-auto-label.yml (100%) rename .github/workflows/{tmp => }/misc-notify-burnin-label.yml (100%) rename .github/workflows/{tmp => }/misc-review-bot-merge-queue.yml (100%) rename .github/workflows/{tmp => }/misc-sync-templates.yml (100%) rename .github/workflows/{tmp => }/publish-check-crates.yml (100%) rename .github/workflows/{tmp => }/publish-claim-crates.yml (100%) rename .github/workflows/{tmp => }/publish-subsystem-benchmarks.yml (100%) rename .github/workflows/{tmp => }/release-10_rc-automation.yml (100%) rename .github/workflows/{tmp => }/release-30_publish_release_draft.yml (100%) rename .github/workflows/{tmp => }/release-50_publish-docker.yml (100%) rename .github/workflows/{tmp => }/release-99_notif-published.yml (100%) rename .github/workflows/{tmp => }/release-check-runtimes.yml (100%) rename .github/workflows/{tmp => }/release-clobber-stable.yml (100%) rename .github/workflows/{tmp => }/release-srtool.yml (100%) rename .github/workflows/{tmp => }/review-bot.yml (100%) rename .github/workflows/{tmp => }/review-trigger.yml (100%) rename .github/workflows/{tmp => }/tests.yml (100%) delete mode 100644 .github/workflows/tmp/check-semver.yml diff --git a/.github/workflows/tmp/check-features.yml b/.github/workflows/check-features.yml similarity index 100% rename from .github/workflows/tmp/check-features.yml rename to .github/workflows/check-features.yml diff --git a/.github/workflows/tmp/check-labels.yml b/.github/workflows/check-labels.yml similarity index 100% rename from .github/workflows/tmp/check-labels.yml rename to .github/workflows/check-labels.yml diff --git a/.github/workflows/tmp/check-licenses.yml b/.github/workflows/check-licenses.yml similarity index 100% rename from .github/workflows/tmp/check-licenses.yml rename to .github/workflows/check-licenses.yml diff --git a/.github/workflows/tmp/check-links.yml b/.github/workflows/check-links.yml similarity index 100% rename from .github/workflows/tmp/check-links.yml rename to .github/workflows/check-links.yml diff --git a/.github/workflows/tmp/check-runtime-migration.yml b/.github/workflows/check-runtime-migration.yml similarity index 100% rename from .github/workflows/tmp/check-runtime-migration.yml rename to .github/workflows/check-runtime-migration.yml diff --git a/.github/workflows/tmp/checks-quick.yml b/.github/workflows/checks-quick.yml similarity index 100% rename from .github/workflows/tmp/checks-quick.yml rename to .github/workflows/checks-quick.yml diff --git a/.github/workflows/tmp/command-bench-all.yml b/.github/workflows/command-bench-all.yml similarity index 100% rename from .github/workflows/tmp/command-bench-all.yml rename to .github/workflows/command-bench-all.yml diff --git a/.github/workflows/tmp/command-bench-overhead.yml b/.github/workflows/command-bench-overhead.yml similarity index 100% rename from .github/workflows/tmp/command-bench-overhead.yml rename to .github/workflows/command-bench-overhead.yml diff --git a/.github/workflows/tmp/command-bench.yml b/.github/workflows/command-bench.yml similarity index 100% rename from .github/workflows/tmp/command-bench.yml rename to .github/workflows/command-bench.yml diff --git a/.github/workflows/tmp/command-fmt.yml b/.github/workflows/command-fmt.yml similarity index 100% rename from .github/workflows/tmp/command-fmt.yml rename to .github/workflows/command-fmt.yml diff --git a/.github/workflows/tmp/command-inform.yml b/.github/workflows/command-inform.yml similarity index 100% rename from .github/workflows/tmp/command-inform.yml rename to .github/workflows/command-inform.yml diff --git a/.github/workflows/tmp/command-update-ui.yml b/.github/workflows/command-update-ui.yml similarity index 100% rename from .github/workflows/tmp/command-update-ui.yml rename to .github/workflows/command-update-ui.yml diff --git a/.github/workflows/tmp/issues-auto-add-parachain.yml b/.github/workflows/issues-auto-add-parachain.yml similarity index 100% rename from .github/workflows/tmp/issues-auto-add-parachain.yml rename to .github/workflows/issues-auto-add-parachain.yml diff --git a/.github/workflows/tmp/issues-auto-label.yml b/.github/workflows/issues-auto-label.yml similarity index 100% rename from .github/workflows/tmp/issues-auto-label.yml rename to .github/workflows/issues-auto-label.yml diff --git a/.github/workflows/tmp/misc-notify-burnin-label.yml b/.github/workflows/misc-notify-burnin-label.yml similarity index 100% rename from .github/workflows/tmp/misc-notify-burnin-label.yml rename to .github/workflows/misc-notify-burnin-label.yml diff --git a/.github/workflows/tmp/misc-review-bot-merge-queue.yml b/.github/workflows/misc-review-bot-merge-queue.yml similarity index 100% rename from .github/workflows/tmp/misc-review-bot-merge-queue.yml rename to .github/workflows/misc-review-bot-merge-queue.yml diff --git a/.github/workflows/tmp/misc-sync-templates.yml b/.github/workflows/misc-sync-templates.yml similarity index 100% rename from .github/workflows/tmp/misc-sync-templates.yml rename to .github/workflows/misc-sync-templates.yml diff --git a/.github/workflows/tmp/publish-check-crates.yml b/.github/workflows/publish-check-crates.yml similarity index 100% rename from .github/workflows/tmp/publish-check-crates.yml rename to .github/workflows/publish-check-crates.yml diff --git a/.github/workflows/tmp/publish-claim-crates.yml b/.github/workflows/publish-claim-crates.yml similarity index 100% rename from .github/workflows/tmp/publish-claim-crates.yml rename to .github/workflows/publish-claim-crates.yml diff --git a/.github/workflows/tmp/publish-subsystem-benchmarks.yml b/.github/workflows/publish-subsystem-benchmarks.yml similarity index 100% rename from .github/workflows/tmp/publish-subsystem-benchmarks.yml rename to .github/workflows/publish-subsystem-benchmarks.yml diff --git a/.github/workflows/tmp/release-10_rc-automation.yml b/.github/workflows/release-10_rc-automation.yml similarity index 100% rename from .github/workflows/tmp/release-10_rc-automation.yml rename to .github/workflows/release-10_rc-automation.yml diff --git a/.github/workflows/tmp/release-30_publish_release_draft.yml b/.github/workflows/release-30_publish_release_draft.yml similarity index 100% rename from .github/workflows/tmp/release-30_publish_release_draft.yml rename to .github/workflows/release-30_publish_release_draft.yml diff --git a/.github/workflows/tmp/release-50_publish-docker.yml b/.github/workflows/release-50_publish-docker.yml similarity index 100% rename from .github/workflows/tmp/release-50_publish-docker.yml rename to .github/workflows/release-50_publish-docker.yml diff --git a/.github/workflows/tmp/release-99_notif-published.yml b/.github/workflows/release-99_notif-published.yml similarity index 100% rename from .github/workflows/tmp/release-99_notif-published.yml rename to .github/workflows/release-99_notif-published.yml diff --git a/.github/workflows/tmp/release-check-runtimes.yml b/.github/workflows/release-check-runtimes.yml similarity index 100% rename from .github/workflows/tmp/release-check-runtimes.yml rename to .github/workflows/release-check-runtimes.yml diff --git a/.github/workflows/tmp/release-clobber-stable.yml b/.github/workflows/release-clobber-stable.yml similarity index 100% rename from .github/workflows/tmp/release-clobber-stable.yml rename to .github/workflows/release-clobber-stable.yml diff --git a/.github/workflows/tmp/release-srtool.yml b/.github/workflows/release-srtool.yml similarity index 100% rename from .github/workflows/tmp/release-srtool.yml rename to .github/workflows/release-srtool.yml diff --git a/.github/workflows/tmp/review-bot.yml b/.github/workflows/review-bot.yml similarity index 100% rename from .github/workflows/tmp/review-bot.yml rename to .github/workflows/review-bot.yml diff --git a/.github/workflows/tmp/review-trigger.yml b/.github/workflows/review-trigger.yml similarity index 100% rename from .github/workflows/tmp/review-trigger.yml rename to .github/workflows/review-trigger.yml diff --git a/.github/workflows/tmp/tests.yml b/.github/workflows/tests.yml similarity index 100% rename from .github/workflows/tmp/tests.yml rename to .github/workflows/tests.yml diff --git a/.github/workflows/tmp/check-semver.yml b/.github/workflows/tmp/check-semver.yml deleted file mode 100644 index 47f9e5061b4a..000000000000 --- a/.github/workflows/tmp/check-semver.yml +++ /dev/null @@ -1,58 +0,0 @@ -name: Check semver - -on: - pull_request: - types: [opened, synchronize, reopened, ready_for_review] - paths: - - prdoc/*.prdoc -env: - TOOLCHAIN: nightly-2024-03-01 - -jobs: - check-semver: - runs-on: ubuntu-latest - container: - image: docker.io/paritytech/ci-unified:bullseye-1.77.0-2024-04-10-v20240408 - steps: - - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 - - - name: Rust Cache - uses: Swatinem/rust-cache@23bce251a8cd2ffc3c1075eaa2367cf899916d84 # v2.7.3 - with: - cache-on-failure: true - - - name: install parity-publish - run: cargo install parity-publish@0.6.0 - - - name: Rust compilation prerequisites - run: | - rustup default $TOOLCHAIN - rustup target add wasm32-unknown-unknown --toolchain $TOOLCHAIN - rustup component add rust-src --toolchain $TOOLCHAIN - - - name: extra git setup - run: | - git config --global --add safe.directory '*' - git fetch --no-tags --no-recurse-submodules --depth=1 origin master - git branch old origin/master - - - name: check semver - run: | - export CARGO_TARGET_DIR=target - export RUSTFLAGS='-A warnings -A missing_docs' - export SKIP_WASM_BUILD=1 - if ! parity-publish --color always prdoc --since old --validate prdoc/pr_$PR.prdoc -v --toolchain $TOOLCHAIN; then - cat < Date: Mon, 15 Jul 2024 14:24:37 +0200 Subject: [PATCH 27/52] modify condition --- .github/workflows/tests-linux-stable.yml | 240 +++++------------------ 1 file changed, 53 insertions(+), 187 deletions(-) diff --git a/.github/workflows/tests-linux-stable.yml b/.github/workflows/tests-linux-stable.yml index 3e5eb3dfa504..7aa845f8deaa 100644 --- a/.github/workflows/tests-linux-stable.yml +++ b/.github/workflows/tests-linux-stable.yml @@ -33,130 +33,34 @@ jobs: - id: set_image run: cat .github/env >> $GITHUB_OUTPUT - # test-linux-stable-int: - # needs: [set-image, changes] - # if: ${{ needs.changes.outputs.rust }} - # runs-on: arc-runners-polkadot-sdk-beefy - # timeout-minutes: 60 - # container: - # image: ${{ needs.set-image.outputs.IMAGE }} - # env: - # RUSTFLAGS: "-C debug-assertions -D warnings" - # RUST_BACKTRACE: 1 - # WASM_BUILD_NO_COLOR: 1 - # WASM_BUILD_RUSTFLAGS: "-C debug-assertions -D warnings" - # # Ensure we run the UI tests. - # RUN_UI_TESTS: 1 - # steps: - # - name: Checkout - # uses: actions/checkout@v4 - # - name: script - # run: WASM_BUILD_NO_COLOR=1 time forklift cargo test -p staging-node-cli --release --locked -- --ignored - - # # https://github.com/paritytech/ci_cd/issues/864 - # test-linux-stable-runtime-benchmarks: - # needs: [set-image, changes] - # if: ${{ needs.changes.outputs.rust }} - # runs-on: arc-runners-polkadot-sdk-beefy - # timeout-minutes: 60 - # container: - # image: ${{ needs.set-image.outputs.IMAGE }} - # env: - # RUST_TOOLCHAIN: stable - # # Enable debug assertions since we are running optimized builds for testing - # # but still want to have debug assertions. - # RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings" - # steps: - # - name: Checkout - # uses: actions/checkout@v4 - # - name: script - # run: time forklift cargo nextest run --workspace --features runtime-benchmarks benchmark --locked --cargo-profile testnet - - # #todo: enable forklift - # test-linux-stable-oldkernel: - # needs: [set-image, changes] - # if: ${{ needs.changes.outputs.rust }} - # runs-on: oldlinux - # timeout-minutes: 60 - # strategy: - # fail-fast: false - # matrix: - # partition: [1/3, 2/3, 3/3] - # container: - # image: ${{ needs.set-image.outputs.IMAGE }} - # # needed for tests that use unshare syscall - # options: --security-opt seccomp=unconfined - # env: - # RUST_TOOLCHAIN: stable - # # Enable debug assertions since we are running optimized builds for testing - # # but still want to have debug assertions. - # RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings" - # steps: - # - name: Checkout - # uses: actions/checkout@v4 - # - name: script - # run: | - # # Fixes "detected dubious ownership" error in the ci - # git config --global --add safe.directory '*' - # time cargo nextest run \ - # --workspace \ - # --locked \ - # --release \ - # --no-fail-fast \ - # --features try-runtime,experimental,riscv,ci-only-tests \ - # --partition count:${{ matrix.partition }} - # # run runtime-api tests with `enable-staging-api` feature on the 1st node - # if [ "${{ matrix.partition }}" == "1/3" ]; then time cargo nextest run -p sp-api-test --features enable-staging-api; fi - - # #todo: enable forklift - # test-linux-stable: - # needs: [set-image, changes] - # if: ${{ needs.changes.outputs.rust }} - # runs-on: arc-runners-polkadot-sdk-beefy-ubuntu - # timeout-minutes: 60 - # strategy: - # fail-fast: false - # matrix: - # partition: [1/3, 2/3, 3/3] - # container: - # image: ${{ needs.set-image.outputs.IMAGE }} - # # needed for tests that use unshare syscall - # options: --security-opt seccomp=unconfined - # env: - # RUST_TOOLCHAIN: stable - # # Enable debug assertions since we are running optimized builds for testing - # # but still want to have debug assertions. - # RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings" - # steps: - # - name: Checkout - # uses: actions/checkout@v4 - # - name: script - # run: | - # # Fixes "detected dubious ownership" error in the ci - # git config --global --add safe.directory '*' - # time cargo nextest run \ - # --workspace \ - # --locked \ - # --release \ - # --no-fail-fast \ - # --features try-runtime,experimental,riscv,ci-only-tests \ - # --partition count:${{ matrix.partition }} - # # run runtime-api tests with `enable-staging-api` feature on the 1st node - # if [ "${{ matrix.partition }}" == "1/3" ]; then time cargo nextest run -p sp-api-test --features enable-staging-api; fi + test-linux-stable-int: + needs: [set-image, changes] + if: ${{ needs.changes.outputs.rust }} + runs-on: arc-runners-polkadot-sdk-beefy + timeout-minutes: 60 + container: + image: ${{ needs.set-image.outputs.IMAGE }} + env: + RUSTFLAGS: "-C debug-assertions -D warnings" + RUST_BACKTRACE: 1 + WASM_BUILD_NO_COLOR: 1 + WASM_BUILD_RUSTFLAGS: "-C debug-assertions -D warnings" + # Ensure we run the UI tests. + RUN_UI_TESTS: 1 + steps: + - name: Checkout + uses: actions/checkout@v4 + - name: script + run: WASM_BUILD_NO_COLOR=1 time forklift cargo test -p staging-node-cli --release --locked -- --ignored - test-linux-stable-oldkernel-fl: + # https://github.com/paritytech/ci_cd/issues/864 + test-linux-stable-runtime-benchmarks: needs: [set-image, changes] if: ${{ needs.changes.outputs.rust }} - runs-on: oldlinux + runs-on: arc-runners-polkadot-sdk-beefy timeout-minutes: 60 - strategy: - fail-fast: false - matrix: - partition: [1/3, 2/3, 3/3] container: image: ${{ needs.set-image.outputs.IMAGE }} - # needed for tests that use unshare syscall - options: --security-opt seccomp=unconfined env: RUST_TOOLCHAIN: stable # Enable debug assertions since we are running optimized builds for testing @@ -165,27 +69,13 @@ jobs: steps: - name: Checkout uses: actions/checkout@v4 - - name: update forklift - run: curl -o .forklift/forklift -L https://github.com/paritytech/forklift/releases/download/0.13.1-alpha/forklift_0.13.1-alpha_linux_amd64 - - run: chmod +x .forklift/forklift && .forklift/forklift version - name: script - run: | - # Fixes "detected dubious ownership" error in the ci - git config --global --add safe.directory '*' - .forklift/forklift cargo nextest run \ - --workspace \ - --locked \ - --release \ - --no-fail-fast \ - --features try-runtime,experimental,riscv,ci-only-tests \ - --partition count:${{ matrix.partition }} - # run runtime-api tests with `enable-staging-api` feature on the 1st node - if [ "${{ matrix.partition }}" == "1/3" ]; then time forklift cargo nextest run -p sp-api-test --features enable-staging-api; fi + run: time forklift cargo nextest run --workspace --features runtime-benchmarks benchmark --locked --cargo-profile testnet - test-linux-stable-fl: + test-linux-stable-oldkernel: needs: [set-image, changes] if: ${{ needs.changes.outputs.rust }} - runs-on: arc-runners-polkadot-sdk-beefy-ubuntu + runs-on: oldlinux timeout-minutes: 60 strategy: fail-fast: false @@ -203,9 +93,11 @@ jobs: steps: - name: Checkout uses: actions/checkout@v4 + # ------------ remove me after release ------------ - name: update forklift run: curl -o .forklift/forklift -L https://github.com/paritytech/forklift/releases/download/0.13.1-alpha/forklift_0.13.1-alpha_linux_amd64 - run: chmod +x .forklift/forklift && .forklift/forklift version + # ------------------------------------------------- - name: script run: | # Fixes "detected dubious ownership" error in the ci @@ -218,70 +110,44 @@ jobs: --features try-runtime,experimental,riscv,ci-only-tests \ --partition count:${{ matrix.partition }} # run runtime-api tests with `enable-staging-api` feature on the 1st node - if [ "${{ matrix.partition }}" == "1/3" ]; then time forklift cargo nextest run -p sp-api-test --features enable-staging-api; fi + if [ "${{ matrix.partition }}" = "1/3" ]; then + forklift cargo nextest run -p sp-api-test --features enable-staging-api + fi - # test-landlock: + # test-linux-stable-fl: # needs: [set-image, changes] # if: ${{ needs.changes.outputs.rust }} - # # runs-on: arc-runners-polkadot-sdk-beefy-ubuntu - # runs-on: ubuntu-latest + # runs-on: arc-runners-polkadot-sdk-beefy-ubuntu # timeout-minutes: 60 + # strategy: + # fail-fast: false + # matrix: + # partition: [1/3, 2/3, 3/3] # container: # image: ${{ needs.set-image.outputs.IMAGE }} + # # needed for tests that use unshare syscall # options: --security-opt seccomp=unconfined # env: # RUST_TOOLCHAIN: stable + # # Enable debug assertions since we are running optimized builds for testing + # # but still want to have debug assertions. # RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings" # steps: # - name: Checkout # uses: actions/checkout@v4 + # - name: update forklift + # run: curl -o .forklift/forklift -L https://github.com/paritytech/forklift/releases/download/0.13.1-alpha/forklift_0.13.1-alpha_linux_amd64 + # - run: chmod +x .forklift/forklift && .forklift/forklift version # - name: script # run: | - # SKIP_WASM_BUILD="1" cargo test -p polkadot-node-core-pvf all_security_features_work --features=ci-only-tests - - single-test: - needs: [set-image, changes] - if: ${{ needs.changes.outputs.rust }} - runs-on: arc-runners-polkadot-sdk-beefy - timeout-minutes: 60 - strategy: - fail-fast: false - matrix: - partition: [1, 2, 3, 4, 5] - container: - image: ${{ needs.set-image.outputs.IMAGE }} - env: - RUST_TOOLCHAIN: stable - # Enable debug assertions since we are running optimized builds for testing - # but still want to have debug assertions. - RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings" - steps: - - name: Checkout - uses: actions/checkout@v4 - - name: script - run: cargo test -p frame-metadata-hash-extension ensure_check_metadata_works_on_real_extrinsics - - single-test-fl: - needs: [set-image, changes] - if: ${{ needs.changes.outputs.rust }} - runs-on: arc-runners-polkadot-sdk-beefy - timeout-minutes: 60 - strategy: - fail-fast: false - matrix: - partition: [1, 2, 3, 4, 5] - container: - image: ${{ needs.set-image.outputs.IMAGE }} - env: - RUST_TOOLCHAIN: stable - # Enable debug assertions since we are running optimized builds for testing - # but still want to have debug assertions. - RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings" - steps: - - name: Checkout - uses: actions/checkout@v4 - - name: update forklift - run: curl -o .forklift/forklift -L https://github.com/paritytech/forklift/releases/download/0.13.1-alpha/forklift_0.13.1-alpha_linux_amd64 - - run: chmod +x .forklift/forklift && .forklift/forklift version - - name: script - run: time ./.forklift/forklift cargo test -p frame-metadata-hash-extension ensure_check_metadata_works_on_real_extrinsics + # # Fixes "detected dubious ownership" error in the ci + # git config --global --add safe.directory '*' + # .forklift/forklift cargo nextest run \ + # --workspace \ + # --locked \ + # --release \ + # --no-fail-fast \ + # --features try-runtime,experimental,riscv,ci-only-tests \ + # --partition count:${{ matrix.partition }} + # # run runtime-api tests with `enable-staging-api` feature on the 1st node + # if [ "${{ matrix.partition }}" == "1/3" ]; then time forklift cargo nextest run -p sp-api-test --features enable-staging-api; fi From e6b3a3d94aae07384ae8bb6ee3fe8d939c9fef05 Mon Sep 17 00:00:00 2001 From: alvicsam Date: Mon, 15 Jul 2024 14:29:31 +0200 Subject: [PATCH 28/52] rm leftovers --- .forklift/config-gitlab.toml | 2 +- .github/workflows/tests-linux-stable.yml | 38 ------------------------ .gitlab/pipeline/test.yml | 17 ----------- 3 files changed, 1 insertion(+), 56 deletions(-) diff --git a/.forklift/config-gitlab.toml b/.forklift/config-gitlab.toml index cda1028718fc..ab3b2729a46d 100644 --- a/.forklift/config-gitlab.toml +++ b/.forklift/config-gitlab.toml @@ -7,7 +7,7 @@ compressionLevel = 3 [general] jobNameVariable = "CI_JOB_NAME" jobsBlackList = [] -logLevel = "trace" +logLevel = "warn" threadsCount = 6 [cache] diff --git a/.github/workflows/tests-linux-stable.yml b/.github/workflows/tests-linux-stable.yml index 7aa845f8deaa..c5272abdab1f 100644 --- a/.github/workflows/tests-linux-stable.yml +++ b/.github/workflows/tests-linux-stable.yml @@ -113,41 +113,3 @@ jobs: if [ "${{ matrix.partition }}" = "1/3" ]; then forklift cargo nextest run -p sp-api-test --features enable-staging-api fi - - # test-linux-stable-fl: - # needs: [set-image, changes] - # if: ${{ needs.changes.outputs.rust }} - # runs-on: arc-runners-polkadot-sdk-beefy-ubuntu - # timeout-minutes: 60 - # strategy: - # fail-fast: false - # matrix: - # partition: [1/3, 2/3, 3/3] - # container: - # image: ${{ needs.set-image.outputs.IMAGE }} - # # needed for tests that use unshare syscall - # options: --security-opt seccomp=unconfined - # env: - # RUST_TOOLCHAIN: stable - # # Enable debug assertions since we are running optimized builds for testing - # # but still want to have debug assertions. - # RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings" - # steps: - # - name: Checkout - # uses: actions/checkout@v4 - # - name: update forklift - # run: curl -o .forklift/forklift -L https://github.com/paritytech/forklift/releases/download/0.13.1-alpha/forklift_0.13.1-alpha_linux_amd64 - # - run: chmod +x .forklift/forklift && .forklift/forklift version - # - name: script - # run: | - # # Fixes "detected dubious ownership" error in the ci - # git config --global --add safe.directory '*' - # .forklift/forklift cargo nextest run \ - # --workspace \ - # --locked \ - # --release \ - # --no-fail-fast \ - # --features try-runtime,experimental,riscv,ci-only-tests \ - # --partition count:${{ matrix.partition }} - # # run runtime-api tests with `enable-staging-api` feature on the 1st node - # if [ "${{ matrix.partition }}" == "1/3" ]; then time forklift cargo nextest run -p sp-api-test --features enable-staging-api; fi diff --git a/.gitlab/pipeline/test.yml b/.gitlab/pipeline/test.yml index a7e46f545c9b..bd294dc62412 100644 --- a/.gitlab/pipeline/test.yml +++ b/.gitlab/pipeline/test.yml @@ -110,23 +110,6 @@ test-linux-stable-codecov: codecovcli -v do-upload -f target/coverage/result/report-${CI_NODE_INDEX}.lcov --disable-search -t ${CODECOV_TOKEN} -r paritytech/polkadot-sdk --commit-sha ${CI_COMMIT_SHA} --fail-on-error --git-service github; fi - # -single-test-fl: - stage: test - extends: - - .docker-env - - .common-refs - - .run-immediately - # - .pipeline-stopper-artifacts - variables: - RUST_TOOLCHAIN: stable - # Enable debug assertions since we are running optimized builds for testing - # but still want to have debug assertions. - RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings" - parallel: 5 - script: - - cargo test -p frame-metadata-hash-extension ensure_check_metadata_works_on_real_extrinsics - test-linux-stable: stage: test extends: From 5fd9ef155ebaa0ea0bdf6d0f346184238d929ccc Mon Sep 17 00:00:00 2001 From: alvicsam Date: Mon, 15 Jul 2024 15:40:52 +0200 Subject: [PATCH 29/52] disable forklift --- .github/workflows/tests-linux-stable.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/tests-linux-stable.yml b/.github/workflows/tests-linux-stable.yml index c5272abdab1f..93df32e53ca7 100644 --- a/.github/workflows/tests-linux-stable.yml +++ b/.github/workflows/tests-linux-stable.yml @@ -102,7 +102,8 @@ jobs: run: | # Fixes "detected dubious ownership" error in the ci git config --global --add safe.directory '*' - .forklift/forklift cargo nextest run \ + # .forklift/forklift cargo nextest run \ + cargo nextest run \ --workspace \ --locked \ --release \ From f812e5a4803620ce7e9a6408030ad3923445d2bf Mon Sep 17 00:00:00 2001 From: alvicsam Date: Mon, 15 Jul 2024 16:44:53 +0200 Subject: [PATCH 30/52] move forklift back --- .github/workflows/tests-linux-stable.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/tests-linux-stable.yml b/.github/workflows/tests-linux-stable.yml index 93df32e53ca7..c5272abdab1f 100644 --- a/.github/workflows/tests-linux-stable.yml +++ b/.github/workflows/tests-linux-stable.yml @@ -102,8 +102,7 @@ jobs: run: | # Fixes "detected dubious ownership" error in the ci git config --global --add safe.directory '*' - # .forklift/forklift cargo nextest run \ - cargo nextest run \ + .forklift/forklift cargo nextest run \ --workspace \ --locked \ --release \ From 142a74cb9282aec8dd9f25fd5bbe4de6593f9735 Mon Sep 17 00:00:00 2001 From: alvicsam Date: Mon, 15 Jul 2024 23:18:57 +0200 Subject: [PATCH 31/52] try fl 0.13.2 --- .github/workflows/tests-linux-stable.yml | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/.github/workflows/tests-linux-stable.yml b/.github/workflows/tests-linux-stable.yml index c5272abdab1f..e9700b596bb0 100644 --- a/.github/workflows/tests-linux-stable.yml +++ b/.github/workflows/tests-linux-stable.yml @@ -50,8 +50,13 @@ jobs: steps: - name: Checkout uses: actions/checkout@v4 + # ------------ remove me after release ------------ + - name: update forklift + run: curl -o .forklift/forklift -L https://github.com/paritytech/forklift/releases/download/0.13.2/forklift_0.13.2_linux_amd64 + - run: chmod +x .forklift/forklift && .forklift/forklift version + # ------------------------------------------------- - name: script - run: WASM_BUILD_NO_COLOR=1 time forklift cargo test -p staging-node-cli --release --locked -- --ignored + run: WASM_BUILD_NO_COLOR=1 .forklift/forklift cargo test -p staging-node-cli --release --locked -- --ignored # https://github.com/paritytech/ci_cd/issues/864 test-linux-stable-runtime-benchmarks: @@ -69,8 +74,13 @@ jobs: steps: - name: Checkout uses: actions/checkout@v4 + # ------------ remove me after release ------------ + - name: update forklift + run: curl -o .forklift/forklift -L https://github.com/paritytech/forklift/releases/download/0.13.2/forklift_0.13.2_linux_amd64 + - run: chmod +x .forklift/forklift && .forklift/forklift version + # ------------------------------------------------- - name: script - run: time forklift cargo nextest run --workspace --features runtime-benchmarks benchmark --locked --cargo-profile testnet + run: .forklift/forklift cargo nextest run --workspace --features runtime-benchmarks benchmark --locked --cargo-profile testnet test-linux-stable-oldkernel: needs: [set-image, changes] @@ -95,7 +105,7 @@ jobs: uses: actions/checkout@v4 # ------------ remove me after release ------------ - name: update forklift - run: curl -o .forklift/forklift -L https://github.com/paritytech/forklift/releases/download/0.13.1-alpha/forklift_0.13.1-alpha_linux_amd64 + run: curl -o .forklift/forklift -L https://github.com/paritytech/forklift/releases/download/0.13.2/forklift_0.13.2_linux_amd64 - run: chmod +x .forklift/forklift && .forklift/forklift version # ------------------------------------------------- - name: script From 82954bbd8ddfa05c48799b675a5ed9c5f06ebbf5 Mon Sep 17 00:00:00 2001 From: alvicsam Date: Tue, 16 Jul 2024 11:22:56 +0200 Subject: [PATCH 32/52] rm test forklift, modify condition --- .github/workflows/tests-linux-stable.yml | 29 ++++++------------------ 1 file changed, 7 insertions(+), 22 deletions(-) diff --git a/.github/workflows/tests-linux-stable.yml b/.github/workflows/tests-linux-stable.yml index e9700b596bb0..859beacf349a 100644 --- a/.github/workflows/tests-linux-stable.yml +++ b/.github/workflows/tests-linux-stable.yml @@ -50,13 +50,8 @@ jobs: steps: - name: Checkout uses: actions/checkout@v4 - # ------------ remove me after release ------------ - - name: update forklift - run: curl -o .forklift/forklift -L https://github.com/paritytech/forklift/releases/download/0.13.2/forklift_0.13.2_linux_amd64 - - run: chmod +x .forklift/forklift && .forklift/forklift version - # ------------------------------------------------- - name: script - run: WASM_BUILD_NO_COLOR=1 .forklift/forklift cargo test -p staging-node-cli --release --locked -- --ignored + run: WASM_BUILD_NO_COLOR=1 forklift cargo test -p staging-node-cli --release --locked -- --ignored # https://github.com/paritytech/ci_cd/issues/864 test-linux-stable-runtime-benchmarks: @@ -74,13 +69,8 @@ jobs: steps: - name: Checkout uses: actions/checkout@v4 - # ------------ remove me after release ------------ - - name: update forklift - run: curl -o .forklift/forklift -L https://github.com/paritytech/forklift/releases/download/0.13.2/forklift_0.13.2_linux_amd64 - - run: chmod +x .forklift/forklift && .forklift/forklift version - # ------------------------------------------------- - name: script - run: .forklift/forklift cargo nextest run --workspace --features runtime-benchmarks benchmark --locked --cargo-profile testnet + run: forklift cargo nextest run --workspace --features runtime-benchmarks benchmark --locked --cargo-profile testnet test-linux-stable-oldkernel: needs: [set-image, changes] @@ -103,23 +93,18 @@ jobs: steps: - name: Checkout uses: actions/checkout@v4 - # ------------ remove me after release ------------ - - name: update forklift - run: curl -o .forklift/forklift -L https://github.com/paritytech/forklift/releases/download/0.13.2/forklift_0.13.2_linux_amd64 - - run: chmod +x .forklift/forklift && .forklift/forklift version - # ------------------------------------------------- - name: script run: | # Fixes "detected dubious ownership" error in the ci git config --global --add safe.directory '*' - .forklift/forklift cargo nextest run \ + forklift cargo nextest run \ --workspace \ --locked \ --release \ --no-fail-fast \ --features try-runtime,experimental,riscv,ci-only-tests \ --partition count:${{ matrix.partition }} - # run runtime-api tests with `enable-staging-api` feature on the 1st node - if [ "${{ matrix.partition }}" = "1/3" ]; then - forklift cargo nextest run -p sp-api-test --features enable-staging-api - fi + # run runtime-api tests with `enable-staging-api` feature on the 1st node + - name: runtime-api tests + if: ${{ matrix.partition }} == '1/3' + run: forklift cargo nextest run -p sp-api-test --features enable-staging-api From 1410c0e31bb59cbd3067e336e68a0f0bfbc039ef Mon Sep 17 00:00:00 2001 From: alvicsam Date: Tue, 16 Jul 2024 11:33:26 +0200 Subject: [PATCH 33/52] use update ci image --- .github/env | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/env b/.github/env index 162ce8af7c0d..7c61bbc2a9a6 100644 --- a/.github/env +++ b/.github/env @@ -1 +1 @@ -IMAGE="docker.io/paritytech/ci-unified:bullseye-1.77.0-2024-04-10-v20240408" \ No newline at end of file +IMAGE="docker.io/paritytech/ci-unified:bullseye-1.77.0-2024-04-10-v202407161314" \ No newline at end of file From 91bac5cf021f6b8beb032435c54f3fe2b3187165 Mon Sep 17 00:00:00 2001 From: alvicsam Date: Tue, 16 Jul 2024 11:36:24 +0200 Subject: [PATCH 34/52] test new image in gitlab --- .gitlab-ci.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 7f2babc6bd47..a3ff69151007 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -21,7 +21,8 @@ workflow: - if: $CI_COMMIT_BRANCH variables: - CI_IMAGE: !reference [.ci-unified, variables, CI_IMAGE] + # CI_IMAGE: !reference [.ci-unified, variables, CI_IMAGE] + CI_IMAGE: "docker.io/paritytech/ci-unified:bullseye-1.77.0-2024-04-10-v202407161314" # BUILDAH_IMAGE is defined in group variables BUILDAH_COMMAND: "buildah --storage-driver overlay2" RELENG_SCRIPTS_BRANCH: "master" From 995ff931d2785d16df585ec37c94b2caf750039d Mon Sep 17 00:00:00 2001 From: alvicsam Date: Tue, 16 Jul 2024 12:35:26 +0200 Subject: [PATCH 35/52] upd version --- .github/env | 2 +- .gitlab-ci.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/env b/.github/env index 7c61bbc2a9a6..bd64bdfdb91f 100644 --- a/.github/env +++ b/.github/env @@ -1 +1 @@ -IMAGE="docker.io/paritytech/ci-unified:bullseye-1.77.0-2024-04-10-v202407161314" \ No newline at end of file +IMAGE="docker.io/paritytech/ci-unified:bullseye-1.77.0-2024-04-10-v202407161425" \ No newline at end of file diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index a3ff69151007..e15d2db766f4 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -22,7 +22,7 @@ workflow: variables: # CI_IMAGE: !reference [.ci-unified, variables, CI_IMAGE] - CI_IMAGE: "docker.io/paritytech/ci-unified:bullseye-1.77.0-2024-04-10-v202407161314" + CI_IMAGE: "docker.io/paritytech/ci-unified:bullseye-1.77.0-2024-04-10-v202407161425" # BUILDAH_IMAGE is defined in group variables BUILDAH_COMMAND: "buildah --storage-driver overlay2" RELENG_SCRIPTS_BRANCH: "master" From d40062b23b91aba3cef41084b595b7739e8b8df0 Mon Sep 17 00:00:00 2001 From: alvicsam Date: Tue, 16 Jul 2024 13:15:13 +0200 Subject: [PATCH 36/52] upd --- .github/env | 2 +- .gitlab-ci.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/env b/.github/env index bd64bdfdb91f..9f7108cebc1d 100644 --- a/.github/env +++ b/.github/env @@ -1 +1 @@ -IMAGE="docker.io/paritytech/ci-unified:bullseye-1.77.0-2024-04-10-v202407161425" \ No newline at end of file +IMAGE="docker.io/paritytech/ci-unified:bullseye-1.77.0-2024-04-10-v202407161507" \ No newline at end of file diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index e15d2db766f4..bf91d74ef845 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -22,7 +22,7 @@ workflow: variables: # CI_IMAGE: !reference [.ci-unified, variables, CI_IMAGE] - CI_IMAGE: "docker.io/paritytech/ci-unified:bullseye-1.77.0-2024-04-10-v202407161425" + CI_IMAGE: "docker.io/paritytech/ci-unified:bullseye-1.77.0-2024-04-10-v202407161507" # BUILDAH_IMAGE is defined in group variables BUILDAH_COMMAND: "buildah --storage-driver overlay2" RELENG_SCRIPTS_BRANCH: "master" From f34343dcd2b85a7820523de82440c93f358f3847 Mon Sep 17 00:00:00 2001 From: alvicsam Date: Tue, 16 Jul 2024 17:23:35 +0200 Subject: [PATCH 37/52] Empty commit to trigger ci From fcad0536b11f0b40ec1e28bf03313fdcb11efb3f Mon Sep 17 00:00:00 2001 From: alvicsam Date: Wed, 17 Jul 2024 10:52:13 +0200 Subject: [PATCH 38/52] run test without fl --- .github/workflows/tests-linux-stable.yml | 29 ++++++++++++++++++++++++ 1 file changed, 29 insertions(+) diff --git a/.github/workflows/tests-linux-stable.yml b/.github/workflows/tests-linux-stable.yml index 859beacf349a..1434b06128bf 100644 --- a/.github/workflows/tests-linux-stable.yml +++ b/.github/workflows/tests-linux-stable.yml @@ -108,3 +108,32 @@ jobs: - name: runtime-api tests if: ${{ matrix.partition }} == '1/3' run: forklift cargo nextest run -p sp-api-test --features enable-staging-api + + test-linux-stable-oldkernel-wo-fl: + needs: [set-image, changes] + if: ${{ needs.changes.outputs.rust }} + runs-on: oldlinux + timeout-minutes: 60 + container: + image: ${{ needs.set-image.outputs.IMAGE }} + # needed for tests that use unshare syscall + options: --security-opt seccomp=unconfined + env: + RUST_TOOLCHAIN: stable + # Enable debug assertions since we are running optimized builds for testing + # but still want to have debug assertions. + RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings" + steps: + - name: Checkout + uses: actions/checkout@v4 + - name: script + run: | + # Fixes "detected dubious ownership" error in the ci + git config --global --add safe.directory '*' + cargo nextest run \ + --workspace \ + --locked \ + --release \ + --no-fail-fast \ + --features try-runtime,experimental,riscv,ci-only-tests \ + --partition count:1/3 From d35f7bb63bd461439ec195f6d81afc5ddfcfd542 Mon Sep 17 00:00:00 2001 From: alvicsam Date: Wed, 17 Jul 2024 10:54:52 +0200 Subject: [PATCH 39/52] test one test separately --- .github/workflows/tests-linux-stable.yml | 40 ++++++++++++++++++++++++ 1 file changed, 40 insertions(+) diff --git a/.github/workflows/tests-linux-stable.yml b/.github/workflows/tests-linux-stable.yml index 1434b06128bf..1359bb1db358 100644 --- a/.github/workflows/tests-linux-stable.yml +++ b/.github/workflows/tests-linux-stable.yml @@ -137,3 +137,43 @@ jobs: --no-fail-fast \ --features try-runtime,experimental,riscv,ci-only-tests \ --partition count:1/3 + + test-pvf: + needs: [set-image, changes] + if: ${{ needs.changes.outputs.rust }} + runs-on: oldlinux + timeout-minutes: 60 + container: + image: ${{ needs.set-image.outputs.IMAGE }} + # needed for tests that use unshare syscall + options: --security-opt seccomp=unconfined + env: + RUST_TOOLCHAIN: stable + # Enable debug assertions since we are running optimized builds for testing + # but still want to have debug assertions. + RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings" + steps: + - name: Checkout + uses: actions/checkout@v4 + - name: script + run: cargo test -p polkadot-node-core-pvf artifact_does_not_reprepare_on_non_meaningful_exec_parameter_change --features=ci-only-tests + + test-pvf-fl: + needs: [set-image, changes] + if: ${{ needs.changes.outputs.rust }} + runs-on: oldlinux + timeout-minutes: 60 + container: + image: ${{ needs.set-image.outputs.IMAGE }} + # needed for tests that use unshare syscall + options: --security-opt seccomp=unconfined + env: + RUST_TOOLCHAIN: stable + # Enable debug assertions since we are running optimized builds for testing + # but still want to have debug assertions. + RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings" + steps: + - name: Checkout + uses: actions/checkout@v4 + - name: script + run: forklift cargo test -p polkadot-node-core-pvf artifact_does_not_reprepare_on_non_meaningful_exec_parameter_change --features=ci-only-tests From e29672c9cc6cf5c2e5a56df8d3af77aadfa0df9d Mon Sep 17 00:00:00 2001 From: alvicsam Date: Wed, 17 Jul 2024 10:59:31 +0200 Subject: [PATCH 40/52] use default image --- .gitlab-ci.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index bf91d74ef845..7f2babc6bd47 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -21,8 +21,7 @@ workflow: - if: $CI_COMMIT_BRANCH variables: - # CI_IMAGE: !reference [.ci-unified, variables, CI_IMAGE] - CI_IMAGE: "docker.io/paritytech/ci-unified:bullseye-1.77.0-2024-04-10-v202407161507" + CI_IMAGE: !reference [.ci-unified, variables, CI_IMAGE] # BUILDAH_IMAGE is defined in group variables BUILDAH_COMMAND: "buildah --storage-driver overlay2" RELENG_SCRIPTS_BRANCH: "master" From 67c8602213517634550573ca440741be1c5350ff Mon Sep 17 00:00:00 2001 From: alvicsam Date: Wed, 17 Jul 2024 12:03:29 +0200 Subject: [PATCH 41/52] run test on beefy --- .github/workflows/tests-linux-stable.yml | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/.github/workflows/tests-linux-stable.yml b/.github/workflows/tests-linux-stable.yml index 1359bb1db358..5e21296d5e83 100644 --- a/.github/workflows/tests-linux-stable.yml +++ b/.github/workflows/tests-linux-stable.yml @@ -177,3 +177,23 @@ jobs: uses: actions/checkout@v4 - name: script run: forklift cargo test -p polkadot-node-core-pvf artifact_does_not_reprepare_on_non_meaningful_exec_parameter_change --features=ci-only-tests + + test-pvf-fl-beefy: + needs: [set-image, changes] + if: ${{ needs.changes.outputs.rust }} + runs-on: arc-runners-polkadot-sdk-beefy + timeout-minutes: 60 + container: + image: ${{ needs.set-image.outputs.IMAGE }} + # needed for tests that use unshare syscall + options: --security-opt seccomp=unconfined + env: + RUST_TOOLCHAIN: stable + # Enable debug assertions since we are running optimized builds for testing + # but still want to have debug assertions. + RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings" + steps: + - name: Checkout + uses: actions/checkout@v4 + - name: script + run: forklift cargo test -p polkadot-node-core-pvf artifact_does_not_reprepare_on_non_meaningful_exec_parameter_change --features=ci-only-tests From 07710cfd3c292659fbd8141efd6c7bb868a954a7 Mon Sep 17 00:00:00 2001 From: alvicsam Date: Thu, 18 Jul 2024 12:44:30 +0200 Subject: [PATCH 42/52] new ci image --- .github/env | 2 +- .github/workflows/tests-linux-stable.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/env b/.github/env index 2e4d5b48100d..9f7108cebc1d 100644 --- a/.github/env +++ b/.github/env @@ -1 +1 @@ -IMAGE="docker.io/paritytech/ci-unified:bullseye-1.77.0-2024-04-10-v202407161507" +IMAGE="docker.io/paritytech/ci-unified:bullseye-1.77.0-2024-04-10-v202407161507" \ No newline at end of file diff --git a/.github/workflows/tests-linux-stable.yml b/.github/workflows/tests-linux-stable.yml index 5e21296d5e83..9ba985ef8ea0 100644 --- a/.github/workflows/tests-linux-stable.yml +++ b/.github/workflows/tests-linux-stable.yml @@ -106,7 +106,7 @@ jobs: --partition count:${{ matrix.partition }} # run runtime-api tests with `enable-staging-api` feature on the 1st node - name: runtime-api tests - if: ${{ matrix.partition }} == '1/3' + if: ${{ matrix.partition == '1/3' }} run: forklift cargo nextest run -p sp-api-test --features enable-staging-api test-linux-stable-oldkernel-wo-fl: From 57a8ad2606496a8c123e4dd601c761f6a61c5693 Mon Sep 17 00:00:00 2001 From: alvicsam Date: Thu, 18 Jul 2024 13:55:29 +0200 Subject: [PATCH 43/52] Empty commit to trigger ci From 3b0be2693102ac031badecfed044941068c8453f Mon Sep 17 00:00:00 2001 From: alvicsam Date: Thu, 18 Jul 2024 13:58:33 +0200 Subject: [PATCH 44/52] rm test jobs --- .github/workflows/tests-linux-stable.yml | 89 ------------------------ 1 file changed, 89 deletions(-) diff --git a/.github/workflows/tests-linux-stable.yml b/.github/workflows/tests-linux-stable.yml index 9ba985ef8ea0..ccff1b314ffd 100644 --- a/.github/workflows/tests-linux-stable.yml +++ b/.github/workflows/tests-linux-stable.yml @@ -108,92 +108,3 @@ jobs: - name: runtime-api tests if: ${{ matrix.partition == '1/3' }} run: forklift cargo nextest run -p sp-api-test --features enable-staging-api - - test-linux-stable-oldkernel-wo-fl: - needs: [set-image, changes] - if: ${{ needs.changes.outputs.rust }} - runs-on: oldlinux - timeout-minutes: 60 - container: - image: ${{ needs.set-image.outputs.IMAGE }} - # needed for tests that use unshare syscall - options: --security-opt seccomp=unconfined - env: - RUST_TOOLCHAIN: stable - # Enable debug assertions since we are running optimized builds for testing - # but still want to have debug assertions. - RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings" - steps: - - name: Checkout - uses: actions/checkout@v4 - - name: script - run: | - # Fixes "detected dubious ownership" error in the ci - git config --global --add safe.directory '*' - cargo nextest run \ - --workspace \ - --locked \ - --release \ - --no-fail-fast \ - --features try-runtime,experimental,riscv,ci-only-tests \ - --partition count:1/3 - - test-pvf: - needs: [set-image, changes] - if: ${{ needs.changes.outputs.rust }} - runs-on: oldlinux - timeout-minutes: 60 - container: - image: ${{ needs.set-image.outputs.IMAGE }} - # needed for tests that use unshare syscall - options: --security-opt seccomp=unconfined - env: - RUST_TOOLCHAIN: stable - # Enable debug assertions since we are running optimized builds for testing - # but still want to have debug assertions. - RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings" - steps: - - name: Checkout - uses: actions/checkout@v4 - - name: script - run: cargo test -p polkadot-node-core-pvf artifact_does_not_reprepare_on_non_meaningful_exec_parameter_change --features=ci-only-tests - - test-pvf-fl: - needs: [set-image, changes] - if: ${{ needs.changes.outputs.rust }} - runs-on: oldlinux - timeout-minutes: 60 - container: - image: ${{ needs.set-image.outputs.IMAGE }} - # needed for tests that use unshare syscall - options: --security-opt seccomp=unconfined - env: - RUST_TOOLCHAIN: stable - # Enable debug assertions since we are running optimized builds for testing - # but still want to have debug assertions. - RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings" - steps: - - name: Checkout - uses: actions/checkout@v4 - - name: script - run: forklift cargo test -p polkadot-node-core-pvf artifact_does_not_reprepare_on_non_meaningful_exec_parameter_change --features=ci-only-tests - - test-pvf-fl-beefy: - needs: [set-image, changes] - if: ${{ needs.changes.outputs.rust }} - runs-on: arc-runners-polkadot-sdk-beefy - timeout-minutes: 60 - container: - image: ${{ needs.set-image.outputs.IMAGE }} - # needed for tests that use unshare syscall - options: --security-opt seccomp=unconfined - env: - RUST_TOOLCHAIN: stable - # Enable debug assertions since we are running optimized builds for testing - # but still want to have debug assertions. - RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings" - steps: - - name: Checkout - uses: actions/checkout@v4 - - name: script - run: forklift cargo test -p polkadot-node-core-pvf artifact_does_not_reprepare_on_non_meaningful_exec_parameter_change --features=ci-only-tests From fa3d21e7de3491d12e4fafe9a581f886c1680ca9 Mon Sep 17 00:00:00 2001 From: alvicsam Date: Fri, 19 Jul 2024 09:47:12 +0200 Subject: [PATCH 45/52] add test-linux-stable, add final step --- .github/workflows/tests-linux-stable.yml | 50 ++++++++++++++++++++++++ 1 file changed, 50 insertions(+) diff --git a/.github/workflows/tests-linux-stable.yml b/.github/workflows/tests-linux-stable.yml index ccff1b314ffd..c499d7c9e557 100644 --- a/.github/workflows/tests-linux-stable.yml +++ b/.github/workflows/tests-linux-stable.yml @@ -72,6 +72,43 @@ jobs: - name: script run: forklift cargo nextest run --workspace --features runtime-benchmarks benchmark --locked --cargo-profile testnet + test-linux-stable: + needs: [set-image, changes] + if: ${{ needs.changes.outputs.rust }} + runs-on: arc-runners-polkadot-sdk-beefy + timeout-minutes: 60 + strategy: + fail-fast: false + matrix: + partition: [1/3, 2/3, 3/3] + container: + image: ${{ needs.set-image.outputs.IMAGE }} + # needed for tests that use unshare syscall + options: --security-opt seccomp=unconfined + env: + RUST_TOOLCHAIN: stable + # Enable debug assertions since we are running optimized builds for testing + # but still want to have debug assertions. + RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings" + steps: + - name: Checkout + uses: actions/checkout@v4 + - name: script + run: | + # Fixes "detected dubious ownership" error in the ci + git config --global --add safe.directory '*' + forklift cargo nextest run \ + --workspace \ + --locked \ + --release \ + --no-fail-fast \ + --features try-runtime,experimental,riscv,ci-only-tests \ + --partition count:${{ matrix.partition }} + # run runtime-api tests with `enable-staging-api` feature on the 1st node + - name: runtime-api tests + if: ${{ matrix.partition == '1/3' }} + run: forklift cargo nextest run -p sp-api-test --features enable-staging-api + test-linux-stable-oldkernel: needs: [set-image, changes] if: ${{ needs.changes.outputs.rust }} @@ -108,3 +145,16 @@ jobs: - name: runtime-api tests if: ${{ matrix.partition == '1/3' }} run: forklift cargo nextest run -p sp-api-test --features enable-staging-api + confirm-required-jobs-passed: + runs-on: ubuntu-latest + name: All migrations passed + # If any new job gets added, be sure to add it to this array + needs: + [ + test-linux-stable-int, + test-linux-stable-runtime-benchmarks, + test-linux-stable, + test-linux-stable-oldkernel, + ] + steps: + - run: echo '### Good job! All the tests passed 🚀' >> $GITHUB_STEP_SUMMARY From 0e9dc3faa9f7273e3f760d86730835fa45191f57 Mon Sep 17 00:00:00 2001 From: alvicsam Date: Fri, 19 Jul 2024 10:20:15 +0200 Subject: [PATCH 46/52] rename final job --- .github/workflows/tests-linux-stable.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/tests-linux-stable.yml b/.github/workflows/tests-linux-stable.yml index c499d7c9e557..1a67e24f5cd4 100644 --- a/.github/workflows/tests-linux-stable.yml +++ b/.github/workflows/tests-linux-stable.yml @@ -145,9 +145,10 @@ jobs: - name: runtime-api tests if: ${{ matrix.partition == '1/3' }} run: forklift cargo nextest run -p sp-api-test --features enable-staging-api + confirm-required-jobs-passed: runs-on: ubuntu-latest - name: All migrations passed + name: All tests passed # If any new job gets added, be sure to add it to this array needs: [ From 0e98cb3f12edb0e48b4d9e96a71a99a9564db99d Mon Sep 17 00:00:00 2001 From: alvicsam Date: Thu, 8 Aug 2024 15:08:45 +0200 Subject: [PATCH 47/52] add label to run ci --- .github/workflows/tests-linux-stable.yml | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/.github/workflows/tests-linux-stable.yml b/.github/workflows/tests-linux-stable.yml index 7931a4785803..ec28e49c767f 100644 --- a/.github/workflows/tests-linux-stable.yml +++ b/.github/workflows/tests-linux-stable.yml @@ -6,7 +6,7 @@ on: branches: - master pull_request: - types: [ opened, synchronize, reopened, ready_for_review ] + types: [opened, synchronize, reopened, ready_for_review] merge_group: concurrency: group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} @@ -14,6 +14,8 @@ concurrency: jobs: changes: + # TODO: remove once migration is complete or this workflow is fully stable + if: contains(github.event.label.name, 'GHA-migration') permissions: pull-requests: read uses: ./.github/workflows/reusable-check-changed-files.yml @@ -34,7 +36,7 @@ jobs: run: cat .github/env >> $GITHUB_OUTPUT test-linux-stable-int: - needs: [ set-image, changes ] + needs: [set-image, changes] if: ${{ needs.changes.outputs.rust }} runs-on: arc-runners-polkadot-sdk-beefy timeout-minutes: 60 @@ -55,7 +57,7 @@ jobs: # https://github.com/paritytech/ci_cd/issues/864 test-linux-stable-runtime-benchmarks: - needs: [ set-image, changes ] + needs: [set-image, changes] if: ${{ needs.changes.outputs.rust }} runs-on: arc-runners-polkadot-sdk-beefy timeout-minutes: 60 From fa8caead6b5406c6f08c4d3883f74566297bf6ca Mon Sep 17 00:00:00 2001 From: alvicsam Date: Thu, 8 Aug 2024 15:09:16 +0200 Subject: [PATCH 48/52] return nl --- .github/env | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/env b/.github/env index 9f7108cebc1d..2e4d5b48100d 100644 --- a/.github/env +++ b/.github/env @@ -1 +1 @@ -IMAGE="docker.io/paritytech/ci-unified:bullseye-1.77.0-2024-04-10-v202407161507" \ No newline at end of file +IMAGE="docker.io/paritytech/ci-unified:bullseye-1.77.0-2024-04-10-v202407161507" From 66e1c31bebac0785c8f9b87b528e4cc2052c93a0 Mon Sep 17 00:00:00 2001 From: Alexander Samusev <41779041+alvicsam@users.noreply.github.com> Date: Thu, 8 Aug 2024 15:22:32 +0200 Subject: [PATCH 49/52] Update .github/workflows/tests-linux-stable.yml Co-authored-by: Maksym H <1177472+mordamax@users.noreply.github.com> --- .github/workflows/tests-linux-stable.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tests-linux-stable.yml b/.github/workflows/tests-linux-stable.yml index ec28e49c767f..87b6e4819ab2 100644 --- a/.github/workflows/tests-linux-stable.yml +++ b/.github/workflows/tests-linux-stable.yml @@ -6,7 +6,7 @@ on: branches: - master pull_request: - types: [opened, synchronize, reopened, ready_for_review] + types: [opened, synchronize, reopened, ready_for_review, labeled] merge_group: concurrency: group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} From 927a60df7b6d13dbb7f1dd1ba15d9f89719aee9d Mon Sep 17 00:00:00 2001 From: alvicsam Date: Thu, 8 Aug 2024 15:40:13 +0200 Subject: [PATCH 50/52] move runner type to matrix --- .github/workflows/tests-linux-stable.yml | 41 ++---------------------- 1 file changed, 2 insertions(+), 39 deletions(-) diff --git a/.github/workflows/tests-linux-stable.yml b/.github/workflows/tests-linux-stable.yml index 87b6e4819ab2..4a13f5318f7d 100644 --- a/.github/workflows/tests-linux-stable.yml +++ b/.github/workflows/tests-linux-stable.yml @@ -77,49 +77,13 @@ jobs: test-linux-stable: needs: [set-image, changes] if: ${{ needs.changes.outputs.rust }} - runs-on: arc-runners-polkadot-sdk-beefy - timeout-minutes: 60 - strategy: - fail-fast: false - matrix: - partition: [1/3, 2/3, 3/3] - container: - image: ${{ needs.set-image.outputs.IMAGE }} - # needed for tests that use unshare syscall - options: --security-opt seccomp=unconfined - env: - RUST_TOOLCHAIN: stable - # Enable debug assertions since we are running optimized builds for testing - # but still want to have debug assertions. - RUSTFLAGS: "-Cdebug-assertions=y -Dwarnings" - steps: - - name: Checkout - uses: actions/checkout@v4 - - name: script - run: | - # Fixes "detected dubious ownership" error in the ci - git config --global --add safe.directory '*' - forklift cargo nextest run \ - --workspace \ - --locked \ - --release \ - --no-fail-fast \ - --features try-runtime,experimental,riscv,ci-only-tests \ - --partition count:${{ matrix.partition }} - # run runtime-api tests with `enable-staging-api` feature on the 1st node - - name: runtime-api tests - if: ${{ matrix.partition == '1/3' }} - run: forklift cargo nextest run -p sp-api-test --features enable-staging-api - - test-linux-stable-oldkernel: - needs: [set-image, changes] - if: ${{ needs.changes.outputs.rust }} - runs-on: oldlinux + runs-on: ${{ matrix.runners }} timeout-minutes: 60 strategy: fail-fast: false matrix: partition: [1/3, 2/3, 3/3] + runners: [arc-runners-polkadot-sdk-beefy, oldlinux] container: image: ${{ needs.set-image.outputs.IMAGE }} # needed for tests that use unshare syscall @@ -157,7 +121,6 @@ jobs: test-linux-stable-int, test-linux-stable-runtime-benchmarks, test-linux-stable, - test-linux-stable-oldkernel, ] steps: - run: echo '### Good job! All the tests passed 🚀' >> $GITHUB_STEP_SUMMARY From 78d87f005e9fbfbdcc0d4b0815b559f707c0e5a8 Mon Sep 17 00:00:00 2001 From: alvicsam Date: Thu, 8 Aug 2024 15:40:58 +0200 Subject: [PATCH 51/52] test action wo tags --- .github/workflows/tests-linux-stable.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tests-linux-stable.yml b/.github/workflows/tests-linux-stable.yml index 4a13f5318f7d..1e4da100b328 100644 --- a/.github/workflows/tests-linux-stable.yml +++ b/.github/workflows/tests-linux-stable.yml @@ -15,7 +15,7 @@ concurrency: jobs: changes: # TODO: remove once migration is complete or this workflow is fully stable - if: contains(github.event.label.name, 'GHA-migration') + # if: contains(github.event.label.name, 'GHA-migration') permissions: pull-requests: read uses: ./.github/workflows/reusable-check-changed-files.yml From 57f728fb4f340dcc5ae7300a7f25f3b6adff5da4 Mon Sep 17 00:00:00 2001 From: alvicsam Date: Thu, 8 Aug 2024 16:45:38 +0200 Subject: [PATCH 52/52] uncomment label --- .github/workflows/tests-linux-stable.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tests-linux-stable.yml b/.github/workflows/tests-linux-stable.yml index 1e4da100b328..4a13f5318f7d 100644 --- a/.github/workflows/tests-linux-stable.yml +++ b/.github/workflows/tests-linux-stable.yml @@ -15,7 +15,7 @@ concurrency: jobs: changes: # TODO: remove once migration is complete or this workflow is fully stable - # if: contains(github.event.label.name, 'GHA-migration') + if: contains(github.event.label.name, 'GHA-migration') permissions: pull-requests: read uses: ./.github/workflows/reusable-check-changed-files.yml