rewrite some flaky zombienet polkadot tests to zombienet-sdk #6757
Conversation
alindima
added
R0-silent
|
Hi @alindima, I think this is failing because we need to hide the |
alindima
changed the title
polkadot/zombienet-sdk-tests/tests/elastic_scaling/basic_3cores.rs
Outdated
Show resolved
Hide resolved
polkadot/zombienet-sdk-tests/tests/elastic_scaling/doesnt_break_parachains.rs
Show resolved
Hide resolved
|
|
||
| // Assert the parachain finalized block height is also on par with the number of backed | ||
| // candidates. | ||
| assert_finalized_block_height(¶_node.wait_client().await?, 6..9).await?; |
There was a problem hiding this comment.
While I get that we don't want flaky tests. It is kind of concerning that we let tests pass if we do less blocks than expected. We definitely need some tests in some fashion ensuring that we are not degrading.
There was a problem hiding this comment.
While I get that we don't want flaky tests. It is kind of concerning that we let tests pass if we do less blocks than expected.
I mean, we've always done this in the CI so far. The only way of fixing this IMO is to invest more in the reliability and performance of the CI machines
…into alindima/zombienet-sdk-rewrite
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
Yep, I ran them like 5-6 times each and we should be good |
Will fix:
#6574
#6644
#6062