Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for new binaries (polkadot) #1202

Closed
pepoviola opened this issue Jul 25, 2023 · 9 comments · Fixed by #1208
Closed

Add support for new binaries (polkadot) #1202

pepoviola opened this issue Jul 25, 2023 · 9 comments · Fixed by #1208
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@pepoviola
Copy link
Collaborator

pepoviola commented Jul 25, 2023

We should add support in our setup command for the upcoming new binaries in polkadot.
Reference issue: paritytech/polkadot#7337 (comment)

We should download in the same directory and also set them as executable.

@wirednkod
Copy link
Contributor

@pepoviola we have this issue: #434 is it relevant?

@mrcnski
Copy link
Contributor

mrcnski commented Jul 31, 2023

I've just merged paritytech/polkadot#7337, so I can knock this out if no one's started on it yet?

@wirednkod
Copy link
Contributor

@mrcnski Im on it - sorry did not assign it to me

@wirednkod wirednkod self-assigned this Jul 31, 2023
@mrcnski
Copy link
Contributor

mrcnski commented Jul 31, 2023

Awesome, for easy reference here the two new binaries are polkadot-prepare-worker and polkadot-execute-worker.

@wirednkod
Copy link
Contributor

@mrcnski Just to make sure we are on the same page - there will be no more polkadot binary? and it will split in these 2? Also can you please let me know if these binaries have official releases (and example links of those)?

@mrcnski
Copy link
Contributor

mrcnski commented Jul 31, 2023

there will be no more polkadot binary? and it will split in these 2?

There is still the polkadot binary, those are two new ones in addition.

Also can you please let me know if these binaries have official releases (and example links of those)?

I just merged the PR today so no official releases yet AFAIK. Let me know if any other questions. :)

@wirednkod
Copy link
Contributor

Thank you @mrcnski . I will push a draft PR and add you as a reviewer - and wait for some release to test it - if you are ok with that

@mrcnski
Copy link
Contributor

mrcnski commented Jul 31, 2023

Thank you @mrcnski . I will push a draft PR and add you as a reviewer - and wait for some release to test it - if you are ok with that

Perfect

@pepoviola
Copy link
Collaborator Author

@wirednkod just a heads-up since a new release will be soon available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants