-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add zombienet releases for mac arm64
#710
Comments
GH actions don't support macos arm64 runners at the moment. This pr cover the changes to apply when they add support. |
Duplicated with #434 |
Re-open here, since in this case is the release of |
arm64
arm64
…_64 limitation. Reference: paritytech/zombienet#710 Signed-off-by: Jasti Sri Radhe Shyam <[email protected]>
…_64 limitation. Reference: - paritytech/zombienet#710 Signed-off-by: Jasti Sri Radhe Shyam <[email protected]>
Bumping this issue as ARMs are now supported: |
Adding a matrix here should work zombienet/.github/workflows/release.yaml Lines 74 to 75 in 875a273
Something like this: build_release_for_mac:
name: build_release_for_mac
needs: build_release_for_linux
matrix:
target: [ { runner: macos-13, arch: x86_64 }, { runner: macos-14, arch: arm64 } ]
runs-on: ${{ matrix.target.runner }}
steps:
- name: checkout
uses: actions/checkout@v4
with:
fetch-depth: 0
# redacted for brevity
- name: upload macos artifact
uses: actions/upload-release-asset@v1
env:
GITHUB_TOKEN: ${{ github.token }}
with:
upload_url: ${{ needs.build_release_for_linux.outputs.upload_url }}
asset_path: ./javascript/bins/zombienet-macos
asset_name: zombienet-macos-${{ matrix.target.arch }}
asset_content_type: application/octet-stream I can open the PR if you think this is ok |
Yes, looks good to me 👍 |
We should update the CI to build on this arch.
The text was updated successfully, but these errors were encountered: