Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zombienet releases for mac arm64 #710

Closed
pepoviola opened this issue Jan 31, 2023 · 6 comments · Fixed by #1803
Closed

Add zombienet releases for mac arm64 #710

pepoviola opened this issue Jan 31, 2023 · 6 comments · Fixed by #1803
Labels
blocked enhancement New feature or request

Comments

@pepoviola
Copy link
Collaborator

We should update the CI to build on this arch.

@pepoviola pepoviola added the enhancement New feature or request label Jan 31, 2023
@pepoviola
Copy link
Collaborator Author

GH actions don't support macos arm64 runners at the moment. This pr cover the changes to apply when they add support.
#714

@wirednkod
Copy link
Contributor

Duplicated with #434

@pepoviola pepoviola reopened this Feb 20, 2023
@pepoviola
Copy link
Collaborator Author

Re-open here, since in this case is the release of zombienet itself not from polkadot.

@wirednkod wirednkod changed the title Add releases for mac arm64 Add zombienet releases for mac arm64 Feb 20, 2023
radhe-zeeve added a commit to gnv-zeeve/Grants-Program that referenced this issue Sep 1, 2023
radhe-zeeve added a commit to gnv-zeeve/Grants-Program that referenced this issue Sep 1, 2023
@th7nder
Copy link

th7nder commented May 15, 2024

Bumping this issue as ARMs are now supported:
https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories

@jmg-duarte
Copy link
Contributor

Adding a matrix here should work

runs-on: macos-13 # x64
# runs-on: macos-latest is arm

Something like this:

build_release_for_mac:
    name: build_release_for_mac
    needs: build_release_for_linux
    matrix: 
        target: [ { runner: macos-13, arch: x86_64 }, { runner: macos-14, arch: arm64 } ]
    runs-on: ${{ matrix.target.runner }}
    steps:
      - name: checkout
        uses: actions/checkout@v4
        with:
          fetch-depth: 0

      # redacted for brevity

      - name: upload macos artifact
        uses: actions/upload-release-asset@v1
        env:
          GITHUB_TOKEN: ${{ github.token }}
        with:
          upload_url: ${{ needs.build_release_for_linux.outputs.upload_url }}
          asset_path: ./javascript/bins/zombienet-macos
          asset_name: zombienet-macos-${{ matrix.target.arch }}
          asset_content_type: application/octet-stream

I can open the PR if you think this is ok

@pepoviola
Copy link
Collaborator Author

Yes, looks good to me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants