Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup of comparing to max level in refinement check #1225

Open
pgrete opened this issue Feb 6, 2025 · 0 comments
Open

Cleanup of comparing to max level in refinement check #1225

pgrete opened this issue Feb 6, 2025 · 0 comments
Assignees

Comments

@pgrete
Copy link
Collaborator

pgrete commented Feb 6, 2025

          I see. That makes sense.

I'm still not sure this check should belong inside the kernel (rather than being a general feature of those refinement criteria derived from what's available within the refinement package).
Conceptually, I see the refinement critera itself as what's inside the kernel and the max level an outer constraint (though also being available on a per refinement criteria level).
So I see a danger if there are more refinement criteria are added the code for checking the max level would need to be duplicated and added to each kernel, rather than checking separately.

Having said that, I'm happy to fix this later so that this PR can go in quicker.

Originally posted by @pgrete in #1182 (comment)

@pgrete pgrete self-assigned this Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant