Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to store values without reduction in history #1232

Open
5 tasks
pgrete opened this issue Mar 10, 2025 · 0 comments
Open
5 tasks

Add support to store values without reduction in history #1232

pgrete opened this issue Mar 10, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@pgrete
Copy link
Collaborator

pgrete commented Mar 10, 2025

This request came up on the AthenaPK matrix channel.

I think the easiest approach is to

  • add a new type that prevents any reduction from happening
  • with the callback function that is called by all ranks (so no changes), but for which only the value returned from rank 0 is actually being used (as it's the rank that already does the writing to the output file)

Thus, no additional changes are required and downstream codes only need to ensure that the desired value is properly available (returned) by rank 0.

Here are some pointer on how to tackle the implementation:

Unrelated: I just noticed that we seem to only support Real values in history files. Does this cause any issues for anyone at the moment?

@pgrete pgrete added the enhancement New feature or request label Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant