Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plausible): add ci mock values #248

Closed
wants to merge 1 commit into from

Conversation

pascaliske
Copy link
Owner

@pascaliske pascaliske commented Mar 17, 2023

  • BASE_URL
  • SECRET_KEY_BASE
  • DATABASE_URL
  • CLICKHOUSE_DATABASE_URL

Closes #245.

Summary by CodeRabbit

  • New Features
    • Added new chart repositories for enhanced functionality.
    • Introduced dependencies on postgresql and clickhouse for the Plausible analytics service, with options to enable or disable them.
    • Updated configuration options in the README for user customization of clickhouse and postgresql subcharts.

@pascaliske pascaliske self-assigned this Mar 17, 2023
@pascaliske pascaliske added the bug Something isn't working label Mar 17, 2023
@pascaliske pascaliske force-pushed the feature/plausible-ci-values branch from 3e78276 to 2308624 Compare March 18, 2023 20:10
@pascaliske pascaliske force-pushed the feature/plausible-ci-values branch from 2308624 to a99ac1b Compare April 16, 2023 10:05
@pascaliske pascaliske force-pushed the feature/plausible-ci-values branch from a99ac1b to 09e39a5 Compare June 3, 2023 07:10
@pascaliske pascaliske force-pushed the feature/plausible-ci-values branch from 09e39a5 to a4d289f Compare June 20, 2023 06:07
@pascaliske pascaliske force-pushed the feature/plausible-ci-values branch 4 times, most recently from 973bcfd to c1a275f Compare October 27, 2023 20:48
@pascaliske pascaliske force-pushed the feature/plausible-ci-values branch from c1a275f to 5b9bcfd Compare February 4, 2024 10:48
@pascaliske pascaliske force-pushed the feature/plausible-ci-values branch from 5b9bcfd to e774bb2 Compare April 12, 2024 05:39
Copy link

coderabbitai bot commented Apr 12, 2024

Walkthrough

Walkthrough

This update introduces the bitnami chart repository and adds dependencies on postgresql and clickhouse for the plausible Helm chart. It enhances configuration flexibility by allowing users to enable or disable these subcharts and specify versions. Additionally, it addresses CI configuration issues by specifying necessary environment variables for the Plausible analytics service.

Changes

File Path Change Summary
.ct/ct-install.yml
.ct/ct-lint.yml
Added bitnami chart repository.
charts/plausible/Chart.yaml
charts/plausible/values.yaml
Added dependencies and configurations for postgresql and clickhouse.
charts/plausible/README.md Documented configuration options for subcharts.
charts/plausible/ci/ct-values.yaml Set environment variables for CI.

Assessment against linked issues

Objective Addressed Explanation
Set CI values for plausible chart (#245)

Poem

Oh, in the land of code and helm,
Where rabbits hop and charts overwhelm,
A new repo rises, bright and shiny,
Bitnami's treasures, vast and tiny. 🌟
With PostgreSQL and ClickHouse in tow,
Our Plausible charts, oh how they grow! 📈
Celebrate, dear coders, with glee,
For better analytics, as good as can be! 🎉


Recent Review Details

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 969316b and e774bb2.
Files selected for processing (6)
  • .ct/ct-install.yml (1 hunks)
  • .ct/ct-lint.yml (1 hunks)
  • charts/plausible/Chart.yaml (1 hunks)
  • charts/plausible/README.md (2 hunks)
  • charts/plausible/ci/ct-values.yaml (1 hunks)
  • charts/plausible/values.yaml (1 hunks)
Files skipped from review due to trivial changes (1)
  • .ct/ct-lint.yml
Additional comments not posted (5)
.ct/ct-install.yml (1)

6-6: The addition of the bitnami chart repository is correctly implemented.

charts/plausible/ci/ct-values.yaml (1)

1-26: The environment variable configurations and database settings are correctly implemented for CI testing.

charts/plausible/Chart.yaml (1)

29-36: The dependencies on postgresql and clickhouse are correctly specified with versions, repositories, and conditions.

charts/plausible/values.yaml (1)

156-166: The configuration options for enabling or disabling the postgresql and clickhouse subcharts are correctly implemented.

charts/plausible/README.md (1)

49-56: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [52-84]

The updates to the README, including detailed configuration options for the clickhouse and postgresql subcharts, are correctly implemented and enhance user understanding.

Warning

Following problems were encountered

  • Git: Failed to clone repository. Please contact CodeRabbit support.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@pascaliske pascaliske deleted the branch master June 13, 2024 11:18
@pascaliske pascaliske closed this Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Set CI values for plausible chart
1 participant