New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert module toggles into NavigationLink #1193

Open

keeshux opened this issue Feb 17, 2025 · 0 comments

Labels

iOS refactoring

Milestone

3.2.0 / Features

Member

keeshux commented Feb 17, 2025 •

edited

Loading

Rather than a button + toggle, the following feels more natural on iOS:

NavigationLink with trailing "Enabled/Disabled" in main profile view
Each module view has a "Enabled" toggle on top (like on-demand)
Remove "tap to edit" from section footer, can only drag

Contextually, fix the redundant "Enabled" boolean inside the on-demand module (requires migration):

Module is active
- isEnabled → discard
- !isEnabled → disable module
Module is inactive
- Discard isEnabled value

keeshux added bug refactoring labels

keeshux added this to the 3.2.0 / Features milestone

keeshux added iOS and removed bug labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment