Fixed #20 premature redirect on logout due to mission optional callback

passport-next · Jul 13, 2019 · da353a8 · da353a8
1 parent e056ba7
commit da353a8
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,11 @@
 This changelog follows Semantic Versioning https://semver.org/
 
+# 3.0.1 (2019-07-13)
+
+### Patch
+
+* Fixed premature redirect in logOut #20 @rwky
+
 # 3.0.0 (UNRELEASED)
 
 ### Major

diff --git a/lib/http/request.js b/lib/http/request.js
@@ -67,18 +67,19 @@ req.login = req.logIn;
 
 /**
  * Terminate an existing login session.
+ * @param {GenericCallback} done
  * @returns {void}
  * @public
  */
-req.logOut = function logOut() {
+req.logOut = function logOut(done) {
   let property = 'user';
   if (this._passport && this._passport.instance) {
     property = this._passport.instance._userProperty || 'user';
   }
 
   this[property] = null;
   if (this._passport) {
-    this._passport.instance._sm.logOut(this);
+    this._passport.instance._sm.logOut(this, done);
   }
 };
 

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@passport-next/passport",
-    "version": "3.0.0",
+    "version": "3.0.1",
     "description": "Simple, unobtrusive authentication for Node.js.",
     "author": {
         "name": "Passport Next Developers",