Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyG's function data.sort_by_time() does not work if n==m #247

Open
M-Lampert opened this issue Dec 20, 2024 · 0 comments
Open

PyG's function data.sort_by_time() does not work if n==m #247

M-Lampert opened this issue Dec 20, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@M-Lampert
Copy link
Contributor

If n==m, data.sort_by_time() does not seem to sort the edges properly. My guess is that it instead sorts the node attributed then. As a temporary fix, I added a manual sorting of all edge_attributes (including edge_index) for this case and only use data.sort_by_time() when n!=m in #246 . But we should work towards getting the bug fixed in PyG so that we do not need a workaround.

@M-Lampert M-Lampert added the bug Something isn't working label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant