Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to SEO tab trigger content change? #219

Open
ianleeder opened this issue Aug 4, 2023 · 4 comments
Open

Changes to SEO tab trigger content change? #219

ianleeder opened this issue Aug 4, 2023 · 4 comments
Labels
Help Wanted Extra attention is needed

Comments

@ianleeder
Copy link
Contributor

If you only make a change on the SEO tab and save the changes, you get the expected green bar:

SEO content saved!

If you attempt to navigate away from the content node, without having made any changes to the content, you get warned about unsaved changes:
image

Can changes to the SEO tab somehow prevent marking the content node as dirty requiring save?

@patrickdemooij9
Copy link
Owner

Hi @ianleeder,
Thank you for the report! I'll take a look at this after my vacation, not quite sure if this is something I would be able to fix or if it should be done in Umbraco itself, but I'll take a look at it!

@ianleeder
Copy link
Contributor Author

When editing document types, it seems to trigger two saves:
image

But when editing content, it only does the SEO save, no content.

@robertjf
Copy link
Contributor

@patrickdemooij9 is it possible to actually do the SEO save by hooking into the Content Saved event instead of handling it separately I wonder? There's also an issue here where if you it Save and Publish, it does the two saves but will refresh the content back to the Node you were working on. If I've already moved onto a different node, then there's a race-condition inconsistency with the content and content tree. I'll try to put together a screen recording to show you what I mean.

@patrickdemooij9
Copy link
Owner

@robertjf The reason why it is separate now is because it might be confusing to the user if they click "Save and publish" and it also saves the normal content as you are only editing the SEO data. But maybe that idea just lives in my head and combining them would be better, especially if we have race conditions going on.
Or do you see the race condition only on the document type save?

@patrickdemooij9 patrickdemooij9 added the Help Wanted Extra attention is needed label Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants