From c1aae93516ad6be4e23c0c08976ba7fe5fb383e6 Mon Sep 17 00:00:00 2001 From: Tom Wijgers Date: Thu, 10 Oct 2024 18:13:27 +1100 Subject: [PATCH] Fix help messages. The description for -src and -scale were swapped with each other --- README.md | 16 ++++++++-------- src/main/resources/bundles/strings.properties | 4 ++-- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/README.md b/README.md index 07c52a6..1d2c378 100644 --- a/README.md +++ b/README.md @@ -108,14 +108,7 @@ Full list of arguments: -roundingMode Defines the rounding mode when scaling the dimensions. Possible options are 'round' (rounds up of >= 0.5), 'floor' (rounds down) and 'ceil' (rounds up). Default is ROUND_HALF_UP - -scale <[float]|[int]dp> The source. Can be an image file or a folder containing image files - to be converted. This argument is mandatory. - -scaleIsHeightDp If set and scale is in dp it will be interpreted as fixed height not - width - -skipExisting If set will not overwrite a already existing file - -skipUpscaling If set will only scale down, but not up to prevent image quality - loss - -src The source scale. This can either be a factor (1,1.5,2,3,4,etc.) + -scale <[float]|[int]dp> The source scale. This can either be a factor (1,1.5,2,3,4,etc.) used if the images already have the correct resolution for one scale factor and up- and downscaling for all other densities are needed. Ie. if you have the src file in density xxxhdpi you pass '4'. You @@ -123,6 +116,13 @@ Full list of arguments: denotes the output pixel width (or height if the flag is set) in mdpi/x1. In this mode all output images will have the same width (height). This argument is mandatory. + -scaleIsHeightDp If set and scale is in dp it will be interpreted as fixed height not + width + -skipExisting If set will not overwrite a already existing file + -skipUpscaling If set will only scale down, but not up to prevent image quality + loss + -src The source. Can be an image file or a folder containing image files + to be converted. This argument is mandatory. -threads <1-8> Sets the count of max parallel threads (more is faster but uses more memory). Possible values are 1-8. Default is 4 -v,--version Gets current version diff --git a/src/main/resources/bundles/strings.properties b/src/main/resources/bundles/strings.properties index e631041..60b553c 100644 --- a/src/main/resources/bundles/strings.properties +++ b/src/main/resources/bundles/strings.properties @@ -84,8 +84,8 @@ arg.descr.cmd.threads=Sets the count of max parallel threads (more is faster but arg.descr.cmd.platform=Can be ''all'', ''android'', ''ios'', ''win'' or ''web''. Sets what formats the converted images will be generated for. E.g. set ''android'' if you only want to convert to android format. Default is {0} arg.descr.scalingalgo=Sets the scaling algorithm for either up- ord downscaling. Unfortunately there is no 'perfect' scaling algorithm it always depends on the specific use. Scaling is always a compromise between aliasing, blurring and ringing. Usually Lanczos3 is considered very good for up and downscaling, but for icons with sharp edges progressive algorithms may be better for downscaling. arg.descr.cmd.dst=The directory in which the converted files will be written. Will use the source folder if this argument is omitted. -arg.descr.cmd.src=The source scale. This can either be a factor (1,1.5,2,3,4,etc.) used if the images already have the correct resolution for one scale factor and up- and downscaling for all other densities are needed. Ie. if you have the src file in density xxxhdpi you pass '4'. You could also pass a value in dp (density independent pixels) which denotes the output pixel width (or height if the flag is set) in mdpi/x1. In this mode all output images will have the same width (height). This argument is mandatory. -arg.descr.cmd.scale=The source. Can be an image file or a folder containing image files to be converted. This argument is mandatory. +arg.descr.cmd.scale=The source scale. This can either be a factor (1,1.5,2,3,4,etc.) used if the images already have the correct resolution for one scale factor and up- and downscaling for all other densities are needed. Ie. if you have the src file in density xxxhdpi you pass '4'. You could also pass a value in dp (density independent pixels) which denotes the output pixel width (or height if the flag is set) in mdpi/x1. In this mode all output images will have the same width (height). This argument is mandatory. +arg.descr.cmd.src=The source. Can be an image file or a folder containing image files to be converted. This argument is mandatory. arg.descr.btnsrcfolder=Select a source folder for batch converting arg.descr.btndstfolder=Select the destination folder where the scaled image will be created arg.descr.btnsrcFile=Select the source image file to scale