Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EmptyDetailsView - migrate from ODH and document API #26

Open
nicolethoen opened this issue Oct 9, 2024 · 1 comment · May be fixed by #65
Open

EmptyDetailsView - migrate from ODH and document API #26

nicolethoen opened this issue Oct 9, 2024 · 1 comment · May be fixed by #65
Assignees
@adamviktora
Milestone
2024.Q4

Comments

@nicolethoen
Copy link
Contributor

The code for this component currently lives at https://github.com/opendatahub-io/odh-dashboard/blob/main/frontend/src/components/EmptyDetailsView.tsx

This new components should be built using PF6.

A PF6 version of this component lives in the current PF6 migration POC PR: opendatahub-io/odh-dashboard#3038

The API of the new component should match the API of the component in RHOAI.
We can improve a11y, right-to-left language support, replace deprecated components under the hood, or generally clean up the implementation, as long as the API works in RHOAI.
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Oct 9, 2024
@nicolethoen nicolethoen moved this from Needs triage to Ready to assign in PatternFly Issues Oct 9, 2024
@nicolethoen nicolethoen added this to the 2024.Q4 milestone Oct 9, 2024
@adamviktora adamviktora self-assigned this Nov 6, 2024
@adamviktora
Copy link
Collaborator

adamviktora commented Nov 20, 2024 •
edited
Loading

Issues:

  • there is not a way to pass data-testid="empty-state-title" prop to EmptyStateHeader (it is an internal component now)

@adamviktora adamviktora linked a pull request Nov 22, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamviktora adamviktora

Labels
None yet
Projects
PatternFly Issues
Status: PR Review
Milestone
2024.Q4
Development

Successfully merging a pull request may close this issue.

feat(EmptyDetailsView): add component adamviktora/AI-infra-ui-components
2 participants
@nicolethoen @adamviktora