Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom icons on Quick Response #434

Open
ibolton336 opened this issue Feb 10, 2025 · 9 comments
Open

Allow custom icons on Quick Response #434

ibolton336 opened this issue Feb 10, 2025 · 9 comments
Assignees
Labels
PF6 Applies to only the PF6 version
Milestone

Comments

@ibolton336
Copy link
Member


  /** Message content */
  content?: string;

Any reason why we wouldn't be able to expand this to include react nodes?

@rebeccaalpert
Copy link
Member

Hi @ibolton336 - We're limited by React-Markdown here: https://github.com/remarkjs/react-markdown/blob/main/lib/index.js#L56C1-L56C41. Are you looking to inject other components into the body of the message?

@rebeccaalpert rebeccaalpert self-assigned this Feb 10, 2025
@rebeccaalpert rebeccaalpert added the PF6 Applies to only the PF6 version label Feb 10, 2025
@ibolton336
Copy link
Member Author

Yeah could we add a new prop called messageContent that if passed, replaces the other content?

@rebeccaalpert
Copy link
Member

Do you have any wireframes you could share for what you're trying to do here?

@ibolton336
Copy link
Member Author

Image

@rebeccaalpert
Copy link
Member

rebeccaalpert commented Feb 10, 2025

Got it. Can I ask what group/project this is? This looks like a slightly customized Quick Response. We don't currently allow custom icons in there, but it's something we can enable quickly. Do you envision needing to inject other types of content?

@ibolton336
Copy link
Member Author

Sure @rebeccaalpert - this is just a mockup would love feedback. It is for the KAI IDE plugin https://github.com/konveyor/editor-extensions. TYVM

@ibolton336
Copy link
Member Author

ibolton336 commented Feb 10, 2025

Do you envision needing to inject other types of content?

Ideally we would have a way to show a panel that is expandable into a full screen view, tables of data, etc.

@rebeccaalpert
Copy link
Member

Ideally we would have a way to show a panel that is expandable into a full screen view, tables of data, etc.

Tables should be coming as part of #425 very soon! It should just be markdown syntax. Do you have any mocks for the panel yet?

@rebeccaalpert rebeccaalpert changed the title Allow react elements to be passed to message component Allow custom icons on Quick Response Feb 13, 2025
@rebeccaalpert rebeccaalpert moved this from Needs triage to Not started in PatternFly Issues Feb 13, 2025
@rebeccaalpert
Copy link
Member

Just renaming this to track the Quick Response icons - I'll use this ticket to track/implement. We got the ok from the group today. Should be pretty straightforward to allow customization of those.

@rebeccaalpert rebeccaalpert added this to the 2025.Q2 milestone Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PF6 Applies to only the PF6 version
Projects
Status: Not started
Development

No branches or pull requests

2 participants