Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete confirmation #1163

Closed
pankajshivpuje opened this issue May 23, 2022 · 4 comments
Closed

Delete confirmation #1163

pankajshivpuje opened this issue May 23, 2022 · 4 comments
Assignees
Milestone

Comments

@pankajshivpuje
Copy link

pankajshivpuje commented May 23, 2022

Requesting design recommendations/demo for delete confirmation

While working on delete component feature for App Studio design, I came across several variations of delete confirmation modal designs across RH products. The primary use case to support this feature is the ability for the user to be able to delete a said object from the system. Delete is a detrimental action so when user decides to delete an object, we would like to make sure user understand it is irreversible permanent action. We would also like to make sure that user is deleting the correct object so asking user the confirm before proceeding with this action. The confirmation model presented to the user allows user to doublecheck the action and then proceed.

Few areas that needs be to explored as a part of this issue:

  1. When to enable/disable primary action button on the forms/modals? This can go beyond the delete confirmation and will allow the exploration of forms and model in various scenarios across the RH products.
  2. Ask user to type the name of object being deleted and provide feedback as they start typing.
  3. After delete interaction is completed, how is the object removed from the list?

PF recommendations around designing the confirmation modals will help bring the consistency across the product, reduce learning curve, and reduce errors. In addition, the recommendations/demo can help guide the future design efforts for similar use case.

Here are some examples delete confirmation modals from various RH products.

Example 1:

image

image (1)

Example 2:

Screen Shot 2022-05-19 at 12 04 05 PM

Screen Shot 2022-05-19 at 12 04 15 PM

Screen Shot 2022-05-19 at 12 04 22 PM

Example 3:

Screen Shot 2022-05-19 at 12 07 42 PM

Screen Shot 2022-05-19 at 12 07 53 PM

@mcarrano mcarrano added this to the 2022.08 milestone May 23, 2022
@mcarrano mcarrano moved this to Not started in PatternFly Issues Jun 2, 2022
@mcarrano mcarrano moved this from Not started to In Progress in PatternFly Issues Jun 23, 2022
@mcarrano mcarrano modified the milestones: 2022.08, 2022.09 Jun 23, 2022
@mcarrano
Copy link
Member

@mcarrano mcarrano modified the milestones: 2022.09, 2021.11, 2022.11 Jul 14, 2022
@mcarrano mcarrano modified the milestones: 2022.11, 2022.12 Aug 25, 2022
@mcarrano mcarrano modified the milestones: 2022.12, 2022.13 Sep 15, 2022
@mcarrano mcarrano modified the milestones: 2022.13, 2022.14 Oct 6, 2022
@mcarrano mcarrano modified the milestones: 2022.14, 2022.15 Oct 27, 2022
@pankajshivpuje
Copy link
Author

pankajshivpuje commented Nov 18, 2022

@mcarrano Here are the latest proposal for delete confirmation modal
We need to discuss the process to figure if the outcome of this issue lives on PF site or the in the design conventions.

@mmenestr
Copy link
Collaborator

Design doc issue: patternfly/patternfly-org#3420

@mcarrano
Copy link
Member

Will document on the website as a new pattern. See the linked Org issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants