Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guildelines for success/failure pie charts #3021

Closed
dlabrecq opened this issue Jun 16, 2022 · 3 comments · Fixed by #3759
Closed

Add guildelines for success/failure pie charts #3021

dlabrecq opened this issue Jun 16, 2022 · 3 comments · Fixed by #3759
Assignees

Comments

@dlabrecq
Copy link
Member

dlabrecq commented Jun 16, 2022

As a developer, I want to see more design guidelines for charts. As an example, consider providing guidelines for a red/green pie chart representing success/failure states. Don't necessarily need more examples showing how to create a chart, but a guide as to when to use this type of chart, what colors are recommended, and when to use patterns, etc.

@nicolethoen
Copy link
Collaborator

I'm going to move this to the org repo.
There are some charts with guidelines already - or some more than others. Maybe this can be an opportunity build on them some.

https://www.patternfly.org/v4/charts/bar-chart/design-guidelines

@nicolethoen nicolethoen transferred this issue from patternfly/patternfly-react Jun 21, 2022
@dlabrecq dlabrecq changed the title Add a "design guidelines" section for charts Add guildelines for success/failure pie charts Jun 21, 2022
@mmenestr mmenestr moved this to Ready to assign in PatternFly Issues Jan 12, 2023
@mmenestr mmenestr moved this from Ready to assign to Not started in PatternFly Issues Jan 31, 2023
@mmenestr mmenestr moved this from Not started to In Progress in PatternFly Issues Apr 12, 2023
@dlabrecq
Copy link
Member Author

dlabrecq commented May 9, 2023

Some background... About a year ago, Ethan Kim was working to solve a color contrast issue with the donut chart. Basically, products are using donut charts, and custom colors, to represent alerts; where green represents success and red for failure.

The original design issue can be found here #4369.

The solution was to make patterns available to charts. However, Ethan, Matt Carrano, and Michael Celedonia also discussed creating guidelines to describe when to use color combinations in charts Vs when to use the new patterns. While Ethan worked on guidelines, I created this issue as a placeholder.

The available chart patterns can be seen at https://www.patternfly.org/v4/charts/patterns. We're just missing some guidelines.

@mmenestr
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants