-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add guildelines for success/failure pie charts #3021
Comments
I'm going to move this to the org repo. https://www.patternfly.org/v4/charts/bar-chart/design-guidelines |
Some background... About a year ago, Ethan Kim was working to solve a color contrast issue with the donut chart. Basically, products are using donut charts, and custom colors, to represent alerts; where green represents success and red for failure. The original design issue can be found here #4369. The solution was to make patterns available to charts. However, Ethan, Matt Carrano, and Michael Celedonia also discussed creating guidelines to describe when to use color combinations in charts Vs when to use the new patterns. While Ethan worked on guidelines, I created this issue as a placeholder. The available chart patterns can be seen at https://www.patternfly.org/v4/charts/patterns. We're just missing some guidelines. |
Document with draft: https://docs.google.com/document/d/1DgQdUJ9tLCfLCrLna6_-7wiAkHPwqF5C1RANO2XrLvQ/edit |
As a developer, I want to see more design guidelines for charts. As an example, consider providing guidelines for a red/green pie chart representing success/failure states. Don't necessarily need more examples showing how to create a chart, but a guide as to when to use this type of chart, what colors are recommended, and when to use patterns, etc.
The text was updated successfully, but these errors were encountered: