Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update checkbox/radio a11y docs regarding impicit/explicit linking #4008

Closed
thatblindgeye opened this issue May 7, 2024 · 1 comment · Fixed by #4188
Closed

Update checkbox/radio a11y docs regarding impicit/explicit linking #4008

thatblindgeye opened this issue May 7, 2024 · 1 comment · Fixed by #4188
Assignees

Comments

@thatblindgeye
Copy link
Contributor

Is this a new page or a change to an existing one?
Radio/Checkbox

Describe the enhancement
We should update docs to mention that explicitly associating a label with its input should be preferred (i.e. not passing isLabelWrapped to either component, and instead passing an id), per labeling controls. The React section should also be updated to mention that the id is only required when isLabelWrapped is notpassed in.

Are there visuals for this enhancement? If applicable, please include examples for each state and for varying widths
Include screenshots or links to Marvel or other mockups.

Any other information?

@thatblindgeye thatblindgeye self-assigned this May 7, 2024
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Extensions May 7, 2024
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues May 7, 2024
@jessiehuff jessiehuff added this to the Penta beta release milestone Jun 4, 2024
@jessiehuff jessiehuff moved this from Needs triage to Backlog in PatternFly Issues Jun 4, 2024
@nicolethoen nicolethoen moved this from Backlog to Not started in PatternFly Issues Jul 3, 2024
@thatblindgeye thatblindgeye moved this from Not started to PR Review in PatternFly Issues Aug 13, 2024
@thatblindgeye thatblindgeye linked a pull request Aug 13, 2024 that will close this issue
@thatblindgeye
Copy link
Contributor Author

Closed by 4188

@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Status: Needs triage
Development

Successfully merging a pull request may close this issue.

3 participants