Skip to content

Commit

Permalink
Merge pull request #150 from mturley/fix-peer-deps
Browse files Browse the repository at this point in the history
Remove unnecessary dependencies so we no longer need `npm install --legacy-peer-deps`
  • Loading branch information
mturley authored Aug 22, 2022
2 parents 6d2eae5 + 460c72d commit 62e92b7
Show file tree
Hide file tree
Showing 5 changed files with 3,296 additions and 6,349 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
with:
node-version: lts/*
- name: Install dependencies
run: npm install --legacy-peer-deps # TODO remove --legacy-peer-deps after https://github.com/patternfly/patternfly-react-seed/issues/134 is fixed
run: npm install
- name: Run eslint
run: npm run lint
test:
Expand All @@ -32,7 +32,7 @@ jobs:
with:
node-version: lts/*
- name: Install dependencies
run: npm install --legacy-peer-deps # TODO remove --legacy-peer-deps after https://github.com/patternfly/patternfly-react-seed/issues/134 is fixed
run: npm install
- name: Run tests
run: npm run test
build:
Expand All @@ -46,6 +46,6 @@ jobs:
with:
node-version: lts/*
- name: Install dependencies
run: npm install --legacy-peer-deps # TODO remove --legacy-peer-deps after https://github.com/patternfly/patternfly-react-seed/issues/134 is fixed
run: npm install
- name: Attempt a build
run: npm run build
Loading

0 comments on commit 62e92b7

Please sign in to comment.