Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeEditor - allow additional props to pass to Editor #10065

Closed
kmcfaul opened this issue Feb 6, 2024 · 0 comments · Fixed by #10080
Closed

CodeEditor - allow additional props to pass to Editor #10065

kmcfaul opened this issue Feb 6, 2024 · 0 comments · Fixed by #10080

Comments

@kmcfaul
Copy link
Contributor

kmcfaul commented Feb 6, 2024

There was an issue in slack where the new @monaco-editor/react package isn't playing nicely with the monaco-yaml package's autocomplete feature. It seems a possible resolution would be to pass a beforeMount callback to the Editor to allow monaco-yaml to configure the editor before the initial mount, but currently we do not expose that prop or spread any additional props to Editor.

@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Feb 6, 2024
@tlabaj tlabaj moved this from Needs triage to Backlog in PatternFly Issues Feb 7, 2024
@tlabaj tlabaj added this to the Prioritized Backlog milestone Feb 7, 2024
@kmcfaul kmcfaul closed this as completed Mar 12, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in PatternFly Issues Mar 12, 2024
@tlabaj tlabaj removed this from the Prioritized Backlog milestone Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants