Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expandable card/Expandable section consistency #10088

Closed
fhlavac opened this issue Feb 15, 2024 · 4 comments
Closed

Expandable card/Expandable section consistency #10088

fhlavac opened this issue Feb 15, 2024 · 4 comments
Labels

Comments

@fhlavac
Copy link

fhlavac commented Feb 15, 2024

When comparing the Expandable card component to the Expandable section I noticed that the expand toggle icon changes color (black/grey) on focus for the card and not for the expandable section
https://www.patternfly.org/components/card#expandable-cards
https://www.patternfly.org/components/expandable-section
Not sure if that's intentional. It might be worth making the experience consistent.

Is this request originating from a Red Hat product team? If so, which ones and is there any sort of deadline for this enhancement?
PatternFly React component groups extension - no deadline

@tlabaj
Copy link
Contributor

tlabaj commented Feb 26, 2024

cc @mcoker @andrew-ronaldson

@tlabaj tlabaj moved this from Needs triage to Needs info in PatternFly Issues Feb 26, 2024
@andrew-ronaldson
Copy link
Collaborator

In the Card example the icon is the only clickable area but for Expandable sections the Icon + Text block is clickable. This is more obvious in v6 where the icon colours won't change in either component but the card will get the background-color and expandable section won't. For v5 we could sync the icon hover states in both these examples.

Possible v5 update:
Card: Icon gray to Black on hover
Expandable: Icon gray to black + Link blue default to Link blue hover

Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

Copy link

This issue has been closed because it has not had activity since being marked as stale.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 12, 2024
@github-project-automation github-project-automation bot moved this from Needs info to Done in PatternFly Issues May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

3 participants