Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - TableComposable (react/table) - compile errors #10266

Closed
phantomjinx opened this issue Apr 10, 2024 · 2 comments
Closed

Bug - TableComposable (react/table) - compile errors #10266

phantomjinx opened this issue Apr 10, 2024 · 2 comments

Comments

@phantomjinx
Copy link

Describe the problem
Update of @types/react to 18.2.66 in packages of hawtio-online, have caused compile errors where the FunctionComponent TableComposable is used. The version of @patternfly/react-table that we depend on is 4.113.7, which we realise is Patternfly 4.

The question is whether there is to be any further release or upgrade of Patternfly 4 or whether we should pin @types/react ro 18.2.64 until our own upgrade to Patternfly 5?

ERROR in /home/phantomjinx/programming/openshift/hawtio-online/packages/management-api-app/src/ManagementPods.tsx
./src/ManagementPods.tsx 30:11-26
[tsl] ERROR in /home/phantomjinx/programming/openshift/hawtio-online/packages/management-api-app/src/ManagementPods.tsx(30,12)
      TS2739: Type '{ children: Element[]; key: string; "aria-label": string; variant: "compact"; }' is missing the following properties from type 'Pick<TableComposableProps, "children" | "id" | "action" | "default" | "title" | "accept" | "acceptCharset" | "allowFullScreen" | "allowTransparency" | ... 364 more ... | "selectableRowCaptionText">': onPointerEnterCapture, onPointerLeaveCapture
 @ ./src/Management.tsx 16:0-50 62:654-668
 @ ./src/bootstrap.tsx 7:0-42 25:217-227
 @ ./src/index.ts 3:0-21

ERROR in /home/phantomjinx/programming/openshift/hawtio-online/packages/management-api-app/src/ManagementPods.tsx
./src/ManagementPods.tsx 31:13-18
[tsl] ERROR in /home/phantomjinx/programming/openshift/hawtio-online/packages/management-api-app/src/ManagementPods.tsx(31,14)
      TS2739: Type '{ children: Element; }' is missing the following properties from type 'Pick<TheadProps, "children" | "id" | "action" | "default" | "title" | "accept" | "acceptCharset" | "allowFullScreen" | "allowTransparency" | "alt" | "as" | "async" | ... 350 more ... | "hasNestedHeader">': onPointerEnterCapture, onPointerLeaveCapture
 @ ./src/Management.tsx 16:0-50 62:654-668
 @ ./src/bootstrap.tsx 7:0-42 25:217-227
 @ ./src/index.ts 3:0-21
@tlabaj
Copy link
Contributor

tlabaj commented Apr 10, 2024

Hello, I would suggest pinning your @types/react version. We do not plan on making any updates to PF4 at this time.
React 18 support was introduced with PF5.

@phantomjinx
Copy link
Author

Thanks for the clarification. We will do so.

@github-project-automation github-project-automation bot moved this from Needs triage to Done in PatternFly Issues Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants