Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wizard v6 - Consider making WizardBody required #10319

Closed
thatblindgeye opened this issue Apr 30, 2024 · 1 comment · Fixed by #10637
Closed

Wizard v6 - Consider making WizardBody required #10319

thatblindgeye opened this issue Apr 30, 2024 · 1 comment · Fixed by #10637
Assignees

Comments

@thatblindgeye
Copy link
Contributor

Describe the enhancement or change
Followup based on comment chain #10285 (comment)

Currently a consumer could have the WizardBody omitted by passing a body={null] to a Wizard Step. This can cause an issue in the fix implemented in the above PR, but also Core marks the WizardBody elements as required. We should consider removing the ability for a consumer to prevent those components from rendering both to match Core and to always have a static element that can be focused via the above PRs fix.

Is this request originating from a Red Hat product team? If so, which ones and is there any sort of deadline for this enhancement?

Any other information?

@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Apr 30, 2024
@thatblindgeye thatblindgeye self-assigned this Apr 30, 2024
@tlabaj tlabaj moved this from Needs triage to Backlog in PatternFly Issues May 2, 2024
@kmcfaul kmcfaul moved this from Backlog to Not started in PatternFly Issues May 9, 2024
@thatblindgeye thatblindgeye moved this from Not started to PR Review in PatternFly Issues Jun 20, 2024
@thatblindgeye thatblindgeye added this to the Penta beta release milestone Jun 20, 2024
@thatblindgeye
Copy link
Contributor Author

Closes by #10637

@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant