Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PF6 Page: rename header prop to masthead. #10368

Closed
tlabaj opened this issue May 15, 2024 · 0 comments · Fixed by #10454
Closed

PF6 Page: rename header prop to masthead. #10368

tlabaj opened this issue May 15, 2024 · 0 comments · Fixed by #10454
Assignees
@adamviktora
Milestone
Penta beta release

Comments

@tlabaj
Copy link
Contributor

tlabaj commented May 15, 2024

Describe the enhancement or change
A clear and concise description of the request. What is the expected outcome?
Since the page header componet has been deprecated in v5, let us rename the pageHeader prop to masthead since that is more accurate s description.

Also update the descriptive text that says A <Page> with a header that often contains a masthead
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues May 15, 2024
@tlabaj tlabaj changed the title PF6 Page: rename header prop to Masthead. PF6 Page: rename header prop to masthead. May 15, 2024
@tlabaj tlabaj moved this from Needs triage to Backlog in PatternFly Issues May 20, 2024
@tlabaj tlabaj added this to the Penta beta release milestone May 20, 2024
@tlabaj tlabaj added the sm label May 20, 2024
@adamviktora adamviktora self-assigned this May 22, 2024
@adamviktora adamviktora moved this from Backlog to Not started in PatternFly Issues May 22, 2024
@adamviktora adamviktora mentioned this issue May 28, 2024
Merged
@adamviktora adamviktora linked a pull request May 28, 2024 that will close this issue
feat(Page): rename 'header' prop to 'masthead' #10454
Merged
@adamviktora adamviktora moved this from Not started to PR Review in PatternFly Issues May 28, 2024
@kmcfaul kmcfaul closed this as completed Jun 5, 2024
@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamviktora adamviktora

Labels
None yet
Projects
PatternFly Issues
Archived in project
Milestone
Penta beta release
Development

Successfully merging a pull request may close this issue.

feat(Page): rename 'header' prop to 'masthead' adamviktora/patternfly-react
3 participants
@tlabaj @kmcfaul @adamviktora