-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Select, dropdown, options menu, contect selector, app launcher): Remove deprecated components #10345
Conversation
… Remove deprecated componets
Preview: https://patternfly-react-pr-10345.surge.sh A11y report: https://patternfly-react-pr-10345-a11y.surge.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple comments below. The "Editable rows" deprecated Table demo is also still using the now removed deprecated SelectOption component.
newValue: string | SelectOptionObject, | ||
isPlaceholder: boolean | ||
newValue: any | any[] | ||
// isPlaceholder: boolean |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we intend to add this back in at any point?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Eric. I did add updates for Editable table to my follow up issue #10365
<MenuToggle ref={toggleRef} onClick={onToggle} isExpanded={isOpen}> | ||
{isOpen ? 'Expanded' : 'Collapsed'} | ||
</MenuToggle> | ||
)} | ||
> | ||
{options} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we'll need to import SelectList and wrap it around {options}
here.
Your changes have been released in:
Thanks for your contribution! 🎉 |
What: Closes #10143 #10316 #10141 #10140 #10139 #10138 #10137
Opened follow up issue to update failing integration tests and fix demo-app: #10365