feat(charts): import charts from @patternfly/react-charts/victory (#779)

* feat(charts): import charts from @patternfly/react-charts/victory * chore(charts): added test for js
patternfly · Oct 3, 2024 · 99409dd · 99409dd
1 parent 6ed6e84
commit 99409dd
Show file tree

Hide file tree

Showing 6 changed files with 204 additions and 0 deletions.
diff --git a/.../eslint-plugin-pf-codemods/src/rules/v6/chartsImportMoved/chartsImport-moved.md b/.../eslint-plugin-pf-codemods/src/rules/v6/chartsImportMoved/chartsImport-moved.md
@@ -0,0 +1,19 @@
+### chartsImport-moved [(#11091)](https://github.com/patternfly/patternfly-react/pull/11091)
+
+In order to support multiple chart libraries, Victory based charts have moved. This rule will update import paths to our victory directory.
+
+Additionally, Victory has become a peer dependency.
+
+#### Examples
+
+In:
+
+```jsx
+%inputExample%
+```
+
+Out:
+
+```jsx
+%outputExample%
+```
diff --git a/packages/eslint-plugin-pf-codemods/src/rules/v6/chartsImportMoved/chartsImport-moved.test.ts b/packages/eslint-plugin-pf-codemods/src/rules/v6/chartsImportMoved/chartsImport-moved.test.ts
@@ -0,0 +1,99 @@
+const ruleTester = require("../../ruletester");
+import * as rule from "./chartsImport-moved";
+import {
+  ValidTests,
+  InvalidTests,
+  createValidTest,
+  createInvalidTest,
+} from "../../helpers/testHelpers";
+
+const specifiersToMove = [
+  'Chart',
+  'ChartArea',
+  'ChartAxis',
+  'ChartBar',
+  'ChartBoxPlot',
+  'ChartBullet',
+  'ChartBulletComparativeErrorMeasure',
+  'ChartBulletComparativeMeasure',
+  'ChartBulletComparativeWarningMeasure',
+  'ChartBulletPrimaryDotMeasure',
+  'ChartBulletPrimarySegmentedMeasure',
+  'ChartBulletQualitativeRange',
+  'ChartContainer',
+  'ChartCursorContainer',
+  'ChartCursorTooltip',
+  'ChartCursorFlyout',
+  'ChartDonut',
+  'ChartDonutThreshold',
+  'ChartDonutUtilization',
+  'ChartGroup',
+  'ChartLabel',
+  'ChartLegend',
+  'ChartLegendTooltip',
+  'ChartLegendTooltipContent',
+  'ChartLegendTooltipLabel',
+  'ChartLine',
+  'ChartPie',
+  'ChartPoint',
+  'ChartScatter',
+  'ChartStack',
+  'ChartTheme',
+  'ChartThemeColor',
+  'ChartThreshold',
+  'ChartTooltip',
+  'ChartVoronoiContainer',
+  'createContainer',
+  'getInteractiveLegendEvents',
+  'getInteractiveLegendItemStyles',
+  'getCustomTheme',
+  'getTheme',
+  'getThemeColors'
+];
+
+const validTests: ValidTests = [];
+const invalidTests: InvalidTests = [];
+
+specifiersToMove.forEach((specifier) => {
+  validTests.push(createValidTest(`<${specifier} />`));
+  validTests.push(
+    createValidTest(
+      `import { ${specifier} } from '@patternfly/react-charts/victory';`
+    )
+  );
+
+  const errorMessage = `${specifier} has been moved. This rule will update import paths.`;
+  invalidTests.push(
+    createInvalidTest(
+      `import { ${specifier} } from '@patternfly/react-charts';`,
+      `import {\n\t${specifier}\n} from '@patternfly/react-charts/victory';`,
+      [{ message: errorMessage, type: "ImportDeclaration" }]
+    )
+  );
+  invalidTests.push(
+    createInvalidTest(
+      `import { ${specifier} as CustomSpecifier } from '@patternfly/react-charts';`,
+      `import {\n\t${specifier} as CustomSpecifier\n} from '@patternfly/react-charts/victory';`,
+      [{ message: errorMessage, type: "ImportDeclaration" }]
+    )
+  );
+  invalidTests.push(
+    createInvalidTest(
+      `import { ${specifier} } from '@patternfly/react-charts/dist/esm/components/index.js';`,
+      `import {\n\t${specifier}\n} from '@patternfly/react-charts/dist/esm/victory/components/index.js';`,
+      [{ message: errorMessage, type: "ImportDeclaration" }]
+    )
+  );
+  invalidTests.push(
+    createInvalidTest(
+      `import { ${specifier} } from '@patternfly/react-charts/dist/js/components/index.js';`,
+      `import {\n\t${specifier}\n} from '@patternfly/react-charts/dist/js/victory/components/index.js';`,
+      [{ message: errorMessage, type: "ImportDeclaration" }]
+    )
+  );
+});
+
+ruleTester.run("chartImport-moved", rule, {
+  valid: validTests,
+  invalid: invalidTests,
+});
diff --git a/packages/eslint-plugin-pf-codemods/src/rules/v6/chartsImportMoved/chartsImport-moved.ts b/packages/eslint-plugin-pf-codemods/src/rules/v6/chartsImportMoved/chartsImport-moved.ts
@@ -0,0 +1,62 @@
+import { moveSpecifiers } from "../../helpers";
+
+// https://github.com/patternfly/patternfly-react/pull/11091
+
+const specifiersToMove = [
+'Chart',
+'ChartArea',
+'ChartAxis',
+'ChartBar',
+'ChartBoxPlot',
+'ChartBullet',
+'ChartBulletComparativeErrorMeasure',
+'ChartBulletComparativeMeasure',
+'ChartBulletComparativeWarningMeasure',
+'ChartBulletPrimaryDotMeasure',
+'ChartBulletPrimarySegmentedMeasure',
+'ChartBulletQualitativeRange',
+'ChartContainer',
+'ChartCursorContainer',
+'ChartCursorTooltip',
+'ChartCursorFlyout',
+'ChartDonut',
+'ChartDonutThreshold',
+'ChartDonutUtilization',
+'ChartGroup',
+'ChartLabel',
+'ChartLegend',
+'ChartLegendTooltip',
+'ChartLegendTooltipContent',
+'ChartLegendTooltipLabel',
+'ChartLine',
+'ChartPie',
+'ChartPoint',
+'ChartScatter',
+'ChartStack',
+'ChartTheme',
+'ChartThemeColor',
+'ChartThreshold',
+'ChartTooltip',
+'ChartVoronoiContainer',
+'createContainer',
+'getInteractiveLegendEvents',
+'getInteractiveLegendItemStyles',
+'getCustomTheme',
+'getTheme',
+'getThemeColors'
+];
+
+const fromPackage = "@patternfly/react-charts";
+const toPackage = "@patternfly/react-charts/victory";
+const messageAfterImportNameChange =
+  "been moved. This rule will update import paths.";
+
+module.exports = {
+  meta: { fixable: "code" },
+  create: moveSpecifiers(
+    specifiersToMove,
+    fromPackage,
+    toPackage,
+    messageAfterImportNameChange
+  ),
+};
diff --git a/packages/eslint-plugin-pf-codemods/src/rules/v6/chartsImportMoved/chartsImportMovedInput.tsx b/packages/eslint-plugin-pf-codemods/src/rules/v6/chartsImportMoved/chartsImportMovedInput.tsx
@@ -0,0 +1 @@
+import { Chart } from "@patternfly/react-charts";
diff --git a/...ages/eslint-plugin-pf-codemods/src/rules/v6/chartsImportMoved/chartsImportMovedOutput.tsx b/...ages/eslint-plugin-pf-codemods/src/rules/v6/chartsImportMoved/chartsImportMovedOutput.tsx
@@ -0,0 +1,3 @@
+import {
+  Chart
+} from '@patternfly/react-charts/victory';
diff --git a/packages/pf-codemods/README.md b/packages/pf-codemods/README.md
@@ -368,6 +368,26 @@ export const CardUpdatedClickableMarkupInput = () => {
 };
 ```
 
+### chartsImport-moved [(#11091)](https://github.com/patternfly/patternfly-react/pull/11091)
+
+In order to support multiple chart libraries, Victory based charts have moved. This rule will update import paths to our victory directory.
+
+Additionally, Victory has become a peer dependency.
+
+#### Examples
+
+In:
+
+```jsx
+import { Chart } from "@patternfly/react-charts";
+```
+
+Out:
+
+```jsx
+import { Chart } from '@patternfly/react-charts/victory';
+```
+
 ### checkbox-radio-replace-isLabelBeforeButton [(#10016)](https://github.com/patternfly/patternfly-react/pull/10016)
 
 The `isLabelBeforeButton` prop in Checkbox and Radio has been replaced with `labelPosition="start"`
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		import { Chart } from "@patternfly/react-charts";