Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v6 class name updater does not support absolute paths #802

Closed
wise-king-sullyman opened this issue Nov 13, 2024 · 0 comments · Fixed by #803
Closed

v6 class name updater does not support absolute paths #802

wise-king-sullyman opened this issue Nov 13, 2024 · 0 comments · Fixed by #803

Comments

@wise-king-sullyman
Copy link
Collaborator

Passing absolute paths to the class name updater causes an error to be thrown.

It appears that the absolute path is incorrectly being resolved to being relative to the dir where the command is ran.

Image

@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Nov 13, 2024
rh-gvincent added a commit to rh-gvincent/pf-codemods that referenced this issue Nov 14, 2024
Closes patternfly#802

If the path given to class name updater is an absolute path, the tool raises an error.
It adds the current working dir regardless of the path type.

This patch fixes this issue and only adds the current working dir if the file path is not absolute.
wise-king-sullyman pushed a commit that referenced this issue Nov 14, 2024
Closes #802

If the path given to class name updater is an absolute path, the tool raises an error.
It adds the current working dir regardless of the path type.

This patch fixes this issue and only adds the current working dir if the file path is not absolute.
@github-project-automation github-project-automation bot moved this from Needs triage to Done in PatternFly Issues Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant