Skip to content
This repository has been archived by the owner on May 13, 2020. It is now read-only.

Working with turbolinks #2

Open
spherop opened this issue Nov 6, 2016 · 7 comments
Open

Working with turbolinks #2

spherop opened this issue Nov 6, 2016 · 7 comments

Comments

@spherop
Copy link

spherop commented Nov 6, 2016

I wonder if theres a way to get this to play nice. In my rails 5 app on first load - shows the editor - but navigation away and back to the same page - the editor is no longer visible. Turning off turbolinks fixes this issue.

Any thoughts welcome.

@domi91c
Copy link

domi91c commented Jan 25, 2017

I'm having a similar issue. On first load the editor is not visible, but when once I reload the page it becomes visible.

@NanoMeko
Copy link

Same issue here.. First load invisible, then visible after reload. Did you fix the issue?

@paul-at
Copy link
Owner

paul-at commented Feb 28, 2017

I used a workaround (described in readme): to add data: { turbolinks: false } html option to all external links to the page with editor.

If someone makes a proper fix, please feel free to create a PR.

@bluestorm21
Copy link

bluestorm21 commented Jan 26, 2018

I am not using this gem but I use quill through CDN and I have the same issue with it... so I used your solution data: { turbolinks: false } but sometimes it still bugging... I just got rid of the CDN link and copied the js file to my assets/javascripts and so far it seems working fine!

@scarroll32
Copy link

I used a workaround (described in readme): to add data: { turbolinks: false } html option to all external links to the page with editor.

This is not an optimal solution as you are then disabling Turbolinks for the whole page.

@paul-at
Copy link
Owner

paul-at commented Oct 22, 2018

Sean, your statement is not entirely correct. The parameter disables use of Turbolinks to follow the link, however they remain enabled on both linked and linking pages.

That said, I entirely agree that it is not a good solution and will welcome a PR.

@scarroll32
Copy link

scarroll32 commented Oct 22, 2018

@paul-at really, OK that's news to me. I had thought the whole page would be inactivated, but I'm happy to be corrected.

The docs are not super-clear here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants