Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guidebook doesn't open in hand #399

Open
MJRamon opened this issue Jan 12, 2022 · 9 comments
Open

Guidebook doesn't open in hand #399

MJRamon opened this issue Jan 12, 2022 · 9 comments
Labels
bug Something isn't working compatibility

Comments

@MJRamon
Copy link

MJRamon commented Jan 12, 2022

BCLib 1.2.2
BetterEnd 1.0.0

It opens only on lectern.

@paulevsGitch
Copy link
Owner

What mod version are you using? What are in game logs?

@paulevsGitch paulevsGitch added the question Further information is requested label Jan 12, 2022
@MJRamon
Copy link
Author

MJRamon commented Jan 12, 2022

No logs. Mod versions are in first message.

@paulevsGitch
Copy link
Owner

No logs

What do you mean? Game always logs everything that is happening into logs folder

Mod versions are in first message.

I mean Patchouli version

@MJRamon
Copy link
Author

MJRamon commented Jan 12, 2022

Patchouli-1.18.1-64-FABRIC

I mean, no information about this problem in log files.

@paulevsGitch
Copy link
Owner

BetterEnd book is added with Patchouli API, so there can be two reasons:

  • API was changed and now require some additional json information
  • Patchouli has bug in its book items

If your Patchouli version is not latest try to update it. I can also recommend post same issue on Patchouli tracker

@paulevsGitch paulevsGitch added bug Something isn't working compatibility external problem Looks like this issue is not on our side and removed question Further information is requested labels Jan 12, 2022
@Hubry
Copy link

Hubry commented Jan 12, 2022

//TODO: reanable Patchouli once it is available for 1.18
//PatchouliAPI.get().openBookGUI((ServerPlayer) user, BOOK_ID);

Looks like your fault.

@paulevsGitch paulevsGitch removed the external problem Looks like this issue is not on our side label Jan 12, 2022
@Zarepheth
Copy link

@paulevsGitch, I think you misunderstood @Hubry. It appears that BetterEnd has commented out Patchouli support and someone needs to reenable it.

@Brittank88
Copy link

So literally one line of code needs to be uncommented? Darn, I hope that's resolved soon if it's truly that simple. Understandable if it isn't though.

@Brittank88
Copy link

Ah, nevermind, just learned about the new repo: https://github.com/quiqueck/BetterEnd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working compatibility
Projects
None yet
Development

No branches or pull requests

5 participants