For yegor256#939: Code review corrections.

paulodamaso · Jan 28, 2019 · 09916f5 · 09916f5
1 parent 02e13e4
commit 09916f5
Show file tree

Hide file tree

Showing 2 changed files with 36 additions and 3 deletions.
diff --git a/pom.xml b/pom.xml
@@ -143,11 +143,12 @@
                 <groupId>org.junit.jupiter</groupId>
                 <artifactId>junit-jupiter-api</artifactId>
                 <version>5.3.1</version>
+                <scope>test</scope>
             </dependency>
             <dependency>
                 <groupId>org.junit.jupiter</groupId>
                 <artifactId>junit-jupiter-engine</artifactId>
-                <version>5.1.0</version>
+                <version>5.3.1</version>
                 <scope>test</scope>
             </dependency>
         </dependencies>
@@ -191,6 +192,38 @@
                         </tags>
                     </configuration>
                 </plugin>
+                <plugin>
+                    <artifactId>maven-surefire-plugin</artifactId>
+                    <version>3.0.0-M3</version>
+                    <configuration>
+                        <useFile>false</useFile>
+                        <runOrder>random</runOrder>
+                        <trimStackTrace>false</trimStackTrace>
+                        <failIfNoTests>false</failIfNoTests>
+                        <failIfNoSpecifiedTests>true</failIfNoSpecifiedTests>
+                        <parallel>all</parallel>
+                        <parallelTestsTimeoutInSeconds>0</parallelTestsTimeoutInSeconds>
+                        <parallelTestsTimeoutForcedInSeconds>0</parallelTestsTimeoutForcedInSeconds>
+                        <perCoreThreadCount>true</perCoreThreadCount>
+                        <threadCount>4</threadCount>
+                    </configuration>
+                </plugin>
+                <plugin>
+                    <artifactId>maven-failsafe-plugin</artifactId>
+                    <version>3.0.0-M3</version>
+                    <configuration>
+                        <encoding>${project.build.sourceEncoding}</encoding>
+                        <failIfNoSpecifiedTests>false</failIfNoSpecifiedTests>
+                        <forkCount>0</forkCount>
+                        <parallel>all</parallel>
+                        <parallelTestsTimeoutForcedInSeconds>0</parallelTestsTimeoutForcedInSeconds>
+                        <parallelTestsTimeoutInSeconds>0</parallelTestsTimeoutInSeconds>
+                        <perCoreThreadCount>true</perCoreThreadCount>
+                        <runOrder>random</runOrder>
+                        <threadCount>8</threadCount>
+                        <trimStackTrace>false</trimStackTrace>
+                    </configuration>
+                </plugin>
             </plugins>
         </pluginManagement>
         <plugins>

diff --git a/qulice-findbugs/src/test/java/com/qulice/findbugs/FindBugsValidatorTest.java b/qulice-findbugs/src/test/java/com/qulice/findbugs/FindBugsValidatorTest.java
@@ -32,7 +32,7 @@
 import com.google.common.base.Joiner;
 import com.qulice.spi.Environment;
 import com.qulice.spi.ValidationException;
-import org.junit.Ignore;
+import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 
 /**
@@ -58,7 +58,7 @@ public void passesCorrectFilesWithNoExceptions() throws Exception {
      * FindbugsValidator can report incorrectly added throws.
      * @throws Exception If something wrong happens inside
      */
-    @Ignore
+    @Disabled
     @org.junit.Test(expected = ValidationException.class)
     public void reportsIncorrectlyAddedThrows() throws Exception {
         final byte[] bytecode = new BytecodeMocker()