isNotCommonlyUsed method fix.

pavlo-bystrytskyi · Sep 3, 2024 · 37265b9 · 37265b9
1 parent 89368d1
commit 37265b9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/main/java/org/example/PasswordValidator.java b/src/main/java/org/example/PasswordValidator.java
@@ -2,7 +2,7 @@
 
 public class PasswordValidator {
     static int MINIMUM_PASSWORD_LENGTH = 8;
-    private static String[] COMMONLY_USED = {"Password1!", "Aa345678"};
+    private static final String[] COMMONLY_USED = {"Password1!", "Aa345678"};
 
     public static boolean isValid(String password) {
         return isLengthCorrect(password)
@@ -25,8 +25,8 @@ public static boolean containsUppercaseLowercase(String password) {
     }
 
     public static boolean isNotCommonlyUsed(String password) {
-        for (String commonlyUsed : COMMONLY_USED) {
-            if (commonlyUsed.contains(password)) {
+        for (String commonlyUsedPassword : COMMONLY_USED) {
+            if (commonlyUsedPassword.equals(password)) {
                 return false;
             }
         }

diff --git a/src/test/java/org/example/PasswordGeneratorTest.java b/src/test/java/org/example/PasswordGeneratorTest.java
@@ -5,7 +5,7 @@
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
 class PasswordGeneratorTest {
-    private static int GENERATIONS_NUMBER = 50;
+    private static final int GENERATIONS_NUMBER = 50;
 
     @Test
     void generatePassword() {