From 7c318af7923e997fcf350c25041d283f47b06a58 Mon Sep 17 00:00:00 2001 From: Pavlo Bystrytskyi Date: Tue, 3 Sep 2024 15:07:15 +0200 Subject: [PATCH] org.example.PasswordGenerator.generatePassword refactoring --- src/main/java/org/example/PasswordGenerator.java | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/src/main/java/org/example/PasswordGenerator.java b/src/main/java/org/example/PasswordGenerator.java index 70336b7..b35e6fe 100644 --- a/src/main/java/org/example/PasswordGenerator.java +++ b/src/main/java/org/example/PasswordGenerator.java @@ -7,13 +7,17 @@ public class PasswordGenerator { public static void main(String[] args) { for (int i = 0; i < 50; i++) { - System.out.println(generatePassword()); + System.out.println(generatePassword(20)); } } public static String generatePassword() { + return generatePassword(MINIMUM_PASSWORD_LENGTH); + } + + public static String generatePassword(int length) { while (true) { - String password = generateNonValidatedPassword(); + String password = generateNonValidatedPassword(length); if (PasswordValidator.isValid(password)) { return password; @@ -21,10 +25,10 @@ public static String generatePassword() { } } - private static String generateNonValidatedPassword() { + private static String generateNonValidatedPassword(int length) { Random random = new Random(); - char[] passwordElements = new char[MINIMUM_PASSWORD_LENGTH]; - for (int i = 0; i < MINIMUM_PASSWORD_LENGTH; i++) { + char[] passwordElements = new char[length]; + for (int i = 0; i < length; i++) { // Magic! passwordElements[i] = (char) (33 + random.nextInt(94)); }