-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
To-do topics #2
Comments
I try to understand why my issue #7 is raised, so I used parts of your code to create an own solution. If it works, and I find the issue, I would share it with you, so we can work on the open topics. |
I think that in general this function module for comparing tables is bad idea - so I will probably replace this part. Regarding help - of course, if you have some new functions, improvements, then feel free to submit a pull request :) |
Why do you think it is a bad idea? Somehow you have to compare the results to see if it matches your expectation or if the new development will be faster. I have a similar comparing function to check transformations between different systems. It works, or do you have another idea to compare the results? |
In general usage of this FM provide a couple of issues. Firstly it checks also the type of the fields, which also lead to dump (or provide that the results don't match I don't remember now). Secondly - for now, there is no feedback on what value exaclty is wrong. Definitely, I want to display a table for users with information (i.e. colours) which value is good, and which one is not good. Not only do a general check. The big challenge is I want to keep this solution for a single copy-paste installation like abapgit, so I don't know can simple ALV in popup handle this. If not then maybe an HTML table is a solution 🤔 |
In my transformation checker, I mark false or wrong entries with a red background. You can see it here on the short video https://youtu.be/OMXl3DjfN7g maybe this is a solution? |
That definitely makes sense ! I would like to show a complete table with result and colour the cells where we have differences :)
… On 11 Oct 2021, at 10:07, Tobias Meyer ***@***.***> wrote:
video
|
At the moment I am trying to make the solution flexible enough to dynamic tables. The problem is at the moment the comparing of the tables. If I have an idea that works I will share it on GitHub. |
Thanks ! In the meantime I will check AMDP processing.
|
I have now a table comparison created which is in my opinion flexible enough. I upload the source code later, the readme is already filled https://github.com/reyemsaibot/table_compare |
Thanks Tobias ! I will check this later. Yesterday I probably figure out how to process via AMDP, but I need to test more to confirm :)
… |
If you need help to test something let me know. |
If you want to help with some topic, please create a separate GitHub issue. This one is only for discussing new features.
Major:
The text was updated successfully, but these errors were encountered: