-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove -Z
#707
Comments
I deleted a comment I posted earlier because I thought I made a mistake. This was not a mistake after all (shouldn't have looked at it after getting up at 4:15 am 😛 ) Paths must use backslashes, right? YSI-Includes even forces this ( I can't include my own source files using backslashes in path (err 100). However, In case more information is needed... Workspace Information:
MCVEImagine the following files (relative to gamemodes):
//Definitions, not relevant
#include "src/core.inc"
//Definition checks, set options according to env, etc
//Not relevant even though some compiler options may be altered; issue persists without them)
#define KGM_ENV
#include "src/assembly.inc"
#include <a_samp>
#undef MAX_PLAYERS
#define MAX_PLAYERS MAX_SLOTS
//#undef MAX_SLOTS
//samp, plugins (non YSI includes)
#include <a_mysql>
#include <crashdetect>
#include <filemanager>
#include <samp_bcrypt>
#include <sscanf2>
//YSI includes
#if KGM_ENV < ENV_DEBUG_EXTRA
#define YSI_NO_HEAP_MALLOC
#else
#define YSI_YES_HEAP_MALLOC
#endif
#include <YSI_Coding/y_hooks>
#include <YSI_Coding/y_inline>
#include <YSI_Coding/y_timers>
#include <YSI_Coding/y_va>
#include <YSI_Data/y_foreach>
#include <YSI_Players/y_android>
//#include <YSI_Players/y_languages>
//#include <YSI_Players/y_text>
#include <YSI_Visual/y_commands>
#include <YSI_Visual/y_dialog>
//KGM: Utilities
#include "kgm-src/util/colors.inc"
#include "kgm-src/util/debug/entry.inc"
//KGM: Base init
#include "kgm-src/run/init/early.inc"
#if !defined KGM_CORE
#error Don't compile the .inc files - Compile the .pwn file under (PROJECT_ROOT)/gamemodes/ instead!
#endif |
Issue description:
-Z
was added to fix one single breaking change, namely that of_inc_
auto-generated include guards. However, the need for this is long past; includes have been updated and can deal without those guards. Now the flag just causes more confusion as people seem to think it reverts all non-breaking changes as well, which was never the intention, then get surprised when it doesn't.Minimal complete verifiable example (MCVE):
Workspace Information:
The text was updated successfully, but these errors were encountered: